Commit Graph

49 Commits

Author SHA1 Message Date
Artem Bochkarev
29e29f2649 IDEA-272894: code cleanup
remove Popover.m

GitOrigin-RevId: 0a56fdc61d7078da8da7ec0d4cb37d3a467f774b
2021-07-05 07:00:36 +00:00
Artem Bochkarev
ce06ff91ee IDEA-272894: fix object release
strong property doesn't clear automatically

GitOrigin-RevId: f55f6d24690c1739de5c3814d877d9b51d18480c
2021-07-05 06:49:09 +00:00
Artem Bochkarev
b28894eb2e IDEA-272894: release items of touchbar in AppKit
theoretically it can fix SIGSEGV at [libobjc.A.dylib] objc_msgSend in -[NSTouchBarViewController _updateTree]

GitOrigin-RevId: f545b89f023bf8a599f7785ab359cba83a520c53
2021-07-01 21:23:48 +00:00
Artem Bochkarev
167efd84cb IDEA-272894: release NSObject of touchbar in AppKit
theoretically it can fix SIGSEGV at [libobjc.A.dylib] objc_msgSend in -[NSTouchBarViewController _updateTree]

GitOrigin-RevId: 81bdaa523bb5fcd73857f000d96487d9347483d1
2021-07-01 21:23:46 +00:00
Artem Bochkarev
101cc800a1 IDEA-272131: make more exception-safe
suppress possible layout exception

GitOrigin-RevId: d00c850d3896771494b2e0a32af6a2eb0a9a04b6
2021-07-01 21:23:39 +00:00
Artem Bochkarev
aa0e7117cb IDEA-272131: suppress intermittent exception
thrown during update of button [NSView(NSConstraintBasedLayout) _tryToAddConstraint]

GitOrigin-RevId: 5d572f5c58fd8667d2ed9abb51bd84ac932b0db5
2021-07-01 21:23:38 +00:00
Artem Bochkarev
67ba8a6286 IDEA-269957: intercept outOfRange exception
just workaround (real exception reason is unknown), fixed IDEA-269957

GitOrigin-RevId: 02b423811c400d49e889fcf17a40e225b09f5225
2021-06-04 08:10:04 +00:00
Artem Bochkarev
194eaaab0c IDEA-267047: fixed memory-management error
also fix warnings along the way

GitOrigin-RevId: 985843c6ee9f1a6818cae44e2eed14c10581ae26
2021-04-15 10:41:15 +03:00
Artem Bochkarev
1a4a1db684 IDEA-223893: reimplement touchbar support
GitOrigin-RevId: 07a8609a530749570bc2084b91f88aeea41144af
2021-04-10 10:49:17 +00:00
Roman Shevchenko
f8e1e3b0a0 [build scripts] exit codes in macOS file watcher and TouchBar support build scripts
GitOrigin-RevId: 1c456f25eac7800eed11cbbcd308f09128bb76f2
2020-11-19 21:48:35 +00:00
Roman Shevchenko
43a5187ea6 [build scripts] correcting macOS TouchBar support artifact name
GitOrigin-RevId: 7605134b607cf52f890052bef34a42a641e91ca4
2020-11-19 21:43:44 +00:00
Florian Kistner
7bdeca9bbf IDEA-CR-68907: Make install conditional, add native build dirs to gitignore
GitOrigin-RevId: 01c308d79b06f2ddc20391e87e09261f7369908c
2020-11-19 11:01:35 +00:00
Florian Kistner
9bddc1bd50 Darwin arm64: Fix native helpers compiler warnings
GitOrigin-RevId: 4449afe13eaff0ca6059a283e33c5e539d532710
2020-11-19 11:01:32 +00:00
Florian Kistner
71f5dd3bb9 Darwin arm64: Compile fat binaries for native helpers
GitOrigin-RevId: a4dc15f515cf01219f79ddeeabfa3cd8217abd77
2020-11-19 11:01:31 +00:00
Artem Bochkarev
e883f16a2d touchbar: make native code more exception-safe
Scrubber item of touchbar can throw NSInternalInconsistencyException during
items update. This is undocumented behaviour (so the reason is unknown) and it's better to suppress such exceptions now.

fixed IDEA-223539 Crash on Alt+Enter

GitOrigin-RevId: 7297e7f3eabb02d83d18558ff91052a7699387fd
2019-09-25 14:32:26 +00:00
Artem Bochkarev
0017fa5e7d touchbar: calculate images of buttons in background thread
fixed IDEA-217863

GitOrigin-RevId: 04c9cec59114d856e55062aea56d0f6cd9063098
2019-09-24 18:02:16 +00:00
Artem Bochkarev
25a93ee13a touchbar: implemented async update for the images of scrubber items
fixed IDEA-217863 Run configuration icon calculation takes so long

GitOrigin-RevId: c3c5b8c8cb00a44bc8be881961e05f0ccba8fe04
2019-09-24 18:02:16 +00:00
Artem Bochkarev
c4421d3859 touchbar: fixed IDEA-218342 IDEA crash on a dropdown filtering
1. remake update logic: load all items on creation, but invisible items are loaded without heavy data (string and text)

2. more compact items packing

3. minor fixes and code cleanup

GitOrigin-RevId: 4a9e73ffae59f145474a263fc8a731b4c612f755
2019-07-16 19:33:13 +03:00
Artem Bochkarev
15fa8329d5 touchbar: fixed IDEA-203207 Touch Bar: Options on the Touch Bar should be filtered when searching in popup
GitOrigin-RevId: 1b09df8d8f5804e64cd4846ac52a98e205cc8e8a
2019-07-08 12:04:21 +03:00
Artem Bochkarev
c737b34595 fixed: JBR-1347 Instaneous exit on using Alt-Enter to add an import automatically (MenuData::HandleGetNamedAccessibleAttribute)
add extra npe checks
2019-04-08 13:24:01 +07:00
Artem Bochkarev
c71c65f1e7 touchbar: fixed IDEA-208708 JVM crashes when creating vcs diff window 2019-03-13 12:37:39 +07:00
Artem Bochkarev
a82d09f74e touchbar: load scrubber items by parts (to speedup creation)
for example, git-branches popup of IDEA-project has thousands of items
2019-03-06 13:59:59 +03:00
Artem Bochkarev
e03ccd53a4 touchbar: code cleanup 2019-03-06 13:59:58 +03:00
Artem Bochkarev
607d3cc44d MacBook touch bar: remove arrow-icon from 'Add configuration' button (of default touchbar)
also hide run-buttons when configuration isn't defined
fixed point 3 from IDEA-194893 MacBook touch bar: improve Configurations popover
2018-07-16 19:14:41 +07:00
Artem Bochkarev
f26b9b457b MacBook touch bar: cosmetic fixes
fixed IDEA-194896 MacBook touch bar: use close icon instead of close button

fixed half of subissues from IDEA-194893 MacBook touch bar: improve Configurations popover
2018-07-16 13:49:01 +07:00
Artem Bochkarev
3eb2576fd2 IDEA-194199: implemented WelcomeDialog
with minor cosmetic fixes and behaviour improvements
2018-06-27 20:24:02 +07:00
Artem Bochkarev
04edc0122c IDEA-194199: fixed layout (width with insets) for dialog buttons 2018-06-19 19:57:18 +07:00
Artem Bochkarev
c0243bfceb IDEA-163208: visual improvements (native)
working toggles (for instances of ToggleAction, for example breakpoints)
image position tight to text
add ellipsis for long text
2018-06-16 19:55:53 +07:00
Artem Bochkarev
8d304bc944 IDEA-163208: refactoring (with fix of leak)
extract ItemsContainer into separate class to use with both java-wrappers for 'group' and 'touchbar' (fixed memory leak)
composite actions of button (to implement auto-close bars)
remove TouchBarProjectBase, TouchBarActionBase (unnecessary layers)
simplify TBItem's api with code cleanup
remove unnecessary syncronized-blocks and NSAutoreleasePool
2018-06-12 19:00:12 +07:00
Artem Bochkarev
8816fa751a IDEA-163208: add appcode project files (for NST) 2018-06-03 14:55:36 +07:00
Artem Bochkarev
7073813162 IDEA-163208: support priorities of items
make priority of optional-button lower than main dialog buttons group
2018-05-20 23:58:36 +07:00
Artem Bochkarev
6d8986f451 IDEA-163208: fixed fonts and insets 2018-05-20 23:58:29 +07:00
Artem Bochkarev
c702e1526d IDEA-163208: increase resolution of touchbar images
touchbar is the retina display, 144 dpi
2018-05-10 12:36:52 +07:00
Artem Bochkarev
c8e8fc8665 IDEA-163208: use principal group-item to center main confirmation buttons of dialog 2018-05-04 17:40:23 +07:00
Artem Bochkarev
cadaea9448 IDEA-163208: added possibility to replace default esc button with custom 2018-05-04 17:40:23 +07:00
Artem Bochkarev
b562b727c8 IDEA-163208: minor fixes for scrubber
highlight selection + initial selection is none
2018-04-26 15:00:12 +07:00
Artem Bochkarev
f4cd19f306 IDEA-163208: support buttons flags (selected/colored/disabled) 2018-04-26 15:00:11 +07:00
Artem Bochkarev
fc0eccf6b4 IDEA-163208: add syncronization between EDT and AppKit threads 2018-04-04 14:39:07 +07:00
Artem Bochkarev
a5bb2bbda9 IDEA-163208: refactoring of NSTLibrary
remove unnecessary proxy-objects (on native side), simplify interface
2018-03-30 18:26:11 +07:00
Artem Bochkarev
80a9de5c54 IDEA-163208: make single wrapper for buttons with image and text 2018-03-30 18:26:11 +07:00
Artem Bochkarev
054eb24469 IDEA-163208: add popover manipulation methods 2018-03-30 18:26:11 +07:00
Artem Bochkarev
05c41dce1b IDEA-163208: fixes for popover
1. fixed width popover via layout constrints
2. add ButtonImgText (to use as tap-and-hold item)
2018-03-26 18:47:06 +07:00
Artem Bochkarev
788daa7fe3 IDEA-163208: scrubbers support (with objc refactoring) 2018-03-26 18:47:06 +07:00
Artem Bochkarev
3420cc5404 IDEA-163208: fixed width of popover 2018-03-26 18:47:05 +07:00
Artem Bochkarev
f12701fa5a IDEA-163208: add spacing support 2018-03-26 18:47:05 +07:00
Artem Bochkarev
6d7c3d4132 IDEA-163208: refactoring for obj-c code
Also implemented alpha-images and popovers support
2018-03-20 23:50:00 +07:00
Artem Bochkarev
e0fe481d65 IDEA-163208: fix ref-count issues 2018-03-13 14:40:04 +07:00
Artem Bochkarev
985493e5da IDEA-163208: native code refactoring with fixes
fixed: TODOs, memory management
add initial gradle script (to build libnst manually)
2018-03-13 13:45:30 +07:00
Artem Bochkarev
dd7a334894 IDEA-163208: initial impl of touchbar support
NOTES: объект-делегат (для создания TB-итемов по запросу) определен в нативной либе, присоединяется к NSApplication в момент инициализации; в качестве альтернативы можно создавать и настраивать объекты типа TouchBar и TouchBarItem через Foundation, однако такое решение выглядит менее гибким (+ неудобочитаемый и некомпактный код)
2018-03-06 14:31:12 +07:00