Commit Graph

3113 Commits

Author SHA1 Message Date
Vladimir Krivosheev
f88f078dda bazel: update model
GitOrigin-RevId: dcd1f70f9ee2d7f04919b2da0eb725d6c5e54c3d
2024-10-07 12:22:54 +00:00
Nikita.Ashihmin
a82c5d2f20 PY-71854 Platform(refactor): Replace all usage of old non file type specific File limits to the new FileSizeLimit
GitOrigin-RevId: c65b945a34e24ab79b06f2039361fd6dcc1048e7
2024-10-05 23:58:19 +00:00
Vladimir Krivosheev
4a176d4c02 IJ-CR-146078 extract intellij.platform.bootstrap
GitOrigin-RevId: b79efc92829111228e83058e54381d8e02116b6f
2024-10-05 22:01:55 +00:00
Daniil Ovchinnikov
823e985f18 API dumps: re-generate dumps
GitOrigin-RevId: b5cec844cbfe3313723404f7a85b590c25350b41
2024-10-04 21:20:21 +00:00
Aleksey Pivovarov
0c7aa58e59 IJPL-163247 diff: fix "Undo" in Unified diff viewer
'com.intellij.openapi.fileEditor.EditorDataProvider' used to have a priority over
'com.intellij.openapi.fileEditor.impl.EditorWindow' for FileEditor data key.
Thus, UndoAction used to get 'TextEditorProvider.EditorWrapper' instead of 'DiffEditorViewerFileEditor'.

Unified viewer is not using 'com.intellij.diff.tools.holders.TextEditorHolder', so needs an own fix for IJPL-156898.
Follow-up: b6c36e30572c84933fe09fefa8b40143c7a36309

GitOrigin-RevId: 7cfdd628c2c8c41e1d538aec4e7c87495920e1dd
2024-10-04 16:28:21 +00:00
Aleksey Pivovarov
9309701e72 IJPL-163243 diff: fix "Missing semicolon" errors not being shown in Unified diff viewer
GitOrigin-RevId: d7a0ccbee60f85aed856cca2b9874e1382d3e01d
2024-10-04 15:45:32 +00:00
Nikolay Chashnikov
b01d4c953a IJPL-797 intellij.platform.diff.impl review internal API
Mark as internal classes which have no usages in the Marketplace and in plugins in the intellij project.

GitOrigin-RevId: 009e6fc11c39f8666ffae7d0f5d9313cc4ec948d
2024-10-03 17:39:16 +00:00
Roman Shevchenko
69479687e5 [project] replacing FileChooserDescriptor#isFileVisible with file- and/or extension-based filters (IJPL-150176)
GitOrigin-RevId: 7176005f3d39d2f2e928c2e5f804de173e5d83f4
2024-10-02 09:28:56 +00:00
Vladimir Krivosheev
a9e7930abe bazel - build lang-impl
GitOrigin-RevId: c4c4dce20bd6e4046644f95f6e7b3f437c51668d
2024-09-27 13:47:17 +00:00
Gregory.Shrago
acd6732fd9 add knownIssue section for top issues
GitOrigin-RevId: 3c14a0f95846e432a28fdc680089ebc124ddb8a3
2024-09-26 01:47:21 +00:00
Dmitry Batkovich
a2a9a816a9 IJPL-161819 inline prompt detection:
* add context to generation prompt
* implement support for html, yaml, json
* remove progress bar from generation status bar
* change UX to highlight regeneration / prompt clarification after generation done
* refactor code

GitOrigin-RevId: c87d4dd1302e44a281d86d7f7861d6b2c94ef29f
2024-09-24 07:50:10 +00:00
Aleksey Pivovarov
c796e05468 EA-1469039 IJPL-101036 diff: better mocking in UnifiedImaginaryEditor
GitOrigin-RevId: 21a077ad656db3277ac84487560ed1050291d1fd
2024-09-23 13:33:33 +00:00
Vladimir Krivosheev
834bd75254 run jps-to-bazel by Bazel, compile platform using Bazel
GitOrigin-RevId: 3774d5adc404b02036f70b7cc35c9e60fdb5d84c
2024-09-21 00:54:17 +00:00
Lev Serebryakov
6400f70dde IJPL-149317 More explicit locks.
GitOrigin-RevId: 8564e9e1b352a77c3ca0d44470fdbbda5f1e9c49
2024-09-19 18:43:28 +00:00
Ilia.Shulgin
9e5b3bf53e [diff] IJPL-161760 Invalidate DiffFilePathLabelWrapper on theme update
Label size was set to 0x0 after theme update

GitOrigin-RevId: fae07e9d664da1c0b335231a21422297811864bb
2024-09-18 18:22:43 +00:00
Vladimir Krivosheev
09bdd80767 diff-impl - avoid multiple content roots
GitOrigin-RevId: f0c0e3cdc78ef834408fb5de6ad5e5f76922aff5
2024-09-17 20:21:34 +00:00
Vadim Salavatov
33f306e990 IJPL-161819 update api dump
GitOrigin-RevId: 125637b43e7e72a954c4526456f5cf4bdc234656
2024-09-16 20:51:55 +00:00
Konstantin Nisht
4fbc8c3e29 IJPL-161819 inline prompt code generation: show diff in the gutter after code generation
IJPL-162132: Clear progressbar only when a meaningful message arrives from LLM

IJPL-161819 gutter animation

IJPL-161819 hide bulb on edt

IJPL-161819 revert temporary code

IJPL-161819 properly dispose InlinePromptEditorFilter

IJPL-161819 hide unsupported actions

IJPL-162132: Do now show lightbulb after code generation

IJPL-161819 add tooltip text for line marker gutter

IJPL-161819 add revert action on gutter

IJPL-161819 move AIInEditorDiffRendererOnGutter to better packages

IJPL-161819 use proper diff color

IJPL-161819 move AIInEditorDiffRendererOnGutter to inlinePromptDetector module

also, add dependency on `intellij.platform.collaborationTools`

IJPL-161819 fix retry inlay text

IJPL-161819 add gutter markers to inline prompt

IJPL-161819 do not show generation diff on undo by default

cleanup

rename object

IJPL-161819 add `simplify` to prompt initiating words

IJPL-161819 ignore warnings shown while inline prompt is shown

IJPL-161819 ignore new errors in the current file when an inline prompt is shown

IJPL-161819 show diff after generation

Squashed commits:
Do not show quickfixes when the user is in inline prompt

add on generation diff

fix esc on retry

regenerate inlay

prevent blinking (fast fix)

add undo/redo FUS statistics

move diff listener class

hide diff on esc, add adv setting

dead code

hide diff before regeneration

do not show modified lines in diff (show them as deleted/added for more clarity)

better diff

make diff better

show diff on undo

something something

some ctrl+Z

GitOrigin-RevId: 2141d2e0b83c2b089780e0df1be12d43e4fff834
2024-09-16 20:51:55 +00:00
Aleksey Pivovarov
5087224ae0 diff: report used diff tools into FUS
GitOrigin-RevId: c68cd4d2268f43923bc6f8479e247550539386d2
2024-09-16 14:51:26 +00:00
Ilia.Shulgin
bec7876884 [diff] IJPL-162092 Fix missing path in unverioned files single side diff
GitOrigin-RevId: 9d0acc72d04111a71102189f681a8d8e3691ba4a
2024-09-13 19:55:39 +00:00
Ilia.Shulgin
1c681572dd [diff] Fix leak in FilePathDiffTitleCustomizer
`(JComponent) label.parent` was causing leak

GitOrigin-RevId: 9ac0dd70cf2293473102df2a0fb68322fe4ad664
2024-09-13 19:55:38 +00:00
Ilia.Shulgin
c242134f17 IJPL-161382 Support FilePathLabelWrapper in rem dev
Switch FilePathDiffTitleCustomizer to GridBagLayout, as GroupLayout isn't fully supported in RD

GitOrigin-RevId: 80c15edf70e0ad81cb1423a42d361894014997f9
2024-09-10 11:49:37 +00:00
Aleksey Pivovarov
040628070c diff: move EditorTabDiffPreview from [vcs-impl] to [diff-impl]
GitOrigin-RevId: ed7348283230288ac1aecbcc8999a44ef8e8d983
2024-09-09 16:29:11 +00:00
Aleksey Pivovarov
b2bc5e1223 diff: remove dependency on VcsEditorTabFilesManager
GitOrigin-RevId: 147d7554e49006d11866943ddaaa9f65350a0f27
2024-09-09 16:29:11 +00:00
Aleksey Pivovarov
a2b26d2f64 diff: drop 'DIFF_OPENED_IN_NEW_WINDOW' flag
GitOrigin-RevId: 872b7b54a28e4916332a7f8b5391229fc6dbfcd5
2024-09-09 16:29:11 +00:00
Aleksey Pivovarov
b8b2f0a5fc diff: move DiffEditorTabFilesManager implementation from [vcs-impl]
GitOrigin-RevId: 08b63232db191d60efa4b87db8e73fc9d7f22e2b
2024-09-09 16:29:11 +00:00
Aleksey Pivovarov
247b8078aa diff: reopen all FileEditor on 'Open Diff as Editor Tab' option toggle
GitOrigin-RevId: 7ad0568546b42ee84946ee5a9b870a2a22d3ab6c
2024-09-09 16:29:11 +00:00
Aleksey Pivovarov
b83a6715ba diff: use DiffEditorTabFilesManager over VcsEditorTabFilesManager
GitOrigin-RevId: af2bc69b324aacf8f2ca7393275f1cf8d58d74a4
2024-09-09 16:29:11 +00:00
Roman Shevchenko
a5666abead [project] pruning FileChooserDescriptor overrides (IJPL-150176 prerequisite)
`BrowseFolderRunnable` and `*WithBrowseButton` family: getting rid of separate "title" and "description" parameters in favor of the chooser descriptor object, to avoid cloning the latter down the road.

GitOrigin-RevId: 33ec5968a1db953c60848974135055c288accf85
2024-09-06 11:41:43 +00:00
Aleksey Pivovarov
78a686b0e9 EA-1444724 diff: fix assertion in UnifiedImaginaryEditor.calculateVisibleRange
GitOrigin-RevId: b727f2e9c3cf22e654bb328ae014af24c1ed2d7e
2024-09-03 15:25:17 +00:00
Aleksey Pivovarov
e3abda8435 IJPL-158397 lst: limit popup size to the IDE window size, not the screen size
GitOrigin-RevId: ca66e440c7feb87c5d920ec5dc8d376d5eeeea9f
2024-09-02 14:53:40 +00:00
Gregory.Shrago
038c336ddc migrate ActionPlaces.isPopupPlace usages
GitOrigin-RevId: 6caf1344423c8142a549d507c19e4ea40a721284
2024-08-28 05:13:52 +00:00
Aleksey Pivovarov
91a4ae539f diff: cleanup - use utility method
GitOrigin-RevId: 5c56514e059424cd37d9afd550a7ebf2405fdaaf
2024-08-28 04:35:20 +00:00
Aleksey Pivovarov
bca5ef6d62 diff: expose DiffRequestFactoryImpl methods via its interface
GitOrigin-RevId: 451f79c7436dbe722069d1e8c12e512091f7a7bc
2024-08-28 04:35:20 +00:00
Ivan Semenov
81f170fcd3 [collab/gitlab] implement and migrate gitlab code review to a new diff API
Selection change and scroll is now handled purely on the VM layer which allows for better control over the state
New API is more flexible and does not depend on RefComparisonChange
Changes sorting now happens on background

GitOrigin-RevId: d6de23870105fe75087ea2967b8ef9597e65fefd
2024-08-26 20:27:21 +00:00
Ivan Semenov
1340e20a31 [diff/collab] check if twoside diff is ready before scrolling or adding inlays/markers
GitOrigin-RevId: 8a102d5bdee0d7c2796814e876f93867225cdaf6
2024-08-26 20:27:21 +00:00
Ivan Semenov
b538759cd1 [diff/collab] public API for diff viewer scrolling
GitOrigin-RevId: 1707af0dcacf7c4bc6d0f7a2a3db99c8ab11e418
2024-08-26 20:27:21 +00:00
Ivan Semenov
6470b01d72 [diff] drop unused fun
GitOrigin-RevId: 4b7bbe2ed3f0a63b5028009bd3e859def5f76376
2024-08-26 20:27:21 +00:00
Gregory.Shrago
c420f560ff avoid ActionGroup.getChildren(null)
Use `DefaultActionGroup.getChildren(ActionManager)`.

GitOrigin-RevId: 1346ed7cccb2f6f92aeef2662b35c992836b7282
2024-08-21 16:42:06 +00:00
Aleksey Pivovarov
ec1ff6a502 IJPL-101036 diff: fix assertion from ProperTextRange in UnifiedImaginaryEditor.calculateVisibleRange
GitOrigin-RevId: 2a1f4b640f890ae68d81f14683e45d5950497661
2024-08-20 18:41:18 +00:00
Lev Serebryakov
50ddcf715b IJPL-149317 Wrap all Alarm clients to WriteIntentLock if ThreadToUse.SWING_THREAD is specified.
GitOrigin-RevId: 658f7273d8c65018b44e3b5b7bf2daea2374bf28
2024-08-20 17:01:13 +00:00
Aleksey Pivovarov
0a6fd8e8f0 editor: store FileEditorManagerImpl keys in one place
GitOrigin-RevId: d16c9d1b4b4d6e3cabf484de5ffe4d97f2442c6f
2024-08-20 13:29:05 +00:00
Aleksey Pivovarov
7e77230e33 editor: clarify 'isSingletonEditorInWindow' and 'canDockToolWindow' flags behavior
GitOrigin-RevId: 193dcbca0dabc2fd37a1f5eba7cd42f7be1576fe
2024-08-20 13:29:04 +00:00
Ilia.Shulgin
47f0f98b9b [diff] IJPL-101084 Improve diff titles in "Compare files" (MutableDiffRequestChain)
Use `FilePathDiffTitleCustomizer`

GitOrigin-RevId: cb3f7e96001ccca6879f3e13135cc34c6b66caa6
2024-08-17 09:50:36 +00:00
Ilia.Shulgin
a805a51ce8 [diff] IJPL-101084 Show path relative to project root in diff window
All diff requests created via `ChangeDiffRequestProducer#createRequest` will contain `DiffUserDataKeysEx.VCS_DIFF_RIGHT_CONTENT_TITLE` allowing to show short revision and file path relative to a project root

The same applies to diffs created via `MergedChangeDiffRequestProvider`

GitOrigin-RevId: 60ecb120e8751a6a211d2917838d6403a6003dfd
2024-08-17 09:50:36 +00:00
Ilia.Shulgin
ade0a71269 [diff] Use better read-only message
"This view is read-only" instead of "Failed to make writable"

GitOrigin-RevId: 8a09b4e9dd2e7bf92298394e1489b59ba18fada4
2024-08-17 09:50:35 +00:00
Ilia.Shulgin
2058ee0ff1 [diff] Change diff same content notification level to INFO
GitOrigin-RevId: e6d9f749068a40a1f781a5ebd1a77a828bc041e5
2024-08-17 09:50:35 +00:00
Aleksey Pivovarov
0f0a21de9a IJPL-160366 IDEA-104009 patch: suggest switching into editable view for patches
GitOrigin-RevId: aa883807ee8fe1ff50dc609420899d8c3071eb5f
2024-08-16 16:34:28 +00:00
Chris Lemaire
420cee4c81 [diff] Remove performance todo
Discussed with Aleksey Pivovarov that there would likely
be no significant performance impact from checking this.

GitOrigin-RevId: 0d2532f9527a2962da44b49beb8591f267f36b4c
2024-08-16 13:50:15 +00:00
Chris Lemaire
994dd46c9f [diff] Exclude diff editor history entries from persisting
#IJPL-158244 Fixed

GitOrigin-RevId: 95353a34ba795cf94be7131c1112f108738345e6
2024-08-16 10:30:39 +00:00