Commit Graph

180 Commits

Author SHA1 Message Date
Tagir Valeev
fdb37661df [lang] HierarchyNodeDescriptor: avoid computing tag icon/text in EDT
Fixes IDEA-326861 Type Hierarchy: slow operations on paint HierarchyNodeRenderer

GitOrigin-RevId: dba132544c8118dadf8487948b0b5e9b93f605c0
2023-08-14 12:18:24 +00:00
Ivan Yarkov
84e52e72ac CWM-576 make usage filters per client
GitOrigin-RevId: 023b4a40134737971947a84b3272a24f74e64a88
2023-07-31 16:40:57 +00:00
Gregory.Shrago
e0939fcd73 replace Modality.any with the current modality context
GitOrigin-RevId: be585ebeada8fc105e3f9f3ef4f86af275ec7568
2023-07-20 15:10:39 +00:00
Bas Leijdekkers
a317ab473c fix usage preview missing from rename refactoring additional rename dialog (IDEA-324363)
fix provided by Gregory.Shrago

GitOrigin-RevId: 139a65ce3e3d297eed92143e43cfeaf0d9188261
2023-07-20 12:36:27 +00:00
Sergei Tachenov
cb8546dc5c IDEA-324342 Get rid of UsageViewImpl renderer cache optimization
It was a workaround for performance problems in VariableHeightLayoutCache,
but this workaround itself had some performance problems.
Now that we've replaced VariableHeightLayoutCache with DefaultTreeLayoutCache
that doesn't try to access renderers for nodes outside the visible rectangle,
this workaround is no longer necessary and does more harm than good.

It appears that it was also queuing updates on the visible nodes in the process
of clearing the renderer cache, but tree updates seem to work just fine without it.
If it turns out there's a scenario when tree update doesn't work anymore,
it should be fixed separately, by updating nodes in background, like it should be done.

GitOrigin-RevId: bf443a0126e96eeda74e312c08eb36684e1a06e4
2023-07-14 17:31:14 +00:00
Leonid Shalupov
9508b71614 usages: perform slow operations on BGT in RerunSearchAction
relates to CPP-8459 Usages View may cause a freeze on update

GitOrigin-RevId: bba6db51ddea1f538b6330003da7472a58990c60
2023-07-10 11:09:37 +00:00
Leonid Shalupov
e38ffbdfed Rename .java to .kt
GitOrigin-RevId: d1496b9a82154dc8c9678ad698bcbc5e103a920f
2023-07-10 11:09:33 +00:00
Leonid Shalupov
f907961b03 CWM-8317 UsagePreviewPanel$Companion.highlight: Assertion failed java.lang.Throwable: Assertion failed
GitOrigin-RevId: 059a6ddd95ef8ab11f4371d98b0763cf987484ab
2023-07-03 19:14:54 +00:00
Nikolay Chashnikov
edf9db86c4 [platform] call SearchScope::contains under read action in UsageViewManagerImpl (EA-824220)
GitOrigin-RevId: 13b3b356d0e136372fee10d537ee8a68f651a441
2023-07-03 17:11:24 +00:00
Leonid Shalupov
7d3f5c12ff usages: usage preview: calc psi files on BGT
IDEA-307661 SlowOperation assertion in Usages View

GitOrigin-RevId: bc75fbd7bea25eb499f934e6a321e5715ca91306
2023-06-16 22:16:10 +00:00
Leonid Shalupov
de6d0fc2d4 usages: convert usage preview to kotlin
GitOrigin-RevId: 30c758fa8f46e5869aefd7a4f9a71402a46e59eb
2023-06-16 22:16:06 +00:00
Leonid Shalupov
dc393a64db Rename .java to .kt
GitOrigin-RevId: cb8d660469e459681e2d58ed3de2aa09f105158f
2023-06-16 22:16:03 +00:00
Daniil Ovchinnikov
97f0a7fd3b migrate usages of ModalityState.NON_MODAL to ModalityState.nonModal
GitOrigin-RevId: fb4855bfa90dbf384fed24871e4b28ab803847bb
2023-06-09 21:58:50 +00:00
Mikhail Sokolov
8e34a9dafb IDEA-319707 Go to usages: 'Ctrl+F' invokes search field instead of toggling 'Merge Usages from the Same Line' option
GitOrigin-RevId: 309e9130ce42b439d93ff2b2ff8e948dce5c508a
2023-06-09 10:24:52 +00:00
Alexey Belkov
f921c4fa2c Apply Kotlin inspection "Unnecessary type argument"
GitOrigin-RevId: f7c6e5cbae40bfe4e6d2c764b6baea4a9304e8fd
2023-06-01 08:50:07 +00:00
Alexey Kudravtsev
14ff37953d specify return type explicitly in Kotlin in some openapi and util to speedup Kotlin resolve
GitOrigin-RevId: 2b68c5d51524b822c645dbcb3828acbdd15245ad
2023-05-31 15:36:27 +00:00
Daniil Ovchinnikov
675b19fb2c IJPL-130 rename library kotlin-coroutines-jdk8 -> kotlin-coroutines-core
GitOrigin-RevId: e987a9f48391d74e401c860a57f99634ccc21a4a
2023-05-18 22:52:00 +00:00
Nikolay Chashnikov
82ad6405c2 [usage view] API cleanup: remove unused deprecated API (IDEA-312594)
GitOrigin-RevId: 449cb12595781c9e0f23f0d4e5a1d8e83f68b850
2023-05-15 13:57:44 +00:00
Nikita Mironov
9cdd2ded16 GO-5135 Add extension point for producing custom usages popups and their aggregator
GitOrigin-RevId: c5bd0fb0308b39e0d3e670da953277f5d2b19c18
2023-05-05 18:07:44 +00:00
Nikita Mironov
7ba5028a36 GO-5135 Replace directory grouping rule with a custom one if present (e.g. go package)
GitOrigin-RevId: 105e704991d7d2f55caa13651fd5f2f6e9708aa0
2023-05-05 18:07:44 +00:00
Nikita Mironov
51d78ea164 GO-5135 Make DirectoryGroupingRule extendable
GitOrigin-RevId: f0f4e72ad36bb668fb38b17319984d746e8f119a
2023-05-05 18:07:44 +00:00
Andrey Sokolov
9dfdbc66a2 Similar usages FUS-2357: don't load more snippets if theres nothing to load
GitOrigin-RevId: e763a6a9f140ffafb47193acb9ef69e08a4dc89b
2023-05-04 16:16:51 +00:00
Alexey Kudravtsev
6d9ab19f5b add missing method createConcurrentSet(); port existing usages with corresponding SSR
GitOrigin-RevId: 00645c36006d38198e8222030cf5ddd7ad7c8bf8
2023-04-21 17:31:35 +00:00
Andrey Sokolov
073a682ed4 IDEA-318478 Similar usage: Memory leak in Similar usages view
GitOrigin-RevId: acc3ab47e62943149bca3d0b879db9c989214895
2023-04-20 11:03:56 +00:00
Daniil Ovchinnikov
df1f55a499 IJPL-7 make methods of Navigatable default
They should not be required to be implemented, only `Navigatable.navigationRequest` is.

GitOrigin-RevId: b038cb465de3b9f1d6c37f8578ecd69f8667a10b
2023-04-20 10:56:47 +00:00
Andrey Sokolov
36e4748ab6 Find usages: wrap the logSearchStarted with readaction EA-836933
GitOrigin-RevId: c653865ce0c70b2c38307a32b2c2bec8d477a4df
2023-04-18 20:36:37 +00:00
Daniil Ovchinnikov
6fe5c49599 deprecate com.intellij.reference.SoftReference constructors
GitOrigin-RevId: a723be59b812f71953e79879d7adf09d58a9e935
2023-04-15 00:04:29 +00:00
Henry Wylde
1da065da8a RUBY-30956 mark global variable/numbered parameter usages with read/write access
GitOrigin-RevId: 3124498363d8a1ddcfa44a6f50019ee0291975fd
2023-04-13 05:22:19 +00:00
Andrey Sokolov
46c8494a43 IDEA-316750 Similar usages Most common usages preview is not properly updated if a usage deleted and it's visible in clusters preview
GitOrigin-RevId: 37986464929767cf9ead168ea55b7a7d0d3a1c4c
2023-04-03 12:38:46 +00:00
Andrey Sokolov
6903d3d42e similar.usages statistics logger changes in lazy loading scroll pane logging
`more.clusters.loaded` and `more.non.clustered.usage.loaded` replaced with one event `more.snippets.loaded.in.clusters.preview`

GitOrigin-RevId: 6f8fa4740a5c3210abc61754a220c5474761bd59
2023-03-28 20:12:17 +00:00
Andrey Sokolov
84b77aec42 IDEA-309484 Find Usages: Update the preview caption while its scrolling
MostCommonUsagePatternsComponent rewritten with coroutines. Enabled update for scrolled list

GitOrigin-RevId: 53842fe2e63c33a92d84f8623bafe3991cffeeb5
2023-03-28 20:12:12 +00:00
Tagir Valeev
af0ab28793 Remove warnings (mostly redundant casts after UIUtil.invokeAndWaitIfNeeded overload removal)
GitOrigin-RevId: bbfe7db3e48548bf60dcd625cb83170030aedd7b
2023-03-23 15:30:27 +00:00
Andrey Sokolov
a0cf27aaf5 Usage view statistics: fixes in finished and cancelled events.
* removed `search_cancelled` event replaced it with a field in `finished` event.
 * added number of results in `popup.closed` event. Number of results is recorded from visible usages in popup

GitOrigin-RevId: 521f0d239ab81c4cfc0d71ee585ddf533d37ae21
2023-03-13 20:10:16 +00:00
Andrey Sokolov
b68b222fcb IDEA-311564 Added ShowUsagesActionHandler.buildFinishEventData(). It provides data for statistics in the end of popup shown.
Usage view statistics collector: Added itemChosenInPopupFeatures event
Added SELECTED_ELEMENT_DATA field and TARGET_ELEMENT_DATA field to log information about related Psi elements.
Supported features:
Is it the same file as the primary target
Is the file opened already
Is file from test sources
Language of the selected file
Is element in injected context
Is element is from recent files


Merge-request: IJ-MR-102522

GitOrigin-RevId: b488edc99979be576e3e0c904f82e3d3e15c15a4
2023-02-23 23:18:18 +00:00
Bas Leijdekkers
3c143edaa0 [search] don't cover search result with replacement preview (IDEA-219751)
GitOrigin-RevId: 62ff148daeadad56c2c2c074b8de8b8714639922
2023-02-22 14:36:06 +00:00
Nikolay Chashnikov
4e6b7d95c1 cleanup: get rid of usage of the deprecated Comparing::compare methods
Methods from JDK are used instead.

GitOrigin-RevId: bc8421f1154fab3a6cc474e59cdc2b7131b1f58f
2023-02-13 17:15:55 +00:00
Teodora Stojcheska
649b056472 Similar usages: Feature extractor for complex structures
(cherry picked from commit ead19b7770a08cbb958e05de833b707aefce4fdd)

IJ-CR-100228

GitOrigin-RevId: 56a7fcb0c5f86faa41b5c5ec38bd0263cf888fc1
2023-02-07 19:00:58 +00:00
Tagir Valeev
f456ed0604 Pattern variable can be used mass cleanup
GitOrigin-RevId: 55839bf0deca5f81d0f7eb5b1c190145a5ea0037
2023-02-07 13:58:20 +00:00
Nikolay Chashnikov
c2540cd10a API: mark for removal APIs which were deprecated and have no external and internal usages (IDEA-305637)
GitOrigin-RevId: 8f4ee08f99f30456e0c0105ae4f28dc7cd8ad9b0
2023-02-06 19:59:10 +00:00
Vladimir Krivosheev
a21963b9eb IJPL-90 rename ProjectPostStartupActivity to ProjectActivity
GitOrigin-RevId: f5df57152ced671ae3127a1bfb8c38146be2b965
2023-02-06 19:52:27 +00:00
Andrey Sokolov
527b33197a Usage View statistic collector: added number of targets to search.started and popup.closed events
GitOrigin-RevId: 1ecb433d1894b05cc1d8335af6c098673def0383
2023-01-26 19:17:37 +00:00
Andrey Sokolov
27fba5b6c8 Usage view statistics collector: added a primary_target element class field to the started event.
GitOrigin-RevId: c5d0ed78f0c82352f035b8818622352ea29bf4a7
2023-01-20 18:42:02 +00:00
Lev Serebryakov
5b800b5fe4 IJPL-53: Return global @DirtyUI for JBViewport, as now it is almost impossible to pop proper locking higher in stack.
GitOrigin-RevId: f2eeceb64bd8b2ca03ca2fc4ee25f9d2805bb70d
2023-01-19 16:11:34 +00:00
Alexey Kudravtsev
d7eb7d0b7c fix i18n warning
GitOrigin-RevId: 65c91d00fc12aa1d47868aa1a2c1f596622730c7
2023-01-19 14:57:21 +00:00
Nikolay Chashnikov
5e0680f483 [usageView] access WorkspaceFileIndex under read action (EA-747167)
This code accesses WorkspaceFileIndex (via FindInProjectUtil$StringUsageTarget.getSlowData) so it must be called under read action.

GitOrigin-RevId: 379b5af2b1d4baf368c1999701612d5edbda5d86
2023-01-18 14:57:53 +00:00
Andrey Sokolov
acf3bcdbfe IDEA-309785 Similar usages: Highlighting in cluster preview for overriding/implementing methods is too broad
Highlight only name element for elements with name like in UsagePreviewPanel

GitOrigin-RevId: db9e3480c8cb19e05b5a31a8c212872d34353610
2023-01-04 13:18:33 +00:00
Bas Leijdekkers
aca2df6d7e [search] allow replacing with Preserve Case with Regex search (IDEA-253964)
GitOrigin-RevId: b387ea84c97b0b911aa7b65e4394cc6aedfc9c25
2022-12-31 01:16:33 +00:00
Bas Leijdekkers
02828fb96a [search] don't pop up Find tool window after clicking Replace All button (IDEA-252372)
GitOrigin-RevId: 52b96357191123652d1f18e135f797ac78ca1f46
2022-12-23 13:26:31 +00:00
Bas Leijdekkers
ecb9a09d17 [search] fix replacement preview when case-sensitive search is enabled (IDEA-298872)
GitOrigin-RevId: af7c669c2014edea3e3667564c1e7936af004b08
2022-12-20 13:21:42 +00:00
Bas Leijdekkers
6b7cb29f9b [search] use fixed width font and layout in replace preview to avoid hiding whitespace changes (IDEA-211965)
GitOrigin-RevId: 233d6ce038a936a42afb6b198e398219811ca61d
2022-12-20 13:21:39 +00:00