Commit Graph

931 Commits

Author SHA1 Message Date
Yann Cébron
0a3e1b8bdf [xml-dom] GenericDomValueReference>: replace usage of obsolete LookupValueFactory
GitOrigin-RevId: 478faa9e227dc8ddd2d961c0b572a549f5c6de57
2024-07-16 19:26:30 +00:00
Tagir Valeev
642c60efcf ClassExplicitlyAnnotation suppressed
GitOrigin-RevId: b69dd9a989c758cb59327c506d3ad7fcafb9183d
2024-07-09 16:13:26 +00:00
Tagir Valeev
705efbdc7a [dom] Warnings fixed
GitOrigin-RevId: 8faeceb53eec596234d7269cf3976ec9b26732fc
2024-07-09 16:13:26 +00:00
Tagir Valeev
6bb83bc8e5 [stubs] Reduce amount of raw types
GitOrigin-RevId: 169895a6ee3c98db193443dbb0ced98497221430
2024-07-04 21:05:23 +00:00
Yann Cébron
3782dc0da3 [devkit] IJPL-115197 Provide distinct icon for V2 plugin.xml
GitOrigin-RevId: 400aaa59a3f796dc275171c10b48271bf6438d7e
2024-06-25 10:35:21 +00:00
Tagir Valeev
3fd0f4975d Pattern variable can be used fixes; other warning fixes
GitOrigin-RevId: 4965216d1872b439970db33dbe2864d5aab9606e
2024-06-18 19:55:23 +00:00
Roman Shevchenko
ac742921c5 Cleanup (typos; formatting)
GitOrigin-RevId: 9733aeebbae11f645b17261f25692b92557ccd3a
2024-05-12 20:30:07 +00:00
Alexey Kudravtsev
3102effabf make highlight visitors run concurrently; fix tests, get rid of HighlightInfoProcessors to fix IJPL-149030 HighlightVisitors should run in parallel
GitOrigin-RevId: 8a77dd409a575d3eaf28d6935ffeb87fce35dbd4
2024-05-01 11:53:23 +00:00
Yuriy Artamonov
2a5d5ed155 [xml] IJPL-148944 IconProviders must not load PSI from Project view
GitOrigin-RevId: 39d7a5d7fe6d99631efd41effb92e95e730f25c5
2024-04-30 20:57:30 +00:00
Nikolay Chashnikov
b966d0247f [xml dom] cleanup: mark 'ConvertContext' parameters in Converter interface and its implementations as @NotNull
Actually, 'null' value is never passed, but explicit annotation simplifies writing code in its implementations, especially in Kotlin code.

GitOrigin-RevId: 8059717d7259eb50a3ef68f2334b5f08c7e81b06
2024-04-24 11:44:31 +00:00
Vladimir Krivosheev
81d76b2102 cleanup
GitOrigin-RevId: 53f17d6aa9ac0e61b01ac7303d70ecbeb1c799fc
2024-04-10 18:11:50 +00:00
Vladimir Krivosheev
f8b4ecb14f reduce dependency on CGLIB
GitOrigin-RevId: 5c59ba6aac4113d14c50260c4a58bc7d45249338
2024-04-10 18:11:45 +00:00
Alexey Kudravtsev
7a16a7a4c0 prevent AnnotationHolderImpl from extension, make AnnotationSessionImpl.computeWithSession() the only available mechanism to obtain anno holder
GitOrigin-RevId: 5565124fe4655c87730d3978b92672ed0eea4f90
2024-03-20 13:37:21 +00:00
Konstantin Nisht
2377c434e2 [platform] IDEA-343397: An experiment: attach children only to a registered disposable parent
This is an attempt to fix IDEA-343397. In the constructor of DomManagerImpl, the children get attached to a disposable before it gets registered as a child of project container. I conjecture that an exception in the constructor leads to DomManagerImpl attached to the ROOT tree instead of the project, which leads to incorrect dispose in tests. If the conjecture is true (i.e. there are no failing tests after this change), then we should deal with this problem on a platform level

GitOrigin-RevId: 26c3ae7a2d0627344c544e724239d8fdd8799024
2024-03-04 11:04:07 +00:00
Dmitry Avdeev
4dd6717c43 NavigationGutterIconBuilder & NavigationGutterIconRenderer moved to lang.impl
GitOrigin-RevId: 9e2d26bf7ad940ce8dc605c144bfd53d864e02eb
2023-12-08 18:18:17 +00:00
Elena Shaverdova
b7f28c8af6 EA-942572 Read access needed
GitOrigin-RevId: 0b8d03000ecd6610d62051c0ca224f46be4206e0
2023-12-05 18:56:54 +00:00
Tagir Valeev
51854f80b3 "Method can be static" fix massive application
GitOrigin-RevId: ed296b85922a6814d5c6057b5cbc720f0c546e41
2023-10-20 19:12:56 +00:00
Yuriy Artamonov
3838414086 [spring] IDEA-333622 Spring: spring.xml the expensive method should not be called inside the highlighting pass
GitOrigin-RevId: 2bdbf9a843e48440b1d2dfb9684c0b42215fa4a6
2023-10-07 22:10:04 +00:00
Alexander Lobas
1035b29274 IDEA-287157 Editor and gutter balloons: update layout, insets, colors
GitOrigin-RevId: 7753503766bee41b540f9e6e3ed7e39d4caf46b5
2023-10-06 21:19:12 +00:00
sergey.vasiliev
08228526be IDEA-321777 Spring GraphQL: Generate request in HTTP Client for @QueryMapping
GitOrigin-RevId: 0fa89fb3b842a6993ad0dd36950ce58390fa667f
2023-10-06 13:10:45 +00:00
Dmitry Avdeev
12b59a527c diagnostics for using PsiElementListCellRenderer
GitOrigin-RevId: 2a8882ae8c65fae620f506750446081d88d96879
2023-10-04 18:32:25 +00:00
Vladimir Krivosheev
25e62f3ddc cleanup - sort modifiers
GitOrigin-RevId: 235b9ad771d099b953500b1d95e51919ce2fdf0a
2023-09-20 08:49:24 +00:00
Alexey Kudravtsev
5d19cf1058 encapsulate AnnotationSessionImpl creation to make it possible to add more info there
GitOrigin-RevId: 02b20264bcc3d4a96ca560440730235ea98c772d
2023-07-20 12:11:34 +00:00
Alexey Kudravtsev
e1f84b5ba0 encapsulate internals of AnnotationSession to be able to change the impl
GitOrigin-RevId: 5f5cf9d508a33748b6c60748a5a23575a333bfe2
2023-07-19 20:08:33 +00:00
sergey.vasiliev
12c91e620f Performance issues in PathManager#createReferences() [Part 1]:
It collects references from all (24+) PathReferenceProvider instances and  invokes resolve() for every found reference(see mergeReferences() method).  see  https://youtrack.jetbrains.com/issues?q=tag:%20slow-op-highlighting

GitOrigin-RevId: 5cf5b1aef203f8ca8dd6fc5366382359db0e5859
2023-07-19 17:07:40 +00:00
Tagir Valeev
eceaae8757 Enhanced switch used; other minor warnings fixed
GitOrigin-RevId: 36dd4522e953681b2fc3463968d172d2bf6453bf
2023-06-13 13:42:37 +00:00
Alexey Kudravtsev
68bbb35628 cleanup
GitOrigin-RevId: 8d08694a575db2ddac4839630e7874fccfbdbee3
2023-05-10 11:52:06 +00:00
Alexey Kudravtsev
970ae99e6d use ContainerUtil.createMaybeSingularList() to simplify code
GitOrigin-RevId: 3474c183588944fa16fef901302492bf714aa815
2023-05-04 14:09:30 +00:00
Nicolay Mitropolsky
7d80254662 [xml] suppressing expensive operation in the contributing references assert for GenericValueReferenceProvider
because I've failed to refactor it

GitOrigin-RevId: 206f1415c895f68d95eb4e6f377622ebdf4ec8fe
2023-05-02 15:46:08 +00:00
Nicolay Mitropolsky
3e8a531210 DefaultDomAnnotator registers problems in AnnotationHolder again
to repair `MavenModelValidationTest#testAddingStructureReadingProblemsToParentTag`

GitOrigin-RevId: 628a3b650325259364992c39461fa84652fb74f3
2023-04-27 22:52:29 +00:00
Daniil Ovchinnikov
df1f55a499 IJPL-7 make methods of Navigatable default
They should not be required to be implemented, only `Navigatable.navigationRequest` is.

GitOrigin-RevId: b038cb465de3b9f1d6c37f8578ecd69f8667a10b
2023-04-20 10:56:47 +00:00
Nicolay Mitropolsky
db84cf0e4f [analysis, xml] LazyMultipleReferencesWrapper makes it possible to postpone reference contribution (IDEA-304281)
It is a workaround for expensive references contributors like `CustomServletReferenceProvider`.

GitOrigin-RevId: 942827a1701b23958748e92c3da82058ca27afe1
2023-04-18 17:35:32 +00:00
Daniil Ovchinnikov
6fe5c49599 deprecate com.intellij.reference.SoftReference constructors
GitOrigin-RevId: a723be59b812f71953e79879d7adf09d58a9e935
2023-04-15 00:04:29 +00:00
Dmitry Avdeev
a2791c3b87 EA-827994 - T: PopupFactoryImpl.createPopupChooserBuilder
MultipleFilesHyperlinkInfo migrated to use PsiTargetNavigator

GitOrigin-RevId: 6bafc863b0428f1029d7d8821a91490c6451e975
2023-04-12 17:54:21 +00:00
Dmitry Avdeev
919f230d1d NavigationGutterIconBuilder enabled to use PsiElementListNavigator
GitOrigin-RevId: 7ffcde725808dc5b97cf90bdc917d2ad282e64dd
2023-04-04 18:36:39 +00:00
Alexey Kudravtsev
05ec325dbc IDEA-313723 DomElementsAnnotator no longer getting invoked in 2023.1 EAP
GitOrigin-RevId: e584da94a27bed6f4feda73bacb34c2acac61871
2023-02-22 14:11:55 +00:00
Alexey Kudravtsev
fc61259925 notnull
GitOrigin-RevId: d8b536dea17f2a2c435a04822ad95b220b8397b1
2023-02-22 01:13:04 +00:00
Alexey Kudravtsev
ed37f8774f notnull
GitOrigin-RevId: 81bbee379e75c24617941bf1609d47e5a4d6c412
2023-02-22 01:13:02 +00:00
Alexey Kudravtsev
91cd121707 assert no null LocalQuickFixes are passed to CommonProblemDescriptorImpl inside the "quickFixes" array (IDEA-312632), fix usages
null arrays still can be passed, but arrays with null elements are rejected because:
- consistency: it was very complicated (for both clients and implementation code) to understand if this particular fix could be null or not, and
- performance: filtering out null elements from the array and reallocating them back were noticeably expensive.
Currently, this assertion works inside tests only, to avoid irrecoverable failures in third-party plugins

GitOrigin-RevId: b71bc59eb811a807a0e6aae9609c368806f54869
2023-02-13 18:09:58 +00:00
Nikolay Chashnikov
60a03c51d8 cleanup: use error(String) instead of error(Object)
This is needed to provide a meaningful message for an error. Also, error(Object) method will be deprecated.

GitOrigin-RevId: a1398e286a2fba343b86fe79b456c1054dbb126c
2023-02-08 12:04:07 +00:00
Tagir Valeev
f456ed0604 Pattern variable can be used mass cleanup
GitOrigin-RevId: 55839bf0deca5f81d0f7eb5b1c190145a5ea0037
2023-02-07 13:58:20 +00:00
Alexey Kudravtsev
a8b8cf75db remove deprecated
GitOrigin-RevId: d5510a6fbde485b14d4c45a5f7a6082bb499ccfd
2023-01-23 13:50:54 +00:00
Vladimir Krivosheev
57764d700b mark classes final
GitOrigin-RevId: 6414b6f2119c82c7567987dd30b35cab5491d9e2
2022-12-30 06:58:01 +00:00
Vladimir Krivosheev
a4ae56b1ce deprecate ReflectionUtil.getDeclaredField and getDeclaredMethod in favour of modern Java API (MethodHandles)
Using MethodHandles is not a valid approach to use closed JDK API — should be used via JBR API (see JBRApi)

GitOrigin-RevId: 3f72e2ab29c79199365c0e693cf0ab3161dcb9d8
2022-12-23 08:08:10 +00:00
Alexey Kudravtsev
a6dc5c27a2 cleanup
GitOrigin-RevId: 2b0996b7907aa3de8225fc5bf397e62e74e7404e
2022-12-05 17:21:05 +00:00
Alexey Kudravtsev
9646a3d9e9 simplify strange code with unnecessary collections
GitOrigin-RevId: 9ce6dc69bf593fbb58028264507688eb27f3a099
2022-12-05 14:51:08 +00:00
Alexey Kudravtsev
451efda2d9 cleanup, notnull
GitOrigin-RevId: f3ce3d18a9a47eaeec36eb4064fe2724032ff905
2022-12-05 14:51:02 +00:00
Dmitry Avdeev
229675356f EA-251158 - PE: PluginManagerCore.createPluginException
no need for DomFileElement in stub builder

GitOrigin-RevId: db60a18bc3f0aee5e056aabac74dbb8e839fadc7
2022-12-02 22:52:32 +00:00
sergey.vasiliev
3f3a444be3 incorrect DomStub equals() method
GitOrigin-RevId: cafe5fa03a0a84e272b9622cc1b3873c4028aa64
2022-11-28 16:07:03 +00:00
Alexey Kudravtsev
c6940d4a2c remove usages of deprecated Annotation mutating methods
GitOrigin-RevId: df83b2a3abb9737fa9e5f357b5f475e00d9c15aa
2022-11-23 13:38:58 +00:00