Commit Graph
77 Commits
Author SHA1 Message Date
Anna Kozlova b044c4fcee extract method: do not pass redundant parameters if extracting from lambda body (IDEA-139292) 2015-04-16 20:30:35 +02:00
Anna Kozlova be5e054e6a extract method params suggester: cleanup initial params if they are not used anymore 2015-03-18 17:46:02 +01:00
Anna Kozlova 5435a357c6 extract method: check duplicates/used vars also in unreachable code
(cherry picked from commit 42249fe8f0cead1a0023aa9edfb23fc52a95c268)
2015-03-11 20:33:25 +01:00
Anna Kozlova 3251ee29da extract method with last declaration statement fixed (EA-64510 - IOE: PsiJavaCodeReferenceElementImpl.cannotBindError) 2015-02-25 20:34:37 +01:00
Anna Kozlova 6482dfe733 do not return lambda parameter type as denotable in RefactoringUtil (IDEA-136617) 2015-02-17 14:58:56 +01:00
Anna Kozlova fb9a5e8ff7 extract method parameters suggester: change method copy context so calls inside method body could be resolved (aClass..getTypeParameterList() passed inside MethodElement.copyElement && aClass.processDeclarations implementations together cause that method calls to same class members can't be resolved); teach DuplicatesFinder to work on non-physical elements with correct context 2015-01-12 21:13:33 +01:00
Anna Kozlova 5ecb541855 extract method: skip parenthesis as they are skipped by control flow (IDEA-134904) 2015-01-02 12:05:47 +01:00
Anna Kozlova afc3e23260 extract method: disable make static when extracting from default method; ensure static extracting from constant in interface (IDEA-134636) 2014-12-23 11:42:42 +01:00
Anna Kozlova fc4434d241 extract method: use target class context to check nullability 2014-12-09 17:06:19 +01:00
Anna Kozlova 5a5ed0fe42 extract method: allow to fold parameters if calls to fields are involved 2014-12-08 16:19:28 +01:00
Anna Kozlova f7316391ce extract method: exclude return statements without value from occurrence analyzing; do not suggest artificial return type if return statements break control flow 2014-12-05 19:21:40 +01:00
Anna Kozlova 72529af659 extract method: suggest Object as return value if extract from incomplete expression (IDEA-69722) 2014-12-05 17:35:39 +01:00
Anna Kozlova ea292f0319 extract method: new signature detector: add unused parameters to method calls as refs to initial vars 2014-12-05 17:35:36 +01:00
Anna Kozlova 5e2fa7be19 extract method: new signature detector (IDEA-66281); initial 2014-12-05 13:48:57 +01:00
Anna Kozlova 37841f9d73 extract method: resolve conflicts during params rename (IDEABKL-3749) 2014-12-05 13:48:55 +01:00
Anna Kozlova e2e8384516 extract method: suggest non-void return type if final field is assigned inside (IDEA-93737) 2014-12-04 13:43:01 +01:00
Anna Kozlova e13047d703 extract method: suggest return type by unique variable defined in extracted code (IDEA-108296) 2014-12-04 10:57:19 +01:00
Anna Kozlova c460d82d7c extract method: allow to extract from fragment with different exit points which all are @NotNull 2014-12-03 17:26:32 +01:00
Anna Kozlova 460771192f extract method: make static and pass fields as parameters if possible (IDEA-112230) 2014-12-03 14:27:46 +01:00
Anna Kozlova c6110f2cfa extract method: allow to choose return type from hierarchy (IDEA-79995) 2014-12-02 19:34:40 +01:00
Anna Kozlova d168336f86 testdata for (IDEA-108664) 2014-12-02 16:43:57 +01:00
Anna Kozlova f50575a468 extract method: suggested names for folded params should be unique (IDEA-120974) 2014-12-01 20:54:14 +01:00
Anna Kozlova 4ea62b333e extract method: copy parameters annotations to the extracted method when applicable (IDEA-40617) 2014-12-01 20:54:13 +01:00
Anna Kozlova 9fc8b39236 extract method: prepare method body to have @Nullable/@NotNull before actual extract is performed 2014-12-01 18:00:34 +01:00
Anna Kozlova f0a876431a show setting with generate annotations right on extract method dialog 2014-11-28 15:22:31 +01:00
Anna Kozlova 274f7acfdc extract method: fix name conflicts at method call site 2014-11-27 20:22:19 +01:00
Anna Kozlova c28dee1968 extract method: annotate newly created method @Nullable when applicable (IDEA-76767) 2014-11-27 19:14:03 +01:00
Anna Kozlova 83d3df6a95 extract method: allow to extract @NotNull code with missed branches which would be replaced with 'return null' with check on call site (IDEA-120076) 2014-11-27 18:12:53 +01:00
Anna Kozlova 9d9caf9620 return statements inside lambda: extract method return type fixed (IDEA-133095) 2014-11-18 19:37:57 +01:00
Anna Kozlova 350c0b2a0a extract method nullable check: ensure correct exist statement chosen (IDEA-132706) 2014-11-13 12:35:04 +01:00
Anna Kozlova ec9a61b8bd extract method: redundant cast treatments (IDEA-125259) 2014-05-20 14:17:04 +04:00
Anna Kozlova 47262762d2 extract method from lambda body: accept parameters of parent method (IDEA-112570) 2013-08-23 21:08:33 +04:00
Anna Kozlova d6b15746b4 extract method: avoid invalid elements (IDEA-112311) 2013-08-20 21:29:05 +04:00
Anna Kozlova a1096fae35 extract method duplicates: distinguish method overloads (IDEA-97777) 2013-06-17 21:10:25 +04:00
Anna Kozlova 3b736aca09 extract method: reject containing classes when members were called through inheritance chain 2013-05-29 17:48:38 +04:00
anna ceb9354f15 extract method: duplicates processing fixed (IDEA-105562) 2013-04-17 15:58:52 +02:00
anna 946f13a494 extract method: check qualifiers correspondence (IDEA-98515) 2013-01-04 17:47:41 +01:00
Anna Kozlova 7228521cd1 extract method: insert cast when duplicate with changed type processed (IDEA-98396) 2013-01-02 12:45:05 +01:00
anna 3afa9c526d extract method: add default modifier when extracted into interface (java 8 only) 2012-12-17 21:45:39 +01:00
anna 746ed966f9 extract method: do not suggest to replace duplicates if candidates intersects with extracted method 2012-12-17 21:45:38 +01:00
anna 7a870adca7 extract method: adjust params to be final in case of local classes (IDEA-97253) 2012-12-11 17:44:20 +01:00
anna 4347e15507 extract: skip comments when no statement is selected but expression can be retrieved (IDEA-91985) 2012-11-13 21:33:15 +01:00
anna 3786644b52 testdata for IDEA-80695 2012-11-05 15:24:37 +01:00
anna bfef30ff03 extract method: do not fold params by default when they are used inside conditional stmts (IDEA-92815) 2012-10-18 17:30:55 +02:00
Anna Kozlova e8f211bdd9 extract method: detect used lambda params in selection (IDEA-91345) 2012-09-12 00:03:38 +04:00
Anna Kozlova a2cb71edfe detect duplicates: ignore returns from inner classes/lambdas (IDEA-91087) 2012-09-10 21:43:52 +04:00
Anna Kozlova 1703f863b8 lambda: correct control flow for lambda body; additional test for IDEA-91076 2012-09-06 14:59:45 +04:00
Anna Kozlova 6349bb8af8 extract method: collect used type params from method on the same level as a new method 2012-08-15 22:08:48 +04:00
anna 961086a6d1 do not skip control flow for unreachable code (IDEA-87654) 2012-07-05 11:02:17 +02:00
Anna Kozlova b950ee8562 extract method: no need to declare variables after call when expression was extracted 2012-05-31 21:30:10 +04:00