Commit Graph

5353 Commits

Author SHA1 Message Date
Dmitry Avdeev
3d443e22b3 IDEA-372324 Unable to open debugger port (*:63992): java.net.ConnectException "Connection refused: connect"
add support for RemoteConnectionCreator but not JavaCommandLine

Reviewed-by:  IJ-CR-162655
(cherry picked from commit a05f60aec330697f6ca370ef9370ea96d4dfc16b)

GitOrigin-RevId: 821d61d33267f5176594f381198f58100a332cdd
2025-05-27 18:54:52 +00:00
Dmitry Avdeev
45ac2cec20 IDEA-372324 Unable to open debugger port (*:63992): java.net.ConnectException "Connection refused: connect"
implementing RemoteConnectionCreator to patch RemoteConnection with "*" host

Reviewed-by:  IJ-CR-162655
(cherry picked from commit a05f60aec330697f6ca370ef9370ea96d4dfc16b)

GitOrigin-RevId: 252ea9b2cf48acb618b6c479926f712dcb6c1246
2025-05-26 14:38:22 +00:00
Dmitry Avdeev
3563ba3250 IDEA-372324 Unable to open debugger port (*:63992): java.net.ConnectException "Connection refused: connect"
the dedicated debugger runner leads to problems with configuration, so connection patching is moved to PatchedRunnableState

Reviewed-by:  IJ-CR-162655
(cherry picked from commit 588d4601ef5f6c3c4f652ae7c8cdd213f4700fe5)

GitOrigin-RevId: a0ee710f5428f2c81b4d71034e3da3e760f3bfd8
2025-05-26 14:38:22 +00:00
Egor Ushakov
d03cc01e1b IDEA-370227 Error with quick evaluation in lambda expressions
(cherry picked from commit 0957f810d4a41d7aa787e68c6d65a5ccb63656ac)

IJ-CR-159332

GitOrigin-RevId: a40a87e2baa3d629b7417da6821275246a64349e
2025-04-22 12:57:54 +00:00
Egor Ushakov
a8606aaea5 IDEA-368308 Debug: View As | Hex/Binary/Primitive on variable does not close popup - fixes after review
(cherry picked from commit cab01e4205b42872fa44d32e588f2944004cfd4e)

IJ-CR-157474

GitOrigin-RevId: b8135e9e858239cf480c3561d0d5c54027c388ff
2025-03-25 23:00:08 +00:00
Egor Ushakov
24e74e0f26 IDEA-368308 Debug: View As | Hex/Binary/Primitive on variable does not close popup - fixes after review
(cherry picked from commit 738d44bc9d189bc4829d682977025b902d6a23a8)

IJ-CR-157474

GitOrigin-RevId: f077db0d175b4bf59b67b7c8ee1f0e154d38b999
2025-03-25 23:00:08 +00:00
Egor Ushakov
5e2d3ca4b9 IDEA-368308 Debug: View As | Hex/Binary/Primitive on variable does not close popup
(cherry picked from commit b1e1cdbb0977b25a411d5f2e5e8d089493396631)

IJ-CR-157474

GitOrigin-RevId: b28d7c956a6a1f7878b2215dbacf035f9904eb90
2025-03-25 23:00:08 +00:00
Maksim Zuev
8f0d420874 [debugger dfa] IDEA-368513 Fix undesired task cancellation
(cherry picked from commit e2b540279a212e9e669444a599579feb3d870ff9)

IJ-CR-156762

GitOrigin-RevId: 341d5e2a7c7733c04efa08765e933b4a36deb795
2025-03-05 20:21:04 +00:00
Alexander Kuznetsov
43f55db60a [debugger] IJPL-165184 Bring back CollectionVisualizerEvaluator to preserve API compatibility
(cherry picked from commit b7b0a900a78a57dff998886f51fa15d10197d98c)

KT-CR-20403

GitOrigin-RevId: 6bca4ff9f3baa208c6cf5bc97c5bf87d3ed123e9
2025-03-03 13:10:39 +00:00
Maksim Zuev
614ff8459b [debugger] IDEA-368003 Fix inlay hint for declarations
(cherry picked from commit 42547dab835ad0a61cde7d08669e9634eaac9640)

IJ-CR-155763

GitOrigin-RevId: 038e04a06cb333c05faad6cdb5dccdb1fa21f5d1
2025-02-25 21:27:31 +00:00
Maria Sokolova
a8f9784663 [debugger] Introduce a new method isEvaluationPossibleInCurrentCommand.
In this commit 2de5dc57 the logic of isEvaluationPossible method was changed, though it's sometimes necessary to only check whether evaluation will be possible on this context.

GitOrigin-RevId: 18fbfda949fde8d7ae0a43c38342077242d3bd1d
2025-02-20 00:45:39 +00:00
Egor Ushakov
1c2eb69f4e [debugger] do not generate a new LinkedList node for each debugger command
GitOrigin-RevId: 3cc0a251f436f0fc74edd550075c0f2509c4414c
2025-02-19 21:28:30 +00:00
Vladimir Parfinenko
c3c12f5518 [debugger] ThreadDump: don't dump virtual threads if there are no virtual threads, IDEA-367848
GitOrigin-RevId: 8b8e08435022074e7b5d09a0481735bd4267dde4
2025-02-19 16:41:18 +00:00
Vladimir Krivosheev
eff3c47a35 fix JspValidationTarget visibility
GitOrigin-RevId: 16e7b7f1ae5a84b33931f704242c13e2c6e45acc
2025-02-19 08:33:02 +00:00
Egor Ushakov
3769c0c460 [debugger] further stabilize flaky PacketsNumberTest
GitOrigin-RevId: 8cf2905f60736307c655fd5bc91d8ae53b06de36
2025-02-19 03:23:14 +00:00
Egor Ushakov
8cf4185d42 [debugger] no need to scan subclasses for private or static methods in method breakpoints
GitOrigin-RevId: 1b5f82d5571fec415bc9b9077e608327d62f83ed
2025-02-19 03:23:14 +00:00
Maria Sokolova
bd2fee02ba [debugger] Fix: declare JavaThreadsProvider in java-debugger.xml not in the Kotlin plugin.
GitOrigin-RevId: c241baa3848bbb7138aa9b982b1e11767174898f
2025-02-18 12:48:57 +00:00
Evgeny.Terekhin
907b82a9a4 Mixed mode. Getting rid of the second XDebugProcess in XDebugSessionImpl by introducing XMixedModeCombinedDebugProcess
+ removing getEditorsProvider and getProcessHandler methods from XDebugSessionImpl
 + using  .dotnetDebugProcess extensions in rider modules
 + XMixedModeDebugProcess -> XMixedModeDebugProcessExtension

GitOrigin-RevId: 9959d91687d26a7288dbdd6cfa250751ab2a43fc
2025-02-18 09:33:43 +00:00
Evgeny.Terekhin
656f72e067 Mixed mode. Introduced XMixedModeDebuggersEditorProvider to fix completion in evaluators
GitOrigin-RevId: 53594bf9f66fe8e775f5c8baef6276c7b674d77b
2025-02-18 09:33:42 +00:00
Vladimir Parfinenko
a54281d020 [debugger] Minor polishing ThreadDumpAction.kt
GitOrigin-RevId: 3b1b40d9ec758e912126a7ece1130439af64b54b
2025-02-17 22:04:37 +00:00
Vladimir Parfinenko
174f0c7ca3 [debugger] API: allow thread dump providers to run without evaluation if there is no need for it
GitOrigin-RevId: 673eef6a427943b687a5c5d979614ee7691a02e0
2025-02-17 22:04:37 +00:00
Maria Sokolova
53e920e5e7 [debugger] Introduced provider of Java virtual and platform threads.
Flag: `debugger.thread.dump.include.virtual.threads`

IDEA-355724

GitOrigin-RevId: 5c260df1d4cd2003b17ff8dd7692eec823faa3fb
2025-02-17 22:04:36 +00:00
Maria Sokolova
5b5bd49445 [debugger] Translated ThreadDumpAction.java into Kotlin for easier oncoming usage of Kotlin async API.
GitOrigin-RevId: d1f211b25c1dda9ffe8e286f9b42806f24ce10cc
2025-02-17 22:04:36 +00:00
Maria Sokolova
573408da21 [debugger] Introduced provider of coroutine DumpItems to be shown in ThreadDumpPanel.
Flag: `debugger.kotlin.show.coroutines.in.threadDumpPanel`

IDEA-355724

GitOrigin-RevId: 5f8d6286a70f151bab6c5d510b5992ae671b2170
2025-02-17 22:04:36 +00:00
Maria Sokolova
c6450cd8cf [debugger] Introduced experimental API to find suspendContext for evaluation.
Related tickets:
IDEA-355724

GitOrigin-RevId: d26021007390ddbd81190ee2a130bfb7a0312235
2025-02-17 22:04:36 +00:00
Egor Ushakov
acb1fa7c40 IDEA-367120 Method breakpoints may be very slow to set - yield instead of delay is enough for other commands processing
GitOrigin-RevId: 5b883a2f9666f0e557f656ebe342f66163479c46
2025-02-17 18:34:27 +00:00
Vladimir Krivosheev
2db9ad8ef6 update bazel files
GitOrigin-RevId: 5bf54290c411048009614bacceeb742a53d5c0a4
2025-02-17 08:47:14 +00:00
Vladimir Krivosheev
c00404ad15 fix JdiTimer visibility
GitOrigin-RevId: cb7d57f51305f7d6cf8e573fe8973d1612f31705
2025-02-16 12:12:46 +00:00
Nikolay Rykunov
029ca69f2a [java] Add an empty file to keep the backend module structure
GitOrigin-RevId: 5a5f520c73e488e5ec16e2961f5064052dea90d3
2025-02-16 10:19:08 +00:00
Nikolay Rykunov
459df0f080 [debugger-rd] IJPL-176967: Introduce frontend's ViewText action in Java plugin
GitOrigin-RevId: 2efbceaa923f8272d4f35d1d555c89b53e11c4da
2025-02-16 10:19:08 +00:00
Nikolay Rykunov
f60371b6b6 [java-rd] IJPL-176967: Introduce debugger frontend and backend modules
GitOrigin-RevId: e97dab66026361b6819be7d77ae462c36962b0e9
2025-02-16 10:19:08 +00:00
Egor Ushakov
6f595ce9fb [debugger] fixed ObjectCollectedException
GitOrigin-RevId: f072f6f33fe67abfd2ea2b55b119f77aea6afdae
2025-02-15 16:01:03 +00:00
Maksim Zuev
e56b11a066 [kotlin debugger] Unify kotlin function breakpoint and java method breakpoints
GitOrigin-RevId: a4651be6725eecf18409e0b7bc41e23dca5b114f
2025-02-14 19:18:26 +00:00
Maksim Zuev
d40069a7cb [debugger] Check isInSuspendCommand in isEvaluationPossible
GitOrigin-RevId: 2de5dc5741d80242fd70e68fec672782b7f53fcc
2025-02-14 19:18:26 +00:00
Egor Ushakov
431ced79bc [debugger] store vm related user data in virtual machine proxy, not in debug process
GitOrigin-RevId: d4ea94a732775782f75ea0cda6f5105328699b0e
2025-02-14 18:21:15 +00:00
Leonid Shalupov
244718d26b housekeeping: remove java unused imports
IJ-MR-154242

GitOrigin-RevId: 8fec0cba7ae2368e51b21a8b9bfb2f445fdc0f68
2025-02-14 18:08:16 +00:00
Max Medvedev
9d5b8466f5 IJPL-339 support code insight contexts in search scopes
GitOrigin-RevId: 7d9ed140b5b18dbd9554eb4561c5b283d5e937c8
2025-02-13 19:25:07 +00:00
Maksim Zuev
6da62a6937 [debugger] IDEA-366895 Debugger: collect performance statistics on the command execution time
GitOrigin-RevId: 1de07f7dba0a674838012e1ba228c3356febf93e
2025-02-13 17:29:15 +00:00
Maksim Zuev
981a280d03 [debugger] IJ-MR-154880 Review fixes
GitOrigin-RevId: aeceed19a04a9dd491fd5d0e76dcf685aec105ed
2025-02-13 14:17:45 +00:00
Egor Ushakov
2fc055dcc8 [debugger] fixed flaky multithreaded tests
GitOrigin-RevId: c12288e2f01a7c8753bfb6f4b388a3a80328ba5f
2025-02-12 18:33:43 +00:00
Maksim Zuev
f4fefe5b2e [debug] Fix rt.jar loading: prefer classes from rt.jar module when defining classes
GitOrigin-RevId: 786125f9ccf650acf4d9d3a3ee8edaac0a735d77
2025-02-12 15:05:59 +00:00
Maksim Zuev
bcbda8e3e2 [debug] IDEA-367296 Cache class loaders for helper classes
GitOrigin-RevId: b1852e507423d25b847c21b88414620d295566b5
2025-02-12 15:05:59 +00:00
Egor Ushakov
4f36358513 [debugger] code cleanup
GitOrigin-RevId: c796ebec075b4ee46506f1524bcced9d8639ef85
2025-02-12 12:58:05 +00:00
Maria Sokolova
c8c9b54efb [coroutines-debugger] Introduced a new type DumpItem to represent entities shown ThreadDumpPanel.
DumpItem is supposed to represent threads, virtual threads or coroutines.

Related tickets:
IDEA-355724
IDEA-367130

GitOrigin-RevId: 738b6dd7f72e87e0e8d5e5fb453eb6df95846e26
2025-02-11 17:55:10 +00:00
Egor Ushakov
2b0dec4069 IDEA-367120 Method breakpoints may be very slow to set - do not send all commands at once
GitOrigin-RevId: 3614ce5909e8354b23e40ec61bebead39f8521cf
2025-02-11 15:06:42 +00:00
Egor Ushakov
24c4499e46 [debugger] use kotlin ref
GitOrigin-RevId: 067416ec27177ff2f2400b5b7deb912904c32586
2025-02-11 15:06:42 +00:00
Konstantin Nisht
c8978ac169 [threading] IJPL-149317: Use Write-Intent read action in debugger
```
java.lang.IllegalStateException: WriteIntentReadAction can not be called from ReadAction
	at com.intellij.openapi.application.impl.AnyThreadWriteThreadingSupport.runWriteIntentReadAction(AnyThreadWriteThreadingSupport.kt:240)
	at com.intellij.openapi.application.impl.ApplicationImpl.runWriteIntentReadAction(ApplicationImpl.java:934)
	at com.intellij.openapi.application.WriteIntentReadAction.compute(WriteIntentReadAction.java:55)
	at com.intellij.openapi.application.WriteIntentReadAction.run(WriteIntentReadAction.java:23)
	at com.intellij.openapi.wm.impl.FocusManagerImpl.lambda$doWhenFocusSettlesDown$4(FocusManagerImpl.java:178)
	at com.intellij.util.ui.EdtInvocationManager.invokeLaterIfNeeded(EdtInvocationManager.java:32)
	at com.intellij.openapi.wm.impl.FocusManagerImpl.doWhenFocusSettlesDown(FocusManagerImpl.java:173)
	at com.intellij.openapi.wm.impl.FocusManagerImpl.doWhenFocusSettlesDown(FocusManagerImpl.java:165)
	at com.intellij.ui.tabs.impl.JBTabsImpl.removeDeferred(JBTabsImpl.kt:1647)
	at com.intellij.ui.tabs.impl.JBTabsImpl.processRemove(JBTabsImpl.kt:2580)
	at com.intellij.ui.tabs.impl.JBTabsImpl.removeTab(JBTabsImpl.kt:2487)
	at com.intellij.ui.tabs.impl.JBTabsImpl.removeTab$default(JBTabsImpl.kt:2448)
	at com.intellij.ui.tabs.impl.JBTabsImpl.removeTab(JBTabsImpl.kt:2446)
	at com.intellij.execution.ui.layout.impl.GridCellImpl.lambda$remove$2(GridCellImpl.java:119)
	at com.intellij.execution.ui.layout.impl.GridCellImpl.revalidateCell(GridCellImpl.java:139)
	at com.intellij.execution.ui.layout.impl.GridCellImpl.remove(GridCellImpl.java:119)
	at com.intellij.execution.ui.layout.impl.GridCellImpl.minimize(GridCellImpl.java:366)
	at com.intellij.execution.ui.layout.impl.GridCellImpl.restoreLastUiState(GridCellImpl.java:268)
	at com.intellij.execution.ui.layout.impl.GridImpl.restoreLastUiState(GridImpl.java:172)
	at com.intellij.execution.ui.layout.impl.RunnerContentUi$5.contentAdded(RunnerContentUi.java:829)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.intellij.util.EventDispatcher.dispatchVoidMethod(EventDispatcher.java:120)
	at com.intellij.util.EventDispatcher.lambda$createMulticaster$1(EventDispatcher.java:85)
	at jdk.proxy2/jdk.proxy2.$Proxy131.contentAdded(Unknown Source)
	at com.intellij.ui.content.impl.ContentManagerImpl.fireContentAdded(ContentManagerImpl.java:636)
	at com.intellij.ui.content.impl.ContentManagerImpl.doAddContent(ContentManagerImpl.java:210)
	at com.intellij.ui.content.impl.ContentManagerImpl.addContent(ContentManagerImpl.java:174)
	at com.intellij.execution.ui.layout.impl.RunnerLayoutUiImpl.addContent(RunnerLayoutUiImpl.java:110)
	at com.intellij.execution.ui.layout.impl.RunnerLayoutUiImpl.addContent(RunnerLayoutUiImpl.java:98)
	at org.jetbrains.kotlin.idea.debugger.coroutine.DebuggerConnection.registerXCoroutinesPanel(DebuggerConnection.kt:97)
	at org.jetbrains.kotlin.idea.debugger.coroutine.DebuggerConnection.processStarted$lambda$1(DebuggerConnection.kt:69)
	at com.intellij.debugger.DebuggerInvocationUtil.lambda$swingInvokeLater$0(DebuggerInvocationUtil.java:23)
	at com.intellij.openapi.application.ReadAction.lambda$run$1(ReadAction.java:54)
	at com.intellij.openapi.application.impl.AnyThreadWriteThreadingSupport.runReadAction$lambda$9(AnyThreadWriteThreadingSupport.kt:462)
	at com.intellij.openapi.application.impl.AnyThreadWriteThreadingSupport.runWithTemporaryThreadLocal(AnyThreadWriteThreadingSupport.kt:203)
	at com.intellij.openapi.application.impl.AnyThreadWriteThreadingSupport.runReadAction(AnyThreadWriteThreadingSupport.kt:462)
	at com.intellij.openapi.application.impl.AnyThreadWriteThreadingSupport.runReadAction(AnyThreadWriteThreadingSupport.kt:387)
	at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:875)
	at com.intellij.openapi.application.ReadAction.compute(ReadAction.java:66)
	at com.intellij.openapi.application.ReadAction.run(ReadAction.java:53)
	at com.intellij.debugger.DebuggerInvocationUtil.lambda$swingInvokeLater$1(DebuggerInvocationUtil.java:23)
```

GitOrigin-RevId: 24ed5b2bd9a65bcbe5df8037ce1383167e9c982a
2025-02-11 12:16:56 +00:00
Egor Ushakov
f6f9b83992 EA-1652995 - ITE: PrimitiveValueImpl.convertForAssignmentTo
GitOrigin-RevId: 73ee07cd665ee523ec6b38933f1caa718a4aea0b
2025-02-10 20:42:52 +00:00
Maksim Zuev
0d399098ea [kotlin debugger] IDEA-352774 Function breakpoints should use kotlin signature/name extraction
* fix breakpoint for functions with context receivers

GitOrigin-RevId: 1df0b2efce7cf22d9c237470a7803a906948c7d6
2025-02-07 18:32:26 +00:00
Vladimir Parfinenko
7a686a8f46 [debugger] workaround for Qodana/Maven/Space problems during safe push
See QD-10948 for more details.

GitOrigin-RevId: 9229637ef47be653b980e30ee9de6b1aee65a5fa
2025-02-07 13:47:04 +00:00