Commit Graph

37 Commits

Author SHA1 Message Date
Nikita Eshkeev
07c55c801c [codeinsight][cleanup] IDEA-236413 Java: incorrect text for unused public fields with Inject
There were added additional hightlight tests to
QsImplicitUsageProviderTest, which is out-of-scope of the task. The
highlight tests was moved to MarkFieldsWhichAreExplicitlyWrittenAsUnused

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 67a9383b6bdf34adc1a1412e60f1328fdd591b35
2020-04-09 09:41:07 +00:00
Nikita Eshkeev
c5914f53b9 [codeinsight] IDEA-236413 Java: incorrect text for unused public fields with Inject
IDEA used did not use to check the visibility of a field and if there is
the javax.inject.Inject or similar annotations added to the field IDEA
used to always reported the the Private field is not used.

This patch adds a new method that generates the error messages
based on the visibility level of the field.

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 89d7e2f783b1e54b239d15a2007d9e7376ffdbfa
2020-04-07 20:31:46 +00:00
Rustam Vishnyakov
123242c4b2 EditorConfig documentation test
GitOrigin-RevId: fd52ace3d7a32ecd02c2c5ab90e077967604c15e
2019-06-16 04:03:21 +03:00
Egor Zhdan
c1813cfb52 Cleanup: NotNull/Nullable
GitOrigin-RevId: b8e892f32ea84c2115973155dba7127b892cc36e
2019-06-16 04:02:08 +03:00
Anna Kozlova
91f7445298 constructor reference: don't ignore constructor parameters during method reference inference (IDEA-185578)
GitOrigin-RevId: e836468e05db28157713e9edd3c70382f8ecdebc
2019-06-13 03:15:49 +03:00
Egor Zhdan
39d2d77155 Cleanup: NotNull/Nullable
GitOrigin-RevId: b8e892f32ea84c2115973155dba7127b892cc36e
2019-06-13 03:14:35 +03:00
Aleksey Pivovarov
322db66a12 Recover after problematic merge
This commit reverts 65a557bb38f6ac03afa9aabaf02cb8d99fc68a91
                    3f5cfd958d9b6b54393c15983ac94f519c37fe61

GitOrigin-RevId: 8fb8ccbb17d0e217a83f265c185a943b0f5a7ed6
2019-05-03 01:52:21 +03:00
Nicolay Mitropolsky
9b850726ee [uast-groovy] UInjectionHost support
GitOrigin-RevId: 49ec454d1831796fa63b77fdc965f61985bf877e
2019-05-03 01:47:46 +03:00
Vladimir Plyashkun
c33e69a545 CPP-16098 - Lags during inplace rename typing
- reverted some of the changes

GitOrigin-RevId: c7c07b80a76c29794ef31e0e916e62f7f302917a
2019-05-03 01:47:14 +03:00
Leonid Bushuev
34be4bbf7d Apply the change from Develar: cleanup - specify UTF_8 charset explicitly
GitOrigin-RevId: 3f5cfd958d9b6b54393c15983ac94f519c37fe61
2019-05-03 01:46:11 +03:00
Vladimir Plyashkun
61a3e18b78 Merge branch 'master' into vplyashkun/inplace_rename_lags
GitOrigin-RevId: aaecc2a32e4e42de827efb45b8df733874a722e4
2019-05-03 01:41:29 +03:00
Leonid Bushuev
970dc0fe32 Remove unnecessary downcasting
GitOrigin-RevId: b91110977db6e5b08d9f4aaffa8496d305d698e2
2019-05-03 01:40:23 +03:00
Vladimir Plyashkun
2d9369d983 CPP-16098 - Lags during inplace rename typing
- changed behaviour in safe way by introducing new method to check that particular expression does not depend
  on committed PSI

GitOrigin-RevId: f5ec732613cdafdcef8a1d48eb8d04135c634047
2019-05-03 01:39:50 +03:00
Leonid Bushuev
338ad6db56 SQL code style per dialect: UI: fix indent editor
GitOrigin-RevId: 3cb00f5c500523717c42f404b2f38fd1822d6db0
2019-05-03 01:39:18 +03:00
Vladimir Plyashkun
e3ca319824 CPP-16098 - Lags during inplace rename typing
- call `commitDocument` explicitly in cases when `calculateQuickResult` can redirect it's calculation to heavy `calculateResult`

GitOrigin-RevId: 41f0c47c57f4528d7d7a25208024ec28bb8c2e12
2019-05-03 01:38:12 +03:00
Leonid Bushuev
dc1a52762e SQL code style per dialect: UI
GitOrigin-RevId: 9b1b3e745d4c8acef5a4a1018714e004e5423519
2019-05-03 01:37:38 +03:00
Vladimir Plyashkun
d712ac9901 CPP-16098 - Lags during inplace rename typing
- removed `commitDocument` call when `isQuick` argument is passed
- pass `element` or `null` to `equalsToText` call (since there is not real need to take it for text comparison)

GitOrigin-RevId: 27c5e1a2f484fc56d41dfd210832ae94c9a9b7ab
2019-05-03 01:37:04 +03:00
Leonid Bushuev
9f35a30458 SQL code style per dialect: UI
GitOrigin-RevId: 72cca4d6a23a5e2aa2089c03932ab2e9d08bfa48
2019-05-03 01:36:24 +03:00
Anna Kozlova
85fa5fa5d5 dummy constructor resolution: don't insert access object (IDEA-211203)
GitOrigin-RevId: 8b9184a572a263ec43e0e9c1a7d4af3b9151eb75
2019-04-28 14:58:28 +03:00
Anna.Kozlova
596fdda3e7 java resolve: prefer package for single-type-import only with default package exception (IDEA-206295) 2019-02-07 11:44:54 +01:00
Roman Shevchenko
9d90b90f72 Cleanup (warnings/typos/duplicates/formatting) 2018-12-04 14:57:30 +01:00
Anna Kozlova
6a85ff1fb5 resolve conflicting names when rename to 'ignored' (IDEA-184092) 2018-06-19 15:00:38 +03:00
Anna.Kozlova
ae17453dcc testdata for IDEA-130118 2018-03-15 11:18:58 +01:00
Anna.Kozlova
92d5484a0b testdata for IDEA-175759 2018-03-14 17:39:04 +01:00
Anna.Kozlova
c522bdfb38 ambiguity conflict resolution for class/package (IDEA-151859;IDEA-184289) 2017-12-28 18:09:41 +01:00
Anna.Kozlova
f4166d3f05 check function type's parameters/return type accessibility (IDEA-181036) 2017-10-25 19:50:25 +02:00
Anna.Kozlova
effcbfe27b overload conflicts: assume that subsignature conflicts are already resolved when most specific are checked (IDEA-168894) 2017-03-06 10:28:45 +01:00
Anna.Kozlova
51dde4575e don't prefer packages in static imports (IDEA-168464) 2017-02-21 18:21:01 +01:00
Anna.Kozlova
ab1a47ddef highlight unused fields implicitly assigned by extension (IDEA-166091) 2017-01-02 14:25:16 +01:00
Anna.Kozlova
a59edc4e4a accessibility check for annotation parameters: treat parameters as they are outside the class (IDEA-165904) 2016-12-27 14:47:58 +01:00
Anna.Kozlova
9544b4c809 highlight inaccessible array component type (IDEA-165434) 2016-12-14 18:40:27 +01:00
Anna.Kozlova
8e7077bb5b testdata for IDEA-139512 2016-07-13 11:43:16 +02:00
Anna.Kozlova
2be8a720a8 static import when inheritance present (IDEA-158357) 2016-07-12 11:08:35 +02:00
Anna.Kozlova
8eab2c79a4 suppressions: if @Generated found, mark as suppressed even if no @SuppressWarning is present (IDEA-158300) 2016-07-11 18:05:00 +02:00
Anna Kozlova
33273be517 substitute with bounds promotion: don't open captured wildcard for supers (IDEA-155370) 2016-07-04 10:21:00 +03:00
Anna Kozlova
db53a27296 prefer package to class in import list (IDEA-113756) 2016-06-07 20:06:58 +03:00
Anna Kozlova
c83341f731 shadowing of static imports (IDEA-142600) 2016-06-07 10:57:34 +03:00