Commit Graph
7162 Commits
Author SHA1 Message Date
Tagir Valeev 48848a8a7b IDEA-187645 NPE warning is not issued when "null -> null" method is called with Nullable argument 2018-03-03 15:02:58 +07:00
Tagir Valeev aa89c3b6fa CommentTracker: do not add a comment as a first child of PsiElement
Fixes IDEA-187526 "Add static import" with an intervening comment leads to exception
2018-03-02 16:22:19 +07:00
Tagir Valeev 8ba8714ef3 DFA: warn on method-ref dereference (IDEA-186732) 2018-03-02 14:59:02 +07:00
Tagir Valeev 4f854bc34a RedundantCompareCall testdata fixed 2018-03-02 09:54:28 +07:00
peter feeb53394c java completion: put signature suggestions below all types (IDEA-187504, IDEA-CR-28091) 2018-03-01 17:34:26 +01:00
Dmitry Batrak 1dd0a87b00 IDEA-187505 Locally-referenced images are not displayed in quick doc 2018-03-01 15:16:04 +03:00
Alexey Kudravtsev f6002904a7 IDEA-186767 Magic constant: false positive for JFrame.EXIT_ON_CLOSE 2018-03-01 14:09:00 +03:00
Tagir Valeev 2735fd74d5 IDEA-187474 Ternary condition is not boolean: add a quick-fix for method call 2018-03-01 14:45:49 +07:00
Tagir Valeev c4da8fdb79 IDEA-187130 Inspection: Comparison of primitives with compareTo() 2018-03-01 12:33:56 +07:00
Tagir Valeev 9bbfe9da3c IDEA-187094 Assume.assumeNotNull() from JUnit is not taken into account by the NullPointerException-related inspection 2018-03-01 10:43:22 +07:00
Tagir Valeev f6c45995d3 IDEA-187224: test fixed (beforeStringSubstringLength.java was not added mistakenly) 2018-02-28 14:15:23 +07:00
Tagir Valeev fa713953e9 IDEA-186380 Restore "Optional.get() without Optional.isPresent()" as a separate inspection 2018-02-28 14:08:40 +07:00
Tagir Valeev 80ab366ff6 StreamKnownSource test tuned: testListSize2 separated to avoid marking list.size() as unknown 2018-02-28 14:08:38 +07:00
Tagir Valeev 5feb5cb75a IDEA-187224 Add inspection for substring with String#length as second param 2018-02-27 13:05:45 +07:00
Tagir Valeev 7f7c4df2d0 StreamCollector10Inlining: +native; DataFlowInspection10Test: use Java10
Review ID: IDEA-CR-29835
2018-02-27 11:34:06 +07:00
Tagir Valeev 0da4fd17f3 IDEA-187214 Stream to loop inspection: support Java 10 toUnmodifiableList/Set/Map 2018-02-27 10:57:08 +07:00
Tagir Valeev 96be1a7fb2 StreamChainInliner: toImmutableXyz -> toUnmodifiableXyz 2018-02-26 18:17:32 +07:00
Tagir Valeev 2505f31197 DFA: special support of some collectors
Supported: counting, toList, toSet, toCollection, toMap, toImmutableList, toImmutableSet, toImmutableMap
Fixes IDEA-187215 Support Java10 toImmutableXYZ collectors in dataflow
2018-02-26 17:34:38 +07:00
Alexander Zolotov 985ea1e4ba Postfix templates: remove only expression statements on expanding
(IDEA-187042)
2018-02-21 20:32:17 +03:00
Tagir Valeev c483ae9cd0 ControlFlowUtils#getInitializerUsageStatus fixed for do-while loops where var is declared just before the loop 2018-02-21 12:24:01 +07:00
Tagir Valeev 3b96a595b9 DeleteSideEffectsAwareFix: handle comments 2018-02-20 17:06:53 +07:00
Anna.Kozlova bca21ba8c6 inference: substitution for captures (IDEA-186844) 2018-02-19 18:36:42 +01:00
Tagir Valeev 150784a9b6 Mutability: support initialized final fields 2018-02-18 17:38:58 +07:00
Tagir Valeev 413aca292b WrapWithAdapterMethodCallFix: correctly handle disjunction type
Fixes EA-116570 Cannot create expression for type class com.intellij.psi.PsiDisjunctionType
2018-02-18 07:54:47 +07:00
Tagir Valeev f5975ad8a2 Variable finality highlighting fixes
Unreachable branches are analyzed for twice assignment, but constants are evaluated.
Fixes IDEA-186321 Bad code green: non-iterating for-loop update
Fixes IDEA-186304 good code red: field might not have been initialized in unreachable branch
Fixes (mostly) IDEA-186305 good code red: variable might already have been assigned to
2018-02-17 12:35:03 +07:00
peter 131f679016 IDEA-186789 Completion in empty java file doesn't suggest access modifiers 2018-02-16 18:18:53 +01:00
Anna.Kozlova 8703c07861 disable add on demand static import for method reference qualifiers
IDEA-186826
2018-02-16 16:01:55 +01:00
Anna.Kozlova ab90341de0 pull up: update references in hierarchy for static methods in interfaces
IDEA-186590
2018-02-15 19:47:07 +01:00
Anna.Kozlova 983063a7bf javadoc: remove indentation for throws list 2018-02-15 16:31:11 +01:00
Daniil Ovchinnikov 872ddb5d0e [jvm-lang] rename create getter/setter actions
- _Create Getter_ -> _Create read-only property 'foo' in 'Bar'_
- _Create Setter_ -> _Create write-only property 'foo' in 'Bar'_

Action names are now consistent with _Create property 'foo' in 'Bar'_.
2018-02-15 16:00:36 +03:00
peter f8b88fec42 java completion: don't always cast qualifier when return type is narrowed (IDEA-186652, IDEA-186609)
only when that narrowed type is expected
2018-02-14 22:12:48 +01:00
Anna.Kozlova b3fd574ab2 javadoc: grayed text for calculated constants 2018-02-14 18:37:36 +01:00
Anna.Kozlova 8d8a443512 enum, abstract and final should be an error somewhere (IDEA-186642) 2018-02-14 18:37:36 +01:00
Tagir Valeev 38765d5366 RedundantStreamOptionalCall: warn about redundant sorted/distinct before certain collectors
Fixes IDEA-186507 Stream.distinct() can be simplified in certain cases
2018-02-13 19:10:10 +07:00
Alexey Kudravtsev 95ffe16d50 tests for IDEA-CR-29186 2018-02-13 14:19:12 +03:00
Alexander Zolotov d20f061afe Postfix templates: add a template to wrap an expression with a function call (IDEA-122461) 2018-02-13 14:09:07 +03:00
Daniil Ovchinnikov 544ee7980f [jvm-lang] java: port _Create getter/setter from usage_ actions
- extract PropertyRenderer for reusing;
- make them work with type parameter guesser.
2018-02-13 01:15:09 +03:00
Anna.Kozlova 5f8fdb5492 javadoc markup: missed break 2018-02-12 18:08:07 +01:00
Daniil Ovchinnikov 3151924a52 [jvm-lang] java: don't create private abstract methods (IDEA-186499) 2018-02-12 19:25:20 +03:00
Daniil Ovchinnikov fbe959bf47 [jvm-lang] java: port _Create property from usage_ action
- make it create template for both getter and setter;
- make it work with type parameter guesser;
- add tests!
2018-02-12 17:45:12 +03:00
Anna.Kozlova b80b461008 javadoc markup updated 2018-02-12 09:31:57 +01:00
peter 57efdd9cd1 dfa: fix typos (IDEA-CR-29106) 2018-02-09 14:34:01 +01:00
Tagir Valeev d6f04c1725 ContractInspection: warn about mutability violations (part of IDEA-182125) 2018-02-09 15:52:51 +07:00
Tagir Valeev 9e0c212432 ContractInspection: do not warn anymore when void method is marked as pure (IDEA-176015) 2018-02-09 15:52:50 +07:00
Tagir Valeev 63231c630d IDEA-186381 bad code green: variable might already have been assigned
Fixed parentheses handling on the left-side of assignment and in unary operations
Fixed error message priority
2018-02-09 12:45:18 +07:00
Tagir Valeev ba7227a715 DFA: better model for trusting a field initializer (fixes IDEA-186075) 2018-02-09 11:40:22 +07:00
Roman Shevchenko 36f5ac5335 [tests] fixes strange overriding of inner templates; corrects test data 2018-02-08 18:08:50 +01:00
Anna.Kozlova 1047b596ff fix testdata 2018-02-08 15:21:37 +01:00
Anna.Kozlova 3b0e08eb9e search for tests in directory restored for down-up approach
extended scope to ensure that the directory itself is included for new search
2018-02-08 14:05:23 +01:00
Anna.Kozlova 67251d36ed push down/inline superclass: don't change foreign inheritors (IDEA-186323) 2018-02-08 14:05:23 +01:00