Johannes Koenen
8b1c502b64
[QD-7418] Refactor GlobalInspectionContextImpl & InspectionEngine
...
- Formatting
- Revise creation of inspect listener
- Extract large lambdas
- Drop unused class
GitOrigin-RevId: 64d57f2d1a325ab86ba9a830a4d5da00732780a7
2023-10-27 13:56:25 +00:00
Alexey Kudravtsev
a471831170
EA-928847 IAE: ProblemDescriptorUtil.$$$reportNull$$$0
...
GitOrigin-RevId: 31b48547dd7b68efc9d1eac24084bd751c1a3f94
2023-10-25 13:11:12 +00:00
Vladimir Krivosheev
5f654380b8
IDEA-335449 cleanup
...
GitOrigin-RevId: 49781312a81bf7265b6b6013111928ed1adb6172
2023-10-23 17:23:58 +02:00
Nikolay Chashnikov
f1c274b406
[platform] mark for removal API which was deprecated in 2023.1 or earlier and has no external usages (IDEA-322162)
...
GitOrigin-RevId: 9e00612b0c5fd1268d6ef056c825150fea19e085
2023-10-20 22:20:49 +00:00
Alexey Kudravtsev
b25502b421
IDEA-327970 IntentionAction#isAvailable is called from EDT
...
More correct fix.
As soon as the EditorNotification is created (in EDT) we ask corresponding IntentionActionProviders for intention actions (also in EDT, they are cheap) and store them to the FileEditor user data. Then, during ShowIntentionAction collectInformation() (in BGT), we call collectActions() and retrieve the intention actions from FileEditor and update them (also in BGT)
GitOrigin-RevId: ad29a77ba3ff86e90f9884b22aadcff3cca37627
2023-10-19 15:21:19 +00:00
Alexey Kudravtsev
8cc9c26729
IDEA-321013 Outdated HighlightInfo's should be removed as soon as the relevant annotator or inspection finishes
...
- Rework inspection execution order. Run several inspection tools on all suitable PSI elements in parallel. As soon as the inspection tool finishes all its elements, analyze the HighlightInfo delta and apply it immediately (see HighlightInfoUpdater). Thus, the inspection tool doesn't interfere with the other inspection tool, allowing fast tools to apply infos sooner.
- Increase parallelism of tools for visible area, tools for invisible area, tools for injected fragments, allowing them all to execute in parallel, thus reducing the FJP rampup/rampdown latency (JobLauncherImpl.processQueueAsync() FTW).
- Implement LIP-wide duplicate info elimination, now that all tools are independent. Fix corresponding tests messing with expected duplicate problems.
- Rework file-level highlights. They are stored now as a regular HighlightInfo/RangeHighlighter with textRange=entire file.
- HighlightInfo now has `toolId` field for discerning infos generated by different inspection tools/annotators/highlight visitors.
GitOrigin-RevId: bc85a1858754dec04cec74a79909f009681bda98
2023-10-18 20:30:33 +00:00
Yann Cébron
dadf0c947b
[platform] SeverityRegistrar: fix Topic level
...
GitOrigin-RevId: 1ea36590fab06356901a92add53bb47758d6a4dd
2023-10-17 10:45:15 +00:00
Yann Cébron
6771102d2d
[platform] annotate Topic level
...
GitOrigin-RevId: ce9016b4311a57bcbd2f17bd9cf5bb69711f041f
2023-10-17 09:59:54 +00:00
Andrey Starovoyt
08973468b3
platform: fix live template saving for optional processors IDEA-327904
...
GitOrigin-RevId: 24d8499a15e30a2cc35f2b5f46e228c7e5346a84
2023-10-17 09:29:20 +00:00
Yann Cébron
e1814dfb13
[platform-*] annotate Topic level
...
GitOrigin-RevId: 7f1f1d5885c7ba1444ec64e22f28a971f2e32b38
2023-10-16 19:42:42 +00:00
Mikhail Shagvaliev
839db78de2
[qodana] QD-7318 IJ-CR-115706 Performance: instead of checking scope of each inspection individually, aggregate inspections by scopes and check them in batch
...
- do not use such approach for "Inspect Code" since there inspections mostly don't have scopes and this only degrades performance
GitOrigin-RevId: c417fe131c2c20b8c21da6c040184e73290411d4
2023-10-15 15:26:08 +00:00
Tagir Valeev
ef79080631
[postfix-templates] TemplateImpl#equals to consider the USE_STATIC_IMPORT_IF_POSSIBLE value
...
Fixes IDEA-326500 Postfix Completion "Use static import if possible" do not save
GitOrigin-RevId: 7d1bd038e7c96614bcb16a2d9da270dea5e3fc9b
2023-10-12 17:53:43 +00:00
Alexey Kudravtsev
bb0d4118fb
cleanup
...
GitOrigin-RevId: 827d1cf95b7fecb3bde6026bcf0c6b94d5445076
2023-10-12 17:22:28 +00:00
Ramazan Dzhekshembaev
897a0efdaa
[fleet] if name id of psi element is null, rename mod command should have null name id range
...
GitOrigin-RevId: 8a704815c9188a73b00725a30d12ec2efd82f5f7
2023-10-12 14:18:49 +00:00
Ramazan Dzhekshembaev
491cfd8b36
add range for an element's name identifier in ModRenameSymbol command
...
GitOrigin-RevId: 22bba0af4421cb1ec25784534a34569dd9bb8d8a
2023-10-12 14:18:48 +00:00
Ramazan Dzhekshembaev
9bd51e8d98
[fleet] revert debug changes
...
GitOrigin-RevId: 738ffa4e86a7379145643da30dbd4173fcba70ee
2023-10-12 14:18:48 +00:00
Ramazan Dzhekshembaev
704e761128
[fleet] basic mod commands implementation
...
GitOrigin-RevId: f6f98770612fbddbb7c5db963225054719d7b57e
2023-10-12 14:18:48 +00:00
Tagir Valeev
94517940ba
[java-inspections] Fix set options quick-fix for unused declaration
...
Fixes EA-915065 - IAE: ModCommandServiceImpl.updateOption
GitOrigin-RevId: 020fb4c82dbd8116ecd23140385bc6babe17ed6f
2023-10-11 20:59:40 +00:00
Konstantin Aleev
ad8c453d74
[platform] IDEA-331384 API: encapsulate TailTypes fields
...
GitOrigin-RevId: 5c33b3466c0c01832ed8b651a4eb651cf649847f
2023-10-11 13:47:40 +00:00
Alexey Kudravtsev
aa7e6b61b4
cleanup
...
GitOrigin-RevId: c8d45655b853f95bbff3b537077c649f8f1692bf
2023-10-11 11:13:06 +00:00
Alexey Kudravtsev
bcf4653706
IDEA-331952 PluginException: Cyclic service initialization com.intellij.codeInsight.daemon.DaemonCodeAnalyzer
...
GitOrigin-RevId: bd975c0ea6f35727e654dc8bd442bd0c624f04d8
2023-10-11 11:12:59 +00:00
denispopesku
b15783a3af
IJ-CR-112504 added Nullable annotation and inlined function
...
GitOrigin-RevId: a3babb846389863649b83a01704fdd3921b732b8
2023-10-10 11:01:04 +00:00
Konstantin Hudyakov
66e4048f8a
[completion] IDEA-334124 Add additional java docs to new API
...
GitOrigin-RevId: b9165d1f221ed957153afdb7be4957fe784f3d02
2023-10-09 15:42:01 +00:00
Konstantin Aleev
84f54ed97d
[platform] IDEA-331384 API: deprecate constants in TailType class including those of type CharTailType
...
- rename existing TailTypes class to JavaTailTypes
- declare constants in new TailTypes class
- update usages
GitOrigin-RevId: 62484d4a67c291ff5da13fad223b841cb1855eac
2023-10-06 18:19:16 +00:00
Konstantin Hudyakov
1702d380dd
[completion] IDEA-334124 Add an API to allow customizing some aspects of the Lookup presentation
...
Such as popup position and sorting order of suggestions. It is needed to customize the completion popup in the Terminal.
GitOrigin-RevId: af955e601fd5ae63a276110717c6a204551104ba
2023-10-06 09:13:26 +00:00
Vladimir Krivosheev
1db1d2f16a
IDEA-327116 cleanup
...
GitOrigin-RevId: a90125df9cd591c4f0e41c81feb7b3f39c8257b7
2023-10-03 10:05:33 +00:00
Vladimir Krivosheev
74ee91d5f2
cleanup - sort modifiers
...
GitOrigin-RevId: 6d868dbe90d76d992c43e4df1fba56dc4c37ed76
2023-10-03 10:05:31 +00:00
Nikolay Chashnikov
eafab2cd28
[analysis] API cleanup: remove unused deprecated API (IDEA-322162)
...
GitOrigin-RevId: 3dd59ac8fe3b5425c7afdd9dd0d5ab52bacf6fb5
2023-09-29 09:21:28 +00:00
Tagir Valeev
320c3f2442
[mod-commands] IDEA-333301 Support suggested refactoring in ModCommands
...
GitOrigin-RevId: dbd1401630a68e3e6ca932c5671f428f81e8324d
2023-09-26 09:19:50 +00:00
Alexey Kudravtsev
e6f26df5e0
Run highlighting inside visible text range again if no new highlights are available, but there are elements in the range
...
Need such change to make sure to invalidate outdated highlights
GitOrigin-RevId: 22b65818093866681303805bc71f942986431a91
2023-09-25 17:12:51 +00:00
Daniil Ovchinnikov
c973850ddc
IJPL-255 replace Application.assertIsDispatchThread -> ThreadingAssertions.assertEventDispatchThread
...
GitOrigin-RevId: da80a0648ffce76e93f35f72afc93334b21fe9a2
2023-09-22 00:08:26 +00:00
Tagir Valeev
c86d97746e
[mod-commands] Better ModPsiUpdater documentation
...
GitOrigin-RevId: 3b591b299536ec7b89ff9aedcaf067ad64b55270
2023-09-21 16:07:59 +00:00
Ilia Zakoulov
432ec78c7d
[mod-commands] Handle renaming in a new file
...
GitOrigin-RevId: 15f7cf27124e03a204fe1b7affc5801f03723262
2023-09-21 12:31:43 +00:00
Dmitry Batkovich
8370964e5b
run DaemonProgressIndicator#onStop outside indicator's lock EA-909484
...
GitOrigin-RevId: cf614812c4f3725756888050dbca81e02aab59f7
2023-09-20 21:56:34 +00:00
Yuriy Artamonov
f84f0a8984
[platform] Unused import in InspectionEngine
...
GitOrigin-RevId: 9f09ee88e7c5ce3483f1c5c52d8fcf358509323f
2023-09-20 13:07:39 +00:00
Yuriy Artamonov
5c2a6e1400
[inspections] IDEA-321711 Avoid traversing elements for inspections that only need checkFile
...
GitOrigin-RevId: 1a27fd38091303408863a367e57bff575b5e3a3a
2023-09-19 11:11:41 +00:00
Yuriy Artamonov
f8f9f82c96
[inspections] IDEA-321711 Try to eliminate overhead of PsiElementVisitor calling checkCancelled in inspections
...
GitOrigin-RevId: a507f6e0a41aae12abe4257e5047eb4a210cbf44
2023-09-16 15:18:22 +00:00
Elena Shaverdova
06b3471bbb
Introduce WorkspaceFileKind.CUSTOM for IDEA-316977 Handy API for switching IndexableSetContributor to workspace model
...
GitOrigin-RevId: addd0e0a5a1e03fb0c6963eea0391492412d3d5a
2023-09-15 17:18:05 +00:00
Alexey Kudravtsev
c459adc717
remove unnecessary psiElement field as a potential leak
...
GitOrigin-RevId: 9b11e958804ebb9732bd967e1817e248a5cf9430
2023-09-14 12:46:53 +00:00
Alexey Kudravtsev
737705f0f3
cleanup: encapsulate HighlightInfo inside the RangeHighlighter a bit
...
GitOrigin-RevId: e45a94abcd921f84d1b993cf2ebc02939a1dc655
2023-09-13 18:18:07 +00:00
Bart van Helvert
cc61bc25c7
[jvm] Convert TestCaseWithNoTestMethods inspection to JVM
...
#IDEA-331938 Fixed
GitOrigin-RevId: 9ecdc3d6e03d52cb54865067483b4c97e29d3236
2023-09-10 16:39:57 +00:00
Dmitry Batkovich
d3d8fe42a2
rewrite daemon listener invocation again (synchronize it with DaemonProgressIndicator cancellation/stop operations) IDEA-313181
...
actually it should make StartupHighlightingIntelliJTest tests green
GitOrigin-RevId: c13b2fea679ed78b1501aeaeb8a2ecb0b76e9f6d
2023-09-07 10:11:42 +00:00
Louis Vignier
2c9c987ef6
[codeInspection] Fix DITRE#getSeverity temporarily using WriteIntentReadAction on EDT
...
#IDEA-331433 In Progress
GitOrigin-RevId: 9e4ecaea3586284cece33f33c157c64ae9eefc07
2023-09-06 19:42:17 +00:00
Nikolay Chashnikov
1042c5a0a2
cleanup: remove author from TODO comments and remove some obsolete and unclear TODOs
...
Mentioning an author of a comment makes little sense since it can be easily found by 'Annotate' action. Also, it may give a false impression that only the author may address the problem described in the comment.
GitOrigin-RevId: 2aa52762b109f0d2f1a6ec6f7bf53f24b39c0997
2023-09-06 11:11:13 +00:00
Alexey Kudravtsev
7ef8228bb1
cleanup: Logger does the deduplication now, there's no need for a manual map
...
GitOrigin-RevId: d7081624763f16c2088032575296e4275dc03d64
2023-09-01 17:25:52 +00:00
Alexey Kudravtsev
44d20f52ea
encapsulate qodana more
...
GitOrigin-RevId: af4a7da9ff3bb18173873a7a3f3871f0d7a625ab
2023-09-01 17:25:51 +00:00
Alexey Kudravtsev
c0aced5b0b
cleanup
...
GitOrigin-RevId: c6fcf5ff1bfaca448ec71118f89f1f9a5b391633
2023-09-01 17:25:49 +00:00
Alexey Kudravtsev
d5bdeef716
optimization: do not traverse all languages searching for dialects on inspection start etc; maintain "Language.transitiveDialects" set instead
...
GitOrigin-RevId: 51f522703c3fe2b9b5b2f2e10a7fc434756badbf
2023-09-01 10:59:05 +00:00
Alexey Kudravtsev
83009a77c9
cleanup
...
GitOrigin-RevId: 565de51d24864db9c6c172713e568d1dfbd9350f
2023-09-01 10:59:02 +00:00
Alexey Kudravtsev
303a9b3bf9
notnull
...
GitOrigin-RevId: 14c079597f5e076f2ae7d333b4abd7fd12619289
2023-08-31 14:13:00 +00:00