Commit Graph

129 Commits

Author SHA1 Message Date
Yann Cébron
1d0ac8c33e [devkit] "Extension class should not be public": show dedicated hint for services (IJPL-115185)
GitOrigin-RevId: 8ddceed617020cacc5e5c2cd3dfab5d3b0fbd8ad
2024-06-20 14:27:35 +00:00
Vladislav Rassokhin
78e0059e89 [platform] move isIdeaProject to a dedicated class in intellij.platform.ide.core as it's widely used
GitOrigin-RevId: 73c43defd45327b2beb761cd3a2d027d04754d7c
2024-06-20 13:09:26 +00:00
Karol Lewandowski
18003c638d IJPL-115558: Implement UastHintedVisitorAdapterHintsInspection
GitOrigin-RevId: 29b1bd0a6565136ef34d6bf9b9c86c672a64d59f
2024-06-10 10:02:21 +00:00
Karol Lewandowski
d69af56141 Add @Nullable/@NotNull annotations manually to avoid indeterministic indexing
GitOrigin-RevId: b05f205b8d831333591202223707e22c1f22e425
2024-05-21 10:36:11 +00:00
Konstantin Nisht
04c0915739 [devkit] Add mock JDK to avoid erroneous highlighting of ProcessCancelledException as an uncaught checked exception
GitOrigin-RevId: ae03d8faf127035aa25693b0e028272046e75038
2024-05-02 22:41:59 +00:00
Karol Lewandowski
2edbe63b3b Fix flaky tests for ReadOrWriteActionInServiceInitializationInspection
GitOrigin-RevId: 809917d72f1df8dee76aeb730e02cf29e7b18c64
2024-04-22 17:36:16 +00:00
Karol Lewandowski
396e518835 IDEA-326655: Remove unnecessary mockJDK-11 setup
GitOrigin-RevId: b20e303e8d17a493aa49c7ea11ae80108d862aa8
2024-04-09 08:00:38 +00:00
Karol Lewandowski
1076dec137 IDEA-326655: Read or write action called during service initialization
GitOrigin-RevId: 7946e238e6421167c01a9fa96425f5ca354b10c6
2024-04-05 16:55:31 +00:00
Vladislav Rassokhin
d5b62983c6 [devkit] move isIdeaProject to ProjectIconsAccessor, reuse code
GitOrigin-RevId: 83c08ca20b9a23910c527870664f6d266b5b07fd
2024-03-01 22:11:34 +00:00
Andrey Cherkasov
32e4248809 [devkit] LightServiceMigrationInspection: configurationSchemaKey must not be specified
^IDEA-254577

GitOrigin-RevId: db3871b563b94f9d55cf607326ebca8743756e60
2024-02-28 21:41:25 +00:00
Karol Lewandowski
bf33f56ded IDEA-330739: Devkit: extend "Cancellation check in loops" inspection
- Added support for forEach() and similar methods, and ContainerUtil.process()

GitOrigin-RevId: fc9b66f3584cf94d603d9a84825f4142de92544d
2024-02-08 19:53:11 +00:00
Andrey Cherkasov
e59d2a751e [devkit] LightServiceMigrationInspection: provide quick-fix
...for the "Service can be converted to a light service" warning. The provided quick-fix annotates the service class with '@Service' and removes its registration from the 'plugin.xml' file.

^IDEA-254577

GitOrigin-RevId: 55cace08aa3beade8fb5e28532a29df459e2c1f0
2023-12-13 20:03:28 +00:00
Andrey Cherkasov
18f65d7dd8 [devkit] LightServiceMigrationInspectionTestBase: extract method
GitOrigin-RevId: 7e947e1236dd5ba3b54a663581f75f9db247921b
2023-12-13 20:03:21 +00:00
Andrey Cherkasov
7884824d0f [devkit] Move test classes to another packages
GitOrigin-RevId: 807208799a195f262b1afbcd4c515fbf60adaf20
2023-12-13 20:03:18 +00:00
Dmitry Avdeev
6ba55541ee IDEA-337197 Throwable: the expensive method should not be called inside the highlighting pass in JSP
check unresolved references in a dedicated XmlUnresolvedReferenceInspection

GitOrigin-RevId: d54b7a0b933c33c8656726c84a9611c97c1268ff
2023-12-13 18:12:42 +00:00
Andrey Cherkasov
28108d64bb [devkit] Extension class should be final and non-public: false positives
The inspection must not warn on classes annotated with any of the VisibleForTesting annotations.

^IDEA-309065

GitOrigin-RevId: 6a9395c41b89c4c28bf9131d5c5de2f60127e517
2023-12-05 21:56:20 +00:00
Andrey Cherkasov
99d2b27c9d [devkit] "Incorrect service retrieving" inspection: false negatives
Added support the `ComponentManager#getServiceIfCreated` method

GitOrigin-RevId: 7eb6c0c157327a7ea8b4f3d69f0dac19003d8b37
2023-11-23 21:53:25 +00:00
Andrey Cherkasov
efb377a9f6 [devkit] ServiceRetrievingInspectionBase: Remove deleted method support
The `ComponentManager#getService(Class<T>, boolean)` method was removed in the commit with the hash 1faced6abc85cc859111ee0db72b14522477aa7a.

GitOrigin-RevId: 596131e7abb79065f56ea08f6a6b083fc81e906d
2023-11-23 21:53:19 +00:00
Andrey Cherkasov
243d66bfa1 [devkit] "Incorrect service retrieving" inspection: fix broken tests
GitOrigin-RevId: ba9fe75765ac2d51e689fd90122765b768d79d66
2023-11-23 21:53:17 +00:00
Karol Lewandowski
dbb74a9c98 IDEA-334137: Delete UseCoupleInspection
GitOrigin-RevId: d32b83ebf9cef84ea724d239ca2d783fa327d21b
2023-10-11 09:51:59 +00:00
Andrey Cherkasov
2e21416fee [kotlin uast] Make the findDefaultValueForAnnotationAttribute method work for usages of Java annotations from Kotlin
^KTIJ-27300

GitOrigin-RevId: b363764c07ee11f634b70e150440d80b74022689
2023-10-06 07:18:09 +00:00
Tagir Valeev
aa6829d7c1 [java-tests] IDEA-333831 Separate mock JDK and JetBrains annotations for testing
Also: avoid manual mocking of Java 10 classes in StreamCollector10Inlining test, use mockJDK11 instead
Also: rewrite SliceTestCase and its inheritors to LightJavaCodeInsightFixtureTestCase, as annotations.jar is not included into project created by DaemonAnalyzerTestCase
Also: 'mutates' attribute of @Contract annotation is resolvable now, as we can use newer jetbrains-annotations library.
Also: documentation tests now don't generate links to JetBrains annotations, which corresponds to the actual behavior in production

GitOrigin-RevId: e460826893c1277cb2b78b18aae9d5aca97d8333
2023-10-05 11:24:29 +00:00
Andrey Cherkasov
c7e0b8adeb [devkit] The "Simplifiable service retrieving" inspection: fix false positive
IDEA-333347

GitOrigin-RevId: 585bd8e37e60c2da24f553a250dd2ba87374ef6a
2023-10-03 16:15:46 +00:00
Andrey Cherkasov
073114cdb2 [devkit] Split the "Incorrect or simplifiable retrieving service" inspection into two
IDEA-327590

GitOrigin-RevId: 721b34c773e16b93cc593080ba2dbc130606ed40
2023-10-03 04:01:17 +00:00
Andrey Cherkasov
dad972fa4f [devkit] Incorrect or simplifiable retrieving service: support service, serviceOrNull and serviceIfCreated methods
IDEA-323207

GitOrigin-RevId: fbcfa88ce071270f05f6182223fb13d634c79678
2023-09-29 14:45:36 +00:00
Andrey Cherkasov
9264913ca1 [devkit] Fix the ServiceUtil.kt methods according to the fact that the default service level is application-level
IDEA-330430

GitOrigin-RevId: 5ba4b258d2c18c9c014397c1dd1280375acc9020
2023-09-27 19:27:13 +00:00
Karol Lewandowski
18288a9f6d IDEA-313346: Convert FileEqualsUsageInspection tests to Kotlin
GitOrigin-RevId: 2cc3cd831350aa51ee753ba0466f7d82bc5dde4b
2023-09-14 20:53:09 +00:00
Karol Lewandowski
7e4d1d6e44 IDEA-313346: FileEqualsUsageInspection improvements - Add tests for Kotlin
GitOrigin-RevId: 1cbb962d87bea94fd69e7b047b329674a7ebbe61
2023-09-06 12:43:37 +00:00
Elena Lyulina
9db39a03d2 [devkit] IDEA-323201 simplify test data, improve wording, make class internal
GitOrigin-RevId: efb1f88a92264c43790383ca695874cc7424f3ea
2023-08-25 00:27:40 +00:00
Elena Lyulina
4a112d1970 [devkit] IDEA-323204 implement new inspection
GitOrigin-RevId: 379d6e0776d132ee356ba62db23660ca388ea137
2023-08-24 14:49:51 +00:00
Elena Lyulina
7b2a2bd293 [devkit] IDEA-323201 add inspection implementation, ensure no intersection with Companion object in extensions
GitOrigin-RevId: 38d092a7d9a7a43e5c7a1032a93dd5c8db9d65e6
2023-08-23 11:03:13 +00:00
Elena Lyulina
30c7986c40 [devkit] IDEA-298703 IDEA-305592 add a check for SSR inspection Eager service initialization during classloading
GitOrigin-RevId: 12c45875706c98f58ca8029ae34d30bf9e02f4c5
2023-08-22 10:52:56 +00:00
Elena Lyulina
4701e0fd21 [devkit] IDEA-298703 improve naming, add a check for backing fields in kotlin
GitOrigin-RevId: 5e74319e790c4246b64e6d5f57c51c6930dbf19f
2023-08-22 10:52:55 +00:00
Andrey Cherkasov
cc230391c5 [devkit] Rename the inspection and its error message and fix the description
IJ-CR-102810

GitOrigin-RevId: 49d74d790ee90f75a248413f5ae16b504c9d8afb
2023-06-23 17:07:50 +00:00
Andrey Cherkasov
f96d25fe8d [devkit] Do not report service classes that contain a check on the unit test or UI-less mode
IJ-CR-105402

GitOrigin-RevId: cc3e83f7e6e6f93f663c43aea66a3680e8c264b4
2023-06-18 18:33:31 +00:00
Karol Lewandowski
cab1ca4428 IDEA-284442: Inspection for checking proper ProcessCanceledException handling
GitOrigin-RevId: df531ecbc407cc492e5182f64a8c80a5a4c5c348
2023-05-30 14:34:19 +00:00
Andrey Cherkasov
f836389d95 [devkit] ActionPresentationInitializedInCtorInspection: fix false negative when AnAction is not in sources
IJ-CR-107717

GitOrigin-RevId: 9ac2e5a7e38cc77b969b796c89ac06e535e34881
2023-05-26 17:03:36 +00:00
Andrey Cherkasov
5809432245 [devkit] Rename AnActionInitializesTemplatePresentationInCtorInspection to ActionPresentationInitializedInCtorInspection
IJ-CR-107717

GitOrigin-RevId: 53b9e64b5844838c0c715dcf4ccf58b1186ae6c1
2023-05-26 17:03:29 +00:00
Elena Lyulina
ca6091fb93 [devkit] IDEA-309523 Extend the inspection to other loop types and add a quick fix to insert a cancellation check
GitOrigin-RevId: 7548f7bce82a119670885fc2de88f326ec8d1662
2023-05-24 13:11:09 +00:00
Andrey Cherkasov
f4412f28ea [devkit] new inspection: Eager creation of action presentation
IDEA-315381

GitOrigin-RevId: 32e98d2c44d260b5cca339ffd5f75c806fdc263b
2023-05-19 15:33:58 +00:00
Elena Lyulina
8909b131f8 [devkit] IDEA-298703 add Wrap in Supplier fixes for java/kotlin and fix incorrect cases
GitOrigin-RevId: 9b5828bdee4699ba05f3d2133b5a1b8b614fdae7
2023-05-17 21:06:37 +00:00
Andrey Cherkasov
14b82e505e [devkit] Extension points for ExtensionClassShouldBeFinalAndNonPublicInspection
IJ-CR-102810

GitOrigin-RevId: 95bd3f994f92b3f776ff75c671f2cf6fbc2eaf86
2023-05-16 16:26:58 +00:00
Andrey Cherkasov
79c4f513f9 [devkit] Remove redundant comments
IJ-CR-105402

GitOrigin-RevId: a3ae3d8cda495551cd798f049540a466329ce417
2023-05-12 20:14:25 +00:00
Andrey Cherkasov
6b9b7b4726 [devkit] Remove redundant comments
IJ-CR-102194

GitOrigin-RevId: e04a7c595ceccef93a301f888f868ecb5db9b6b6
2023-05-12 20:14:22 +00:00
Karol Lewandowski
1410c66953 IDEA-306218: Improve DevKit tests performance - use LightDevKitInspectionFixTestBase
GitOrigin-RevId: 752e4b508b0eb9897ca0370dcd6280f04099a958
2023-04-28 08:04:20 +00:00
Andrey Cherkasov
8115e326f3 [devkit] Merge 2 inspections into 1 via EP
IJ-CR-102810

GitOrigin-RevId: 018a3f2bc5dff42b476d8eae7406b569ef58610e
2023-04-26 16:21:59 +00:00
Andrey Cherkasov
1aa1c83143 [devkit] LightServiceMigrationInspectionTestBase: cleanup
IJ-CR-105402

GitOrigin-RevId: 85208a2d0231fb88a85d6d799a0fecb140fce98f
2023-04-26 16:21:56 +00:00
Andrey Cherkasov
2fd524ce0f [devkit] "A service can be converted to a light one" inspection: convert tests to light ones and extract doTest method
IJ-CR-105402

GitOrigin-RevId: fd71b68fa3266b3c67d63795326da02b88638098
2023-04-25 08:22:54 +00:00
Andrey Cherkasov
0f673df822 [devkit] MismatchedLightServiceLevelAndCtorInspection: fix editor message and quick-fix text
IJ-CR-102194

GitOrigin-RevId: e596c556030bb12d58f01138c45996111fb7138c
2023-04-25 08:22:42 +00:00
Andrey Cherkasov
3059c63918 [devkit] RetrievingServiceInspection: rewrite inspection
IJ-CR-102194

GitOrigin-RevId: 52a07618ff9c8370419fb594a3af1af4db3f05c5
2023-04-25 08:22:39 +00:00