Commit Graph

2153 Commits

Author SHA1 Message Date
Anna Kozlova
32b5f1d747 ensure local classes are not suggested to be made static (IDEA-167085) 2017-01-25 13:42:32 +03:00
Anna Kozlova
2ad9f23ea0 add read action; avoid casts due to overload resolution rules 2017-01-24 16:16:28 +03:00
Pavel Dolgov
0e3f25ea99 Java: Updated text message in "Module tries to export package to itself" inspection. (IDEA-164129) 2017-01-23 15:26:49 +03:00
peter
54624d1864 infer no contracts for methods always returning null/true/false
they're likely to be used as constant-like flags for functionality being enabled or not (IDEA-166399)
2017-01-23 12:38:06 +01:00
Tagir Valeev
8f904a0d06 IDEA-166827 Quick-fix to insert SAM-method call 2017-01-23 12:55:51 +07:00
peter
edadcd1fb7 don't highlight usages of compile-time constants in variable initializers as always true/false (IDEA-157715) 2017-01-21 14:22:08 +01:00
peter
d141da325e don't infer _->!null contracts for explicitly nullable methods (IDEA-166399) 2017-01-21 14:22:07 +01:00
peter
87f9b34b5b highlight nullable methods that always return a non-null value (IDEA-166399) 2017-01-21 14:22:06 +01:00
peter
59bdc4b5ab IDEA-166444 Good code yellow: Not annotated method with primitive return type is used as an override for a method annotated with NotNull 2017-01-18 19:42:15 +01:00
peter
ab22b9b3ac IDEA-166582 No completion inside lambda when instance of contains lambda 2017-01-18 19:42:14 +01:00
Anna Kozlova
560b5b0265 provide accessibility and static modifier fixes for method references (IDEA-166707) 2017-01-18 16:55:38 +03:00
Alexey Kudravtsev
e2bc59928a do not highlight members inside deprecated class as "deprecated member is still used" 2017-01-18 16:14:05 +03:00
Anna Kozlova
ecedc9baf6 visibility: fix target 2017-01-18 13:29:49 +03:00
Anna Kozlova
a66c04b035 fix copy pasted constant 2017-01-18 11:21:33 +03:00
Anna Kozlova
a7d096d34b visibility inspection: allow to disable make package-private suggestion for junit 5 tests (IDEA-166543) 2017-01-13 14:26:17 +01:00
Tagir Valeev
ed5189e166 IDEA-166577 Convert patterns like IntStream.range(0, array.length).mapToObj(idx -> array[idx]) to Arrays.stream(array) 2017-01-13 17:46:27 +07:00
Pavel Dolgov
83b5637a43 Java: Don't offer the quick-fix Collection.toArray() for type parameter arrays (like T[]) (IDEA-163341) 2017-01-13 12:22:32 +03:00
Anna Kozlova
52f8c8aeb1 visibility inspection: forbid make protected if used qualified outside package (IDEA-166106) 2017-01-12 16:57:35 +01:00
Anna Kozlova
7d8df26aed surround with array fix: ensure result is free from generics array creation error (IDEA-166489; IDEA-166490) 2017-01-12 16:57:35 +01:00
Pavel Dolgov
26a7739891 Java: Implemented the quick-fix Collection.toArray() that is offered in the context where an array is required but a collection is provided (IDEA-163341) 2017-01-11 16:43:18 +03:00
Anna.Kozlova
977c4cc924 clashing return type of overriding methods: fix unchecked override comparison (IDEA-166355) 2017-01-10 15:43:36 +01:00
Anna.Kozlova
78b9442d20 extract method: sanitize parameter types (IDEA-166319) 2017-01-09 18:15:16 +01:00
Anna.Kozlova
7356d1d8c3 used variable before static initializer (IDEA-166270) 2017-01-09 18:15:16 +01:00
Anna.Kozlova
070a3b85ab allow visibility inspection to warn on entry points (IDEA-165181) 2017-01-05 19:01:34 +01:00
Anna.Kozlova
4d2781ec75 ensure dynamically registered entry points are not lost due to caching 2017-01-03 13:17:13 +01:00
Anna.Kozlova
ba62633b95 highlight unused fields implicitly assigned by extension: take care of implicit usages which are not implicit reads (e.g. android) 2017-01-02 18:37:14 +01:00
Anna.Kozlova
fba6caecc2 access can be tightened: forbid qualified access to protected members (IDEA-166106) 2017-01-02 17:11:12 +01:00
Anna.Kozlova
ab1a47ddef highlight unused fields implicitly assigned by extension (IDEA-166091) 2017-01-02 14:25:16 +01:00
Anna.Kozlova
9a669f36ad error if static on-demand import references non-class (IDEA-160943) 2016-12-28 17:08:19 +01:00
Anna.Kozlova
9d9c62523d warn about static methods in interface with same erasure (IDEA-165927) 2016-12-27 14:47:58 +01:00
Anna.Kozlova
a59edc4e4a accessibility check for annotation parameters: treat parameters as they are outside the class (IDEA-165904) 2016-12-27 14:47:58 +01:00
Tagir Valeev
ffc5e158f4 Identical catch blocks collapsed where possible
Via "Identical 'catch' branches in 'try' statement" inspection with manual check/corrections
2016-12-26 17:54:01 +07:00
Tagir Valeev
4a2a11c85f IDEA-163833 Replace Collectors.toCollection() for custom collections: check implementation 2016-12-23 12:13:09 +07:00
peter
19ffdbe7aa avoid false positive contract violations when the control flow goes through unknown conditions (IDEA-164883) 2016-12-22 15:12:03 +01:00
peter
116a11a17b IDEA-164995 Warn about @Nullable problems for method references 2016-12-22 14:53:25 +01:00
peter
66b8d67f53 IDEA-165067 Unwrapping 'if' leads to non-compilable code 2016-12-22 14:06:29 +01:00
Anna.Kozlova
08163051f3 show class/package conflict only if corresponding subdirectory contains classes so there could be usages with ambiguous imports 2016-12-15 14:48:27 +01:00
Tagir Valeev
50223c222e Fix IDEA-165466 Stream API migration: automatically simplify emptyList().stream() to empty()
SimplifyStreamApiCallChainsInspection refactoring: simplifyCollectionStreamCalls extracted;
2016-12-15 17:13:14 +07:00
Tagir Valeev
e73e12bcb1 SimplifyStreamApiCallChainsInspection#handleToArray simplified via getQualifierMethodCall 2016-12-15 15:47:35 +07:00
Tagir Valeev
89e08570b4 IDEA-165395 Replace stream API with loop: l.stream().toArray(String[]::new) 2016-12-15 15:39:48 +07:00
Tagir Valeev
3741495801 LambdaGenerationUtil: disable if expression is accessed for writing
Fixes IDEA-165482 Optional.isPresent suggests to replace the code which assigns the variable defined outside
2016-12-15 11:51:58 +07:00
Alexey Kudravtsev
e2bc8e4fe5 cleanup 2016-12-14 12:05:58 +03:00
Tagir Valeev
dddfd5d7b6 LambdaGenerationUtil#canBeUncheckedLambda: supports statements; checks control-flow breaks;
Fix for IDEA-165369 Replace Optional.isPresent() should be disabled if the thenBranch contains non-local control flow
2016-12-14 15:44:59 +07:00
Anna.Kozlova
b02b6bef9d dedicated exception to flag cancellation (IDEA-CR-16749) 2016-12-13 15:47:37 +01:00
Anna.Kozlova
2a376447de EA-92859 - NPE: SuspiciousMethodCallUtil.getSuspiciousMethodCallMessage 2016-12-13 13:28:36 +01:00
Anna.Kozlova
e2426846f4 external annotations: cancel annotation if user cancels dialog with annotation root suggestion (IDEA-165041) 2016-12-09 13:47:23 +01:00
Anna.Kozlova
9aac402918 enable suspicious collections method calls for method references (IDEA-165237) 2016-12-09 13:47:23 +01:00
Tagir Valeev
7dfcf14575 RedundantCastInspection: PsiUtil.skipParenthesizedExprUp used 2016-12-09 15:17:25 +07:00
Alexey Kudravtsev
a95bbe99b0 diagnostics for EA-92610 - assert: JavaFindUsagesHelper.lambda$getElementNames$ 2016-12-08 19:42:17 +03:00
Alexey Kudravtsev
ffc41b19b7 <code> replaced with {@code} 2016-12-08 19:42:17 +03:00