Commit Graph

12446 Commits

Author SHA1 Message Date
Tagir Valeev
2d6d8cb12f IDEA-245149 IDEA doesn't create record file when paste definition in Project view
GitOrigin-RevId: 57257d7326404699d6356cdb8b25672315541d1f
2020-07-06 05:11:57 +00:00
Tagir Valeev
72e1fd48dd IDEA-244895 Add closing curly bracket when introduce local interface or enum
GitOrigin-RevId: 90c7fa5043f06ffb7bdb9a9f158eba32beb8dd31
2020-07-06 04:01:14 +00:00
Vladimir Krivosheev
60fd7050f8 cleanup - use AppExecutorUtil.getAppExecutorService() directly
GitOrigin-RevId: f327995c44a5fed451c9f1dfde971a3eabfaa481
2020-07-04 16:32:46 +00:00
Vladimir Krivosheev
e24def0702 IProjectStore - prefer path, remove unused getDirectoryStorePathOrBase, optimize convertModule (don't compute runners twice)
GitOrigin-RevId: 493c08ba4a17f028b1da17649133ded1633034b3
2020-07-04 11:27:34 +00:00
Vladimir Krivosheev
1ef5aedd24 RunConfigurableTest - fix mem leak
GitOrigin-RevId: 9aae2413f469f198a3b6f674ec26c4e539cb5bfe
2020-07-03 16:08:52 +00:00
Tagir Valeev
8b0cc7e937 Fix completion tests that interfere with 'abstract class' completion
GitOrigin-RevId: c974f209263f478f289a00a158ad5e3e4e221c5e
2020-07-03 11:44:40 +00:00
Vladimir Krivosheev
e557899451 fix TestNGModuleInfoIntegrationTest
GitOrigin-RevId: 496f4ace75be8a1b567936f891783c6866d88ecf
2020-07-03 11:32:45 +00:00
Tagir Valeev
03a3542906 Refuse to start the refactoring if variable type is not parseable (e.g. starts with 'var')
Fixes EA-233636 - assert: JavaParserUtil.parseFragment

GitOrigin-RevId: 314b3f0203dd49306b8374467aae36f7207d53c5
2020-07-03 11:19:12 +00:00
Artemiy Sartakov
85cf47d3ef Problems view: recheck previously reported members when class name changed (IDEA-245063)
GitOrigin-RevId: c1786816408761c4837d983753f124b417b11370
2020-07-03 08:42:35 +00:00
Tagir Valeev
1d04c3e72c IDEA-245077 Complete 'abstract class' inside methods
GitOrigin-RevId: ea70c514267a89fa678965c08e2a13c44eda351f
2020-07-03 07:51:23 +00:00
Mikhail Sokolov
d1df7e8eaa IDEA-242544 Search Everywhere: Recent files are not shown at the top of results if case does not match
GitOrigin-RevId: 7aed5e9a977f27b327fb7093b0455277ae314497
2020-07-02 16:59:51 +00:00
Alexandr Suhinin
3ab1e8e852 IDEA-244988: extract method: dont suggest static modifier inside local or inner classes
GitOrigin-RevId: 2c496066816e484a45c71cb65e25e217c394e261
2020-07-02 13:00:35 +00:00
Alexey Kudravtsev
dc8fe85ed0 port some deprecated Condition usages to java.util.Predicate
GitOrigin-RevId: 1e6d96d2c6621de130830fdbb8814e819da6b75c
2020-07-02 11:16:02 +00:00
Vladimir Krivosheev
3552e31b2f state storage manager macro value as path instead of string
GitOrigin-RevId: 6ab1192ec2cc53ff8db64e9fd1b9001a0141c39a
2020-07-02 09:33:51 +00:00
Vladimir Krivosheev
c11cdea14d state storage manager macro value as path instead of string
GitOrigin-RevId: b1411b4deb77099d564e3cdeb413a1fc37b16219
2020-07-02 09:33:48 +00:00
Vladimir Krivosheev
2b8e1fa7d7 HeavyPlatformTestCase - create and open project in one call, exactly as it does in production
GitOrigin-RevId: 0ef6828ee848127a5586248f23595a742cd0ce52
2020-07-02 09:33:43 +00:00
Eldar Abusalimov
b0975d4d58 UsefulTestCase: Make it JUnit4-friendly
GitOrigin-RevId: 821c2ba3c40cfc816b6eba059a898b2de40502b7
2020-07-02 09:09:07 +00:00
Eldar Abusalimov
7fcc5acd9a UsefulTestCase: Replace invokeTestRunnable() with runTestRunnable()
GitOrigin-RevId: 0900f73aa838cbf3c4b5c577cab97285ea4cea3c
2020-07-02 09:09:07 +00:00
Eldar Abusalimov
c04bcf72f2 UsefulTestCase: Make invokeTestRunnable() take ThrowableRunnable
GitOrigin-RevId: f929b8cc7d7b10e60f627c67731ea9c627f0bbb4
2020-07-02 09:09:05 +00:00
Eldar Abusalimov
4afa31f911 Remove @Before/@After annotations from JUnit3 setUp()/tearDown()
Also rename genuine JUnit4 setUp()/tearDown() annotated with
@Before/@After to before()/after() to avoid confusion.

GitOrigin-RevId: fb1b058a19e3bef910554c60b80211d48e33b8c1
2020-07-02 09:09:02 +00:00
Eldar Abusalimov
5f102f04ad LightPlatformCodeInsightTestCase: Reuse our JUnit4 getRunBareTestRule()
All its inheritors are now JUnit4-compatible.

Also remove the now unnecessary before(), after() and all the
boilerplate in test methods used for running them on the right thread.

GitOrigin-RevId: 65802a7be2e7d015e96fc7cccdd70ed20a54af63
2020-07-02 09:08:58 +00:00
Eldar Abusalimov
9823720393 LightPlatformCodeInsightTestCase: Add isRunInCommand()
GitOrigin-RevId: da5b099d6e243de68226b278e55820be9560d1b3
2020-07-02 09:08:57 +00:00
Eldar Abusalimov
068ce433cd PsiConcurrencyStressTest: Remove invokeTestRunnable() override
The super.invokeTestRunnable() from HeavyPlatformTestCase effectively
does the same.

GitOrigin-RevId: 2f41b93d7d3d708b6dc7e4243195e21b46b49d93
2020-07-02 09:08:53 +00:00
Artemiy Sartakov
f734b048b0 Problems view: use InlayHintsProvider instead of separate HighlightingPass
GitOrigin-RevId: 04a6cf67c7bfe610c881dc02488e44db097cdf57
2020-07-02 07:45:04 +00:00
Peter Gromov
f41f96a7a6 suggested refactoring: use an orthodox way to invoke intention in tests, fix a writability issue found as the result
GitOrigin-RevId: e8ca4c3aea1f6c331680c8e29427f2f9b85d1e1d
2020-07-02 07:37:49 +00:00
Anna Kozlova
ee5541dec3 java conditional: set type null if one of sides is null and exp is poly expressions (IDEA-244854)
GitOrigin-RevId: d073f5a7bf01d347614ab290e1242016d71bfc46
2020-07-01 18:43:01 +00:00
Alexandr Suhinin
5f0630e50c IDEA-244926: dont pass implicit static fields as static parameters
GitOrigin-RevId: 74272ab0afe9315626c5aae33c58f5448e5d2ce8
2020-07-01 07:02:27 +00:00
Anna Kozlova
e6c2ee1791 java: introduce variable: forbid extracting refExpr which resolves to class/package on explicit selection (IDEA-244925)
GitOrigin-RevId: 32b84f9b74e508ae83eeaf46f19dfbce78833ae5
2020-07-01 06:48:04 +00:00
Roman.Ivanov
15df967f66 minor, update copyright
GitOrigin-RevId: cdd53617ba9bd9f9051b6bd2383dc3ee1858877a
2020-07-01 04:21:56 +00:00
Roman.Ivanov
8d1e52195e introduce intention to make class sealed: IDEA-243848
GitOrigin-RevId: e69276f3747898731be50b3fc258211924582a48
2020-07-01 03:56:44 +00:00
Nikita Eshkeev
7ac5311c46 [codeInsight] IDEA-244246 IDEA should take into account Language level for highlighting of preview features
This patch removes the unused notDocumented variable in order to fix the problems with ZeroToleranceInspectionTest

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 77570ce0ea653c170e66024b3e866a2bde58ffdd
2020-06-30 17:30:33 +00:00
Nikita Eshkeev
4d0743574a [codeInsight] IDEA-244252 IDEA shows no error for @PreviewFeature
This patch fixes the problems with reporting errors when:

- a class that is annotated with PreviewFeature instantiated;
- a method that is annotated with PreviewFeature used in a method reference;
- a class or an interface that is annotated with PreviewFeature is inherited

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 586caeddae4446ad398878e0bd4bf66858e4518c
2020-06-30 17:07:59 +00:00
Peter Gromov
1140b156f9 rename JavaBranchRefactoringSuite to *Test to make it runnable in Java Tests on TeamCity
GitOrigin-RevId: f4321646d19db1d5a021f64a0838cf0656d4ea1a
2020-06-30 17:06:36 +00:00
Alexandr Suhinin
0ea2cc86c8 IDEA-242718: dont pass static fields as parameters
GitOrigin-RevId: 2b00ccc0466cc643ca6bd9c40fcc974b82d2fed8
2020-06-30 11:38:36 +00:00
Alexandr Suhinin
d955fdeaf5 IDEA-243597: infer return type for extract method
GitOrigin-RevId: 238fa50928517bf3f0a144baa8ae0a67b0f9eca9
2020-06-30 09:42:08 +00:00
Tagir Valeev
b37d97ee40 IDEA-187536 notice unused assignment in try catch
GitOrigin-RevId: 10d157648ae034f65a1ef15c0c3bc9ec12fa8e6a
2020-06-30 02:17:06 +00:00
Tagir Valeev
10db17a84a Use assertSameLinesWithFile
GitOrigin-RevId: 2954ccaade7b5f66ff6e9170c9e763ca4d9300ea
2020-06-30 02:17:05 +00:00
Sergey Patrikeev
846551cb49 DigestUtil: optimization: clone digest instance. Inline implementation-specific methods to clients. Deprecated code.
GitOrigin-RevId: db1448a65339696467f2618fd2dd664cb2a66d7f
2020-06-29 21:45:50 +00:00
Peter Gromov
9265db22db create a dedicated test suite for Java refactorings with model branches inside
GitOrigin-RevId: c01a096c56b3d744a7975330cb843123874137d8
2020-06-29 12:24:32 +00:00
Roman.Ivanov
1d5d92e563 fix test to work as intended
GitOrigin-RevId: d55c3b39a0abab528237cb9abcb183ae600f12ec
2020-06-29 12:05:38 +00:00
Peter Gromov
104dcb637e a test for IDEA-229705 PIEAE when moving a directory with Java classes into a module with a different language level
GitOrigin-RevId: b6a8e6bb79c0e703014ad8c2b9f8d44d57cfb7b6
2020-06-29 11:57:13 +00:00
Nikita Eshkeev
bfa2410de7 [codeInsight] IDEA-244246 IDEA should take into account Language level for highlighting of preview features
This patch extracts the generator of the since api into a separate method and comment its call out in JavaAPIUsagesInspectionTest#testCollectSinceApiUsages

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: d157dae652aa8ed6e938ba64d13b2802a8fdc897
2020-06-29 11:03:18 +00:00
Roman.Ivanov
e2384f4861 Java formatter: add space after annotation in record component: IDEA-229706
GitOrigin-RevId: 2313c4489dea65b78676d3cc898012c89a6e7cba
2020-06-29 07:32:23 +00:00
Roman.Ivanov
1d2725756c Java formatter: add setting for spaces within record header: IDEA-244728
GitOrigin-RevId: fce07de6760107d83fc4794da1eb1c8d1a446ca5
2020-06-29 07:32:21 +00:00
Roman.Ivanov
4bb26e3227 Java formatter: add space between type and name: IDEA-236012
GitOrigin-RevId: 86e6c1297c63a68e458c7e041b3ac4f5930bf9f7
2020-06-29 07:32:18 +00:00
Dmitry.Krasilschikov
3baf4ad7a9 IDEA-CR-58517 add test
GitOrigin-RevId: 62a517900813db777074512087b634297597ad89
2020-06-28 16:35:34 +00:00
Peter Gromov
0a82d02378 completion tests: make incUseCount restart the completion
to reset cached skipper results after the fix for EA-232383 - PIEAE: LeafPsiElement.invalid

GitOrigin-RevId: 3a10913b9403fd132066a2fa710bb08d18a876f6
2020-06-26 19:15:38 +03:00
Nikita Eshkeev
3baa8dcfe1 [codeInsight] IDEA-244246 IDEA should take into account Language level for highlighting of preview features
This patch amends the generator of the since api with the option to filter out the api that was available as a PreviewFeature in one JDK but got @since in a different one.

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 03dff7f5d99cd44572f77895991faabf284f400b
2020-06-26 15:50:01 +03:00
Vladimir Krivosheev
d4e9b09e26 cleanup (final)
GitOrigin-RevId: 93607e195763f2acf29ee0d7a280d7e07e8d2f14
2020-06-26 12:21:17 +03:00
Nikolay Chashnikov
83c3795b4e [workspace model] store mapping from LibraryEntry to Library in ExternalEntityMapping
This way we don't need to store mapping based on library names of IDs and update these mapping when libraries are renamed. FakeLibraryEntity is also not needed anymore. LibraryOrderEntry::getLibrary resolved the library by its ID, and there is no need to store reference to module-level library explicitly.

GitOrigin-RevId: 51ed2b5f3cc23db6ac3fc6ae3e7c4834dd3c79a6
2020-06-25 20:01:36 +03:00