Chris Lemaire
6973541acc
[gitlab] Fix the merge button (IJPL-158743)
...
#IJPL-158743 Fixed
The first commit in a reversed list turned out to still be the first commit.
Sadly, the latest commit was needed, not the first.
Using the diffRefs HEAD SHA seems more appropriate than guessing
the ordering of the list in this case.
GitOrigin-RevId: a39e5c5da7065c01ce4c0721abf5cd38b67b3e6f
2024-07-30 14:12:16 +00:00
Vladimir Krivosheev
398ebce1d5
split content report
...
GitOrigin-RevId: ef449bdf4c5480a6ee3ce43b4af118c2c6e31219
2024-07-25 19:20:06 +00:00
Alexander Lobas
932f2d438e
Swap icon path parameters: move expUI path to the first place
...
GitOrigin-RevId: 74cf09fb454c89b676be259cdd7437a81ac4c067
2024-07-25 15:12:07 +00:00
Ivan Semenov
dd5d76a359
[github] signal details reload when corresponding remote branches hashes are changed
...
#IJPL-157530 Fixed
GitOrigin-RevId: 81eea57d5fa3e6bdb1388362f3771187d4715e87
2024-07-08 12:40:55 +00:00
Ivan Semenov
4594cb907a
[collab/gitlab/github/space] make a global action for adding a review comment in the editor
...
#IJPL-82567 Fixed
GitOrigin-RevId: 2e37c01ec7295e6a680514df58cf9f67793eb344
2024-07-06 00:18:25 +00:00
Ivan Semenov
d23df10ad7
[gitlab] rework the project data model class to contain suspending loading methods instead of flows
...
GitOrigin-RevId: 9ddd15f86bfbcc277fbb256436689dca704d040a
2024-07-06 00:18:25 +00:00
Ivan Semenov
97e97cb015
[gitlab] fix scope naming and nesting
...
GitOrigin-RevId: 4abed3663d2e621dd99133a8c716a510a11e4dfe
2024-07-06 00:18:25 +00:00
Ivan Semenov
f284232c19
[gitlab] only search for open MRs when checking existing before creating a new MR
...
#IJPL-81309 Fixed
GitOrigin-RevId: 7edd5b9c440ad069917a00a68d813baa65a7058c
2024-07-06 00:18:25 +00:00
Chris Lemaire
cb6292475d
[github/gitlab] Add a check and a status for when conflicts are already resolved locally (IJPL-157615)
...
#IJPL-157615 Fixed
GitOrigin-RevId: 823a3ab7911b5c1a80a77e419d43d17a9cb4cbe2
2024-07-04 15:54:03 +00:00
Chris Lemaire
b92bb73d91
[collab/gh/gl] Camelcase bundle property names
...
GitOrigin-RevId: a635014eef2a3d8a6df2101d05dbe1b68df5a478
2024-07-04 15:54:03 +00:00
Ivan Semenov
79ed1f2693
[gitlab] rework push notification customizer checks
...
Don't suggest PR creating for default branch
GitOrigin-RevId: 2e37c43e9fee6bb56b17d6db076f6fda8baa9bd0
2024-07-03 21:44:39 +00:00
Ivan Semenov
38b567defc
[git/github/gitlab] rework push notification repo/account selectors
...
Simplify selector code
Check the current connection first
Show actions if there is no saved selection (#IJPL-73072 Fixed)
GitOrigin-RevId: 7a5fa5c2a5ee23be135ebc7b1ed98be6e0f41c1d
2024-07-03 21:44:39 +00:00
Chris Lemaire
9cbf03fbe4
[gitlab] Split genericConfig into a mapper building function and configurer
...
GitOrigin-RevId: 630f0cb185a1362f370cc81e0fa1d8152abafb20
2024-07-02 22:09:46 +00:00
Chris Lemaire
4077ffa0c9
[gitlab] Disable auto-closing JSON parsers to avoid premature closure (IJPL-157434)
...
#IJPL-157434 Fixed
This should prevent READING_LENGTH exceptions caused by
JsonParsers closing the reader before reading all tokens.
Also, don't check for readiness. `ready` depends on `java.io.InputStream.available`.
But, `available` does not block to check a correct count of available bytes, so
it might return 0 even if more bytes are available still.
Probably best to read to completion regardless of readiness to avoid these errors...
Interesting note: if we use `.factory` instead of the method on `mapper`
the configurations from `genericConfig` will not be applied to the parser created.
GitOrigin-RevId: 99ff0728d1c33f59e04cf33c5c34e452b8c41d97
2024-07-02 22:09:46 +00:00
Chris Lemaire
b8b1a9f412
[gitlab] Fix slow and wrong discussion list loading (IJPL-157270)
...
#IJPL-157270 Fixed
The list was loaded from back-to-front, which
the list loader did not account for.
GitOrigin-RevId: e51e1f0384c31c522f2420ca6904e0cb9f5f5816
2024-07-02 22:09:46 +00:00
Chris Lemaire
21a47d76db
[gitlab] Rename GraphQL loader: it does nothing with ETags
...
GitOrigin-RevId: 0595b1c415dd5198df510a7b049c1b88b3b12846
2024-07-02 22:09:46 +00:00
Chris Lemaire
a7c0d66b09
[gitlab] Fix re-emittance of reply VMs because of re-emittance of canAddNotes
...
Every time a draft note was added, all reply VMs would be re-published...
This would cause (in my case) 25-ish editors to - one after another - close and re-open.
Not great for performance in a large MR...
GitOrigin-RevId: c0d02182f1c0a1f0bcaffe8b1f829397c0bdc889
2024-07-02 22:09:46 +00:00
Chris Lemaire
a53518affe
[collab] Always push out new pages states from ListLoaders (IJPL-157270)
...
#IJPL-157270 Fixed
If these are not pushed out, a sequence like this will have incorrect results:
1. Refresh the list, 0 pages loaded, list = []
2. Update manually by adding an entry, list = [some_entry]
3. Perform some action on-server that removes the entity, but does not notify IDE.
4. Refresh the list, 0 pages loaded, list = [some_entry]
In the final step, the pagesFlow would not push out the freshly loaded list.
From the perspective of pages that's fine, but the final list is inconsistent and
should always be overridden by refreshes.
GitOrigin-RevId: 631041c137bde50e2fd8ede0d3f1dc2d3a83b564
2024-07-02 22:09:46 +00:00
Ivan Semenov
0d8492341d
[gitlab] fix changes selection loop
...
The crux of the issue was that the data was incorrect.
UI events should be handled synchronously until the "single source of truth" is set and then that state can be propagated asynchronously.
That was not the case for tree/diff selection handlers. Selection updates were handled asynchronously which sometimes caused an updated loop while trying to synchronize two states.
#IJPL-77514 Fixed
GitOrigin-RevId: fa0e860bd893f10e09e11af49547b3844c31fd35
2024-07-01 11:25:22 +00:00
Ivan Semenov
3949e487a6
[gitlab] match account with git url by host in interactive auth data provider
...
GitOrigin-RevId: 08b117d2dec90370bac15ee9d854bd81788e764e
2024-06-27 11:45:52 +00:00
Ivan Semenov
3de8125754
[gitlab] fix the order of git auth providers
...
GitOrigin-RevId: 6b5f856d304b017fea15c436972e8d6f0a954a16
2024-06-27 11:45:52 +00:00
Chris Lemaire
96b96a6992
[gitlab] Remove contraction from bundle
...
Follow-up: 33099b68d3c295b97db1228d774a1a8ad18ec4c2
GitOrigin-RevId: 43d77bd2157be4c5e584896110448339bfdd3607
2024-06-25 17:33:46 +00:00
Chris Lemaire
ee64c72314
[gitlab] Add an action to resolve conflicts in an MR
...
GitOrigin-RevId: 33099b68d3c295b97db1228d774a1a8ad18ec4c2
2024-06-25 10:57:15 +00:00
Chris Lemaire
de778ea5e9
[gitlab] Factor out a getRemoteDescriptor extension method
...
GitOrigin-RevId: cf4b040accdb0bafa10c87eb27f11ad677b48d10
2024-06-25 10:57:15 +00:00
Ivan Semenov
e3999f4110
[gitlab] allow patch updates to the bundled gitlab plugin
...
GitOrigin-RevId: 17243f81affbb706a90cd8f9e7028c8f2746d343
2024-06-24 17:40:52 +00:00
Ivan Semenov
9afeeca76a
[collab/github/gitlab] simplify and publish a delegate for code review changes viewmodel
...
GitOrigin-RevId: fb420e20d7919b9ec56175b4ac2ecfacd816dcd4
2024-06-24 16:14:52 +00:00
Ivan Semenov
cb480552af
[collab/git] make an API for current git branch status presenter
...
GitOrigin-RevId: c494d5daac991cb4fc8486c5662a98edad81eb90
2024-06-24 16:14:52 +00:00
Ivan Semenov
1e89d12557
[collab] make an API for review in editor implementation
...
GitOrigin-RevId: f6733adf02d1717f96b16ff72b5b739d4416eadd
2024-06-24 16:14:52 +00:00
Ivan Semenov
308516e9ea
[collab] make an API for showing review in editor toolbar
...
GitOrigin-RevId: a56a101bfaf4aaa8bf93daee1b6e81355faff41d
2024-06-24 16:14:52 +00:00
Ivan Semenov
f6b8f2709b
[collab] make an API for closing code review files safely
...
GitOrigin-RevId: 34bbf1743122478e7a616c54373ab36f99ee5686
2024-06-24 16:14:52 +00:00
Ivan Semenov
ec8d5fcae8
[git/github/gitlab] extract some git calls to a common place
...
GitOrigin-RevId: 1c217cc3b5e3b99740b186561c58891a9b2fa972
2024-06-20 18:20:56 +00:00
Ivan Semenov
5ce86532d3
[collab/gitlab/github] prefer plugin project scope over orphan scope
...
GitOrigin-RevId: cfb4559bd6b8f27a872a65a4fc33ebedcc143eaa
2024-06-19 16:21:22 +00:00
Ivan Semenov
33efa38a45
[collab/gitlab/space] drop MigLayout from public API
...
GitOrigin-RevId: 7c56590ca043d3967fb9b1003c62a801fb45af81
2024-06-19 16:21:22 +00:00
Ivan Semenov
249b252528
[gitlab] trim status lines if there's not enough space
...
GitOrigin-RevId: 4d91867b5f2db47b66d19e6140406bf484ca9e0c
2024-06-19 16:21:22 +00:00
Ivan Semenov
34bd6049d5
[gitlab] use proper coroutine scope for clone dialog
...
GitOrigin-RevId: 2139f39078ceaa56824fd7e5d5f86f16b1621b6e
2024-06-19 16:21:22 +00:00
Alexandr Trushev
1e4e505e16
IJPL-797 intellij.platform.editor review internal API
...
GitOrigin-RevId: 514591f43e57749b752d8399d08b2cfd79fb34ea
2024-06-17 22:06:02 +00:00
Alexander Lobas
89d58ee436
IJPL-150231 Move icon mappings from json to icon generator
...
GitOrigin-RevId: 4d4576fc7eeb92ec43c36abec2d62d271b45d9a4
2024-06-15 23:19:46 +00:00
Yuriy Artamonov
fa0bf8c8c2
[fus] IJPL-156483 GitHub and GitLab CI editing statistics
...
GitOrigin-RevId: 78f9d637220e6d6da86d91203dbe7946137eba0d
2024-06-15 13:41:41 +00:00
Ivan Semenov
f4ed53873b
[gitlab] fix infinite reviewers loading
...
GitOrigin-RevId: e8e0c3e85921ce582d52cc63f8cf5b0a2df627e5
2024-06-10 12:39:38 +00:00
Chris Lemaire
901e51c98a
[collab/gitlab/github] Stop using flow-based updating if only one static error needs to be shown
...
GitOrigin-RevId: 9bdd077563836dc8887d2904e7889e2fc9820b49
2024-06-03 16:54:44 +00:00
Chris Lemaire
6440ac2be5
[gitlab] Move function to create error status presenter into utility class
...
GitOrigin-RevId: c9c8ef91638261f6d89d1fba9d1520f00349392a
2024-06-03 16:54:44 +00:00
Chris Lemaire
5c446b566b
[collab] Inline error status panel creation functions where possible
...
This gets rid of unnecessary class declarations in favour of a functional approach.
GitOrigin-RevId: e6f5997a2be8b61ad062ed82e52b89db199d8259
2024-06-03 16:54:44 +00:00
Chris Lemaire
ddb00de092
[collab] Add a simple generic instantiation for ErrorStatusPresenter
...
Use this function in places where a subclass was made before.
GitOrigin-RevId: 220c3f2e7778d704d5a09e6a7707480c985f85cf
2024-06-03 16:54:44 +00:00
Ivan Semenov
98beaed419
[gitlab] refresh MR data if necessary when resolving a discussion
...
GitOrigin-RevId: bc172031d87fbbce9ff311f7f0c6ad9892a12139
2024-05-29 17:26:30 +00:00
Ivan Semenov
dea03b1fc4
[gitlab] revalidate MR panel on status visibility change
...
GitOrigin-RevId: f4f2ce344ee0445e689436b6adb139a710b55766
2024-05-29 17:26:27 +00:00
Ivan Semenov
6361a75e42
[gitlab] check MR discussion resolution if mandated by project settings
...
#IJPL-81324 Fixed
GitOrigin-RevId: 34a60f0b9423a5dff4bc01e8f97360c5e7da5e92
2024-05-29 17:26:23 +00:00
Ivan Semenov
2066042988
[gitlab] cleanup
...
GitOrigin-RevId: e3d3bb745edf62f5fb99cd74d1a2858db32d18de
2024-05-29 17:26:20 +00:00
Ivan Semenov
107ccf7a7d
[github/gitlab] replace exception with logging
...
#IJPL-155831 Fixed
GitOrigin-RevId: dc8a16d099d5313aeebf1f7cf5b4201e5d171c49
2024-05-29 17:26:17 +00:00
Ivan Semenov
23f724a13b
[github/gitlab] add logging for review in editor controllers
...
GitOrigin-RevId: d7125d3ef34960095970c8297844ae8ba5a7bb46
2024-05-29 17:26:13 +00:00
Chris Lemaire
d7013bf733
[gitlab] Consider server URIs starting with HTTP/HTTPS the same (IJPL-148811)
...
GitOrigin-RevId: 6de72d9a4260e63bd515ff7ef46d47f20d32eb4d
2024-05-24 15:27:32 +00:00
