Commit Graph

660 Commits

Author SHA1 Message Date
Tagir Valeev
f4a568e5d6 [java-inspections] ExtractMethodRecommender: proof-reading
GitOrigin-RevId: c737ea5a56fbd23097aab81234692d93ff551b39
2023-02-24 11:31:53 +00:00
Tagir Valeev
5f02a4d3ba [java-inspections] ExtractMethodRecommender: proofreading
GitOrigin-RevId: 4dded16ebf9f26f53cdca089f2c5d51ae7fcb98c
2023-02-23 14:40:36 +00:00
Tagir Valeev
5612d67279 [code-inspections] SetInspectionOptionFix: support numerical value; used in ExtractMethodRecommenderInspection
GitOrigin-RevId: d4f587f5f1e280eca12f5b0e0ab48e232ba187f3
2023-02-23 13:14:33 +00:00
Alexey Kudravtsev
9f5b60b0f0 replace some usages of ContainerUtil.set() with immutable sets to get rid of unclear-semantic methods
GitOrigin-RevId: 3ba1266af01d64a228c10df59b18c4ac797c2a9b
2023-02-20 19:11:19 +00:00
Tagir Valeev
7218710d59 [java-inspections] IDEA-313710 Suggest extract method refactoring on code snippets inside long methods
Draft implementation; currently isInternal and turned off by default

GitOrigin-RevId: 9f2d72de70112062929edd33a4bc9f8693f923fb
2023-02-20 15:23:36 +00:00
Alexey Kudravtsev
a09e773338 notnull (in support of IDEA-312632)
GitOrigin-RevId: 2087ada7b8e60291946bf0fc97d1b50367e111a1
2023-02-14 18:00:08 +00:00
Tagir Valeev
e9cd48e8b7 [java-inspections] Proof-reading
GitOrigin-RevId: 90920eb2a514ccbbb8d51f9a2343ba4b32c0ecce
2023-02-14 14:00:37 +00:00
Alexey Kudravtsev
77dc8d93ab codeinsight: convert some private/internal classes to record to simplify code
GitOrigin-RevId: 1820f00e72361868b6748039011c39598a82655b
2023-02-07 19:32:27 +00:00
Alexey Kudravtsev
1cf8b386de avoid calling PsiFile.isValid in EDT to fix EA-659462 T: DirectoryIndexImpl.getInfoForFile
GitOrigin-RevId: f28dc9a0dc12bbd5284646b025de7ce72e06682f
2023-02-03 17:18:10 +00:00
Roland Illig
be60ef5f33 Clean up Javadoc of JvmElementActionsFactory
GitOrigin-RevId: f5c08b95076b451cb63493491bf0d6af6fbf7150
2023-02-03 06:30:12 +00:00
Tagir Valeev
e9832acb26 [java] Use pattern variables; other minor cleanup
GitOrigin-RevId: e2345bd54d92f6676c6fbc55955e85cbdc5c2793
2023-02-01 17:09:26 +00:00
Anna Kozlova
6aa468aabd [kotlin] move to more appropriate bundle
GitOrigin-RevId: 95ad0451aaf13935d1296f4039ccdecb8ab9126e
2023-01-24 17:13:55 +00:00
Anna Kozlova
6bdb09bae5 [kotlin] explicitly execute potentially slow override/implement search under progress (KTIJ-24371)
GitOrigin-RevId: 9a47fa8a9a622353e34cfd0e9ca0d04bb07429a0
2023-01-23 18:12:26 +00:00
Nikolay Chashnikov
c1f2c8a692 cleanup: remove redundant '@author' tags from javadoc comments - 9
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: fcf3f973d7c945698016443c015023e73ac71572
2023-01-18 17:01:54 +00:00
Daniil Ovchinnikov
578eaaf60e rename library kotlin-stdlib-jdk8 -> kotlin-stdlib
GitOrigin-RevId: cddf45ccfd5563d3fe209bea62a1c37c94f44ff9
2023-01-10 12:22:34 +00:00
Vladimir Krivosheev
57764d700b mark classes final
GitOrigin-RevId: 6414b6f2119c82c7567987dd30b35cab5491d9e2
2022-12-30 06:58:01 +00:00
Andrey Cherkasov
8b5180c01f [java-inspection] LocalCanBeFinal: pattern variable support
IDEA-309250

GitOrigin-RevId: 649fa4e75d40c911fb24002396ba65542d1fc09d
2022-12-26 13:39:27 +00:00
Andrey Cherkasov
608c99ed4d [java-highlighting] Display error if record patterns in for-each loops aren't available (IDEA-309351)
GitOrigin-RevId: 0919de47769682aff2c016920175a74d89c9f7b6
2022-12-26 13:39:22 +00:00
Bas Leijdekkers
86f0b63857 Java: better quick fix texts for "Loop can be collapsed with Stream API" and "Simplifiable forEach() call" inspections
GitOrigin-RevId: c4db6507c258e5611f6d47b9373a0c2531802345
2022-12-23 13:26:29 +00:00
Andrey Cherkasov
7bf9474dac [java-highlighting] Provide quick-fix for the "Package annotations should be in file package-info.java" error
IDEA-216254

GitOrigin-RevId: 9d8c4074babff861b5702caa09dd320de5d63d72
2022-12-22 15:59:18 +00:00
Tagir Valeev
1f14021ad5 [java-inspections] VisibilityInspection: OptPane
GitOrigin-RevId: 881f40c6f944eed3d80df25d95e99c7cf9d0ec35
2022-12-19 20:05:53 +00:00
Tagir Valeev
3fc334a23a [inspections] Improve OptDropdown; use in ConstantOnWrongSideOfComparisonInspection, ParametersPerConstructorInspection
GitOrigin-RevId: a89fe782d0c462e7dacf65c6f6eddde9ce332d1f
2022-12-14 18:37:50 +00:00
Bas Leijdekkers
c19f14ef94 global inspections: rename registry key and remove obsolete registry key
GitOrigin-RevId: a612f123413ddacf09fb47dfc670f5ff03dc5396
2022-12-01 00:13:14 +00:00
Bas Leijdekkers
a6e0a31447 global inspections: minor optimization
GitOrigin-RevId: f80c17fd8cba7dd5434a3caf11c48611239016ae
2022-11-30 11:20:12 +00:00
Andrey Cherkasov
8d8c2f125d IJ-CR-98117 Fixes after review
IDEA-298829

GitOrigin-RevId: 973ebc9ea23341ac96d42fe79385d6fb32679f36
2022-11-15 16:51:00 +00:00
Andrey Cherkasov
2b7e0f0708 [java-highlighting] Incorrect number of nested patterns: provide quick-fixes if it is possible
IDEA-298829

GitOrigin-RevId: 7a7da446d502a89ba3040e3558929bd918111de9
2022-11-08 17:52:21 +00:00
Alexey Kudravtsev
6a373228b7 IDEA-305450 HighlightInfo must be shown immediately
Change HighlightInfo.Builder API to add "registerFix" method;
Port (almost) all usages of the old HighlightInfo.registerFix() to the new API;
Display HighlightInfo immediately after it's added to the HighlightInfoHolder in GeneralHighlightingPass to reduce latency between creating various HighlightInfos and showing them onscreen

GitOrigin-RevId: 9dca70b2198d346bf738895f8373f839b53aa940
2022-11-07 17:45:52 +00:00
Bart van Helvert
50621a78d4 [jvm] IDEA-305464 Add support for changing override
GitOrigin-RevId: 9d6869095aca612a93267b81abf743d70ccbf62d
2022-11-07 15:59:33 +00:00
Konstantin Aleev
3f2c382262 IDEA-217927 [uast] set language display name
GitOrigin-RevId: 38e144d9593f1889afa2e3a69e524c4c7fbdc671
2022-10-18 00:06:14 +00:00
Alexey Kudravtsev
9023b5b416 move ModuleUtilCore.projectContainsFile() call to background to fix EA-659439 T: DirectoryIndexImpl.getInfoForFile
GitOrigin-RevId: 6576011f064b34fe8c3d27c282a89896dbae5209
2022-10-03 16:37:46 +00:00
pyltsin
561e2d81d0 [java-dfa] IDEA-300181 Report when the same stream is consumed more than once.
Co-authored-by: Tagir Valeev <tagir.valeev@jetbrains.com>

GitOrigin-RevId: 929f69d8e22285cae8906761df6b39ec46ce985c
2022-09-30 12:10:32 +00:00
Anna Kozlova
c0d88a703e [java] java 19 is released; update since 19 api-s
GitOrigin-RevId: 60933f28fb32fc98889f9bed31b33d9583de81c0
2022-09-22 20:32:17 +00:00
Bas Leijdekkers
50dda1fccf quick fix name tweak
GitOrigin-RevId: 40f0291b698a357f4cfb2dea429f6b516e105550
2022-09-12 20:49:43 +00:00
Tagir Valeev
24511394c3 [java-intentions] IDEA-301288 Suggest to make variable effectively final moving assignment to the branch without assignment
GitOrigin-RevId: c9953f2df87f2fa35ed97be97e48cd6240ee8fae
2022-09-09 15:06:38 +00:00
Nikolay Chashnikov
07946fb1dd [java] cleanup: remove unused deprecated API (IDEA-295370)
GitOrigin-RevId: c8370b89546b74bf94c6c6d249d7cdd34233c7a4
2022-09-06 12:45:03 +00:00
Andrey.Cherkasov
600967c68e [java-highlighting] Provide Split values of 'switch' branch quick-fix for "Illegal fall-through from/to a pattern" error
IDEA-273885

GitOrigin-RevId: 49ea03660bc8079eb93b76c2ace9264ae1c2cc7a
2022-09-01 09:52:26 +00:00
Bart van Helvert
afd09dde1c [jvm] Code and documentation improvements to Java API inspection
GitOrigin-RevId: 752f3ac5b9bea956323585f75327149582dfbf3f
2022-08-22 15:14:26 +00:00
Tagir Valeev
430cdc18db [java-analysis] JavacQuirksInspectionVisitor: cosmetic
GitOrigin-RevId: c1ea48d2f4c185b8b24736b322b78ed034ba38bb
2022-08-17 18:22:16 +00:00
Tagir Valeev
ce4e1e9bef [java-intentions] IDEA-299879 Anonymous class cannot be sealed: add a quick-fix to convert to inner class
GitOrigin-RevId: fd48ed7596686b652374fa2b1bcceeda7d96e78c
2022-08-12 16:04:29 +00:00
Bart van Helvert
2a3095a5e1 [jvm] IDEA-298984 Fix false positive in Java API usage inspection
Don't report when `@since` tagged API is detected with a higher language level compared to the current SDK level.

GitOrigin-RevId: f7e001d0ac81cba3372159d83fd0084a77cd6f8c
2022-08-09 17:40:08 +00:00
Alexey Kudravtsev
714d26edd8 remove unused method
GitOrigin-RevId: b89f0c7f61bd58f9ed6e9fd15d4981e5227c105f
2022-08-09 12:00:39 +00:00
Tagir Valeev
ff07590cb2 Fix javadoc problems
GitOrigin-RevId: 0329ac7a2caf87296ca8474b3437974361a1505b
2022-08-09 10:55:59 +00:00
Bart van Helvert
2a86552363 [java-inspections] Add quotes to annotations in inspection messages
GitOrigin-RevId: a2d102bb75c6f0f213cfe79928909f8501be6ca7
2022-08-04 13:39:06 +00:00
Alexey Kudravtsev
5145671442 split UnimplementInterfaceAction to two fixes with immutable text for clarity (boolean parameter considered harmful) and for stability
GitOrigin-RevId: 3942585b2071cb81733080dee122913cdac001f1
2022-08-03 08:34:18 +00:00
Tagir Valeev
8a9959167b [java-intentions] IDEA-299075 Better quick-fixes when generic method call has mismatched type
GitOrigin-RevId: 6fa73efcfb43cd7da05f95ef66c2cd40a3dc1a14
2022-08-01 18:23:39 +00:00
Bart van Helvert
342c8033b4 [java-inspections] Improve ChangeNullableDefaultsFix warning message
GitOrigin-RevId: c1a55bc8cd7249425fac57493487413b044a4cb0
2022-07-29 14:24:29 +00:00
Bart van Helvert
780a373547 [java-inspections] IDEA-298846 Add preview to ChangeNullableDefaultsFix
GitOrigin-RevId: 785aaba03830dc91498d384f03800d191c089bcb
2022-07-29 14:24:26 +00:00
Bas Leijdekkers
50350c4170 Java: improve inspection messages
for "Duplicated delimiters in 'StringTokenizer'" inspection

GitOrigin-RevId: 1c6b058704b9d612b058f774d779dc9eca6f48ac
2022-07-25 12:19:28 +00:00
Dmitry Gridin
5e1fade9d2 [java] MarkerType: fix i18n capitalization
GitOrigin-RevId: e0284bbf8928ed1ead4419915180fcac7309f133
2022-07-21 12:10:28 +00:00
Bas Leijdekkers
f0f3f4098c Simplify unsupported features warning
GitOrigin-RevId: 5295c833018bbbc23f8087ae52edcb7702aa8e0b
2022-07-18 23:37:50 +00:00