Commit Graph

58876 Commits

Author SHA1 Message Date
Tagir Valeev
0a7c79a9b8 [java-intention] IDEA-355627 Insert semicolon action fails in injection
GitOrigin-RevId: b43046d97bb73f7fa17eedef5575271b7ddbf28f
2024-06-28 17:23:07 +00:00
Tagir Valeev
e35d04820c [java-refactoring] IJPL-157516 T: InlineUtil.inlineVariable
GitOrigin-RevId: 89f3781736ca0f67437538878c26174286657973
2024-06-28 17:23:07 +00:00
Bas Leijdekkers
db923128c6 Java: take care to avoid calling a different method when converting static method to instance method (IDEA-275602)
GitOrigin-RevId: 644b0312256a7cd2859f18ba261bfc83addfb672
2024-06-28 17:14:56 +00:00
Bas Leijdekkers
a17097bea4 Java: no "this/new ClassName()" option for enums and implicit classes (IDEA-330992)
for "Convert to Instance Method" refactoring

GitOrigin-RevId: a353f19d817616c5445da3f7c60aa0a2f46ec155
2024-06-28 17:14:56 +00:00
Bas Leijdekkers
fb700afa0e Java: don't warn about infinite recursion on red code
GitOrigin-RevId: b136b315a1213d2526581b7281bbc81161dfb57e
2024-06-28 17:14:56 +00:00
Bas Leijdekkers
6916b6b005 Java: better error message when there are more arguments than parameters (IDEA-336129)
GitOrigin-RevId: a17a5f0f3878b9baf211737a614d1aa1a5103d31
2024-06-28 17:14:56 +00:00
Eugene Zhuravlev
9918b9e892 JPS: support java17 sealed classes in incremental analysis
GitOrigin-RevId: b444675d623ff5138bf596225d642d80f0244cbf
2024-06-28 16:57:48 +00:00
Egor Ushakov
14f97e2a1f [debugger] made DebuggerCommandImpl.action not abstract
GitOrigin-RevId: 7ba289df8f72fa586cc0916021e1ce98167f9bed
2024-06-28 16:57:34 +00:00
Egor Ushakov
aa2343c112 [debugger] restored async stack traces
GitOrigin-RevId: 379113ab94e0c16e70441caa3d56a0485cf0e465
2024-06-28 16:57:34 +00:00
Tagir Valeev
aa035a99ca [java-inspections] LambdaToAnonymousFix: tolerate incorrect state
It was not checked in the same RA that the state is correct
Fixes EA-1003038 - T: LambdaCanBeReplacedWithAnonymousInspection.doFix

GitOrigin-RevId: e53a448587e698a9984bf3bc25a7ac177d86be08
2024-06-28 16:52:24 +00:00
Tagir Valeev
229eff0461 Raw type and other warnings fixed
GitOrigin-RevId: cde52de8987d2a995c4d2861f3b77356d79f3dd4
2024-06-28 16:52:24 +00:00
Tagir Valeev
2909ce4932 [java-intentions] RemoveAllUnusedImportsFix: support static imports; tests
Fixes IDEA-353352 "Remove unused imports" does nothing for static imports

GitOrigin-RevId: ae20983342012414568af9ca68db67994832443c
2024-06-28 11:03:18 +00:00
Egor Ushakov
b103326863 IDEA-354542 Slow frame location resolve blocks the debugger
Rename methods

Fix debugger process await

Force stop debug process in tests

Do not create additional thread

fixing tests: wait for the debug process to stop

Test hotfix: await debugger thread complete

Introduce DebuggerCompletableFuture

fixing tests: do not rely that much on invokeRatherLater

fixing tests: command cancel may happen off debugger manager thread

added experimental annotations

Add DebuggerDispatcherTest

removed debugProcess param

reduce methods visibility

Call continuation in case of command cancellation

Fix test: call continuation in any case

Clean up

Unify invokeWithChecks

introduced onSuspend

Invoke resume in tests only after all commands complete

[debugger] IDEA-354542 Remove unused constructor parameter

Close test debugger manager thread on dispose

Close debugger manager thread in tests

Add extra check to the continuation set

Fix project leak in test, set up test disposable for DebuggerManagerThread

Launch single command once

Fix API test

Fix test: request source position from debugger manager thread

Clean up code

Clean up command scope creation

SuspendContextCommand logic should be skipped on coroutine resume

cancel coroutine scope in finally block

handle command cancellation

Rename .java to .kt

Fix read action

Start as completable future

Run with commands

Use coroutines in FileApplicabilityChecker

handle exceptions like before

Launch with dispatch

make internal

allow the dispatcher to work without a command in context

renamed debugger thread dispatcher

Add coroutines util functions

Wrap into readAction-s

Extract caching code in CompoundPositionManager

Small code clean up

minimize changes

IDEA-354542 Slow frame location resolve blocks the debugger - introduced PositionManagerAsync


Co-authored-by: Maksim Zuev <Maksim.Zuev@jetbrains.com>

Merge-request: IJ-MR-136324
Merged-by: Maksim Zuev <Maksim.Zuev@jetbrains.com>

GitOrigin-RevId: d78e8514b89afdde6bc710bb322d67ddea6449e8
2024-06-27 20:27:29 +00:00
Tagir Valeev
2854780d0a Fix "ignored result of call" and other warnings
GitOrigin-RevId: 13ffae0c5ef1ea27b7306f4b0cc5386369717734
2024-06-27 18:57:13 +00:00
Tagir Valeev
edec77df83 [mod-commands] ModOpenUrl command
GitOrigin-RevId: 164a69f1d570e08a8e7af108c24e6c3f312f405e
2024-06-27 18:57:13 +00:00
Alexey Kudravtsev
679a71cd40 wildcardize parameters correctly
GitOrigin-RevId: 1041f4afb9f7970c1f28f79909a5a3a8ed6750af
2024-06-27 15:44:12 +00:00
Mikhail Pyltsin
092062f856 [java] IDEA-354964 Migrate standard descriptors like JAVA_21 to TYPE_USE annotations
- extract tests, which require old annotations
- return old name to method to add annotations

GitOrigin-RevId: c559cea10f942f72d5a19176d3ee808d46ad5dd2
2024-06-27 13:29:33 +00:00
Alex Plate
a5fcf97ba3 [Workspace Model] Move VersionedStorageChangeInternal into the impl subpackage
After the review note in https://jetbrains.team/p/ij/reviews/138027/timeline?chat-panel-active=true

GitOrigin-RevId: 976f2d79906d7b206d308621cfad22b7bd76351d
2024-06-27 11:37:13 +00:00
Tagir Valeev
e9c60004b1 [java-inspections] Result of call ignored: Avoid false-positives in fragments (like debugger evaluation)
Fixes IDEA-355461 "Result is ignored" inspection triggered in evaluate and log

GitOrigin-RevId: e3870ff2b90d9297896caceb3b566098ee324c6d
2024-06-27 11:21:13 +00:00
Tagir Valeev
9b8d299c1e Warnings fixed (i18n+others)
GitOrigin-RevId: 404f67f93b6c8d0df6ed13774791fc2d12b613cc
2024-06-27 11:21:13 +00:00
Tagir Valeev
2f10b5f14d [mod-commands] IJPL-157211 Support creation of binary files via ModCommand
GitOrigin-RevId: abebbf301426d4d66abeadc4b72afa8dfd041f0e
2024-06-27 11:21:13 +00:00
Alexander Lobas
db4181013a IJPL-150231 Move icon mappings from json to icon generator (remove ExpUiIcons)
GitOrigin-RevId: ec563768e3a10df6a758997d6be43bb707a70fe8
2024-06-27 10:30:26 +00:00
Mikhail Pyltsin
0d890a82a0 [java] IDEA-354964 Migrate standard descriptors like JAVA_21 to TYPE_USE annotations
- revert changes in other modules
- delete obsolete comment

GitOrigin-RevId: 656c643184103d5e83409cbec47df1346f22cbd9
2024-06-27 10:17:54 +00:00
Alex Plate
212e81b1ca [Workspace Model] Hide getAllChanges to the internal interface VersionedStorageChangeInternal
Users should not access all changes inside the workspace model and only process the changes that are relevant to their subsystem.

Internal discussion: https://jetbrains.slack.com/archives/G0142J1B20N/p1719324452271479

GitOrigin-RevId: 46bfaa0f41b4d92c7ec525d7505b4ba13c89532c
2024-06-26 21:18:15 +00:00
Mikhail Pyltsin
36f87ac0b6 [java] IDEA-354964 Migrate standard descriptors like JAVA_21 to TYPE_USE annotations
- fix tests
- fixes to show external annotations

GitOrigin-RevId: 79cde38663de10c2985b72e76e98372fef214b20
2024-06-26 20:34:48 +00:00
Mikhail Pyltsin
246f6ab1cc [java] IDEA-354964 Migrate standard descriptors like JAVA_21 to TYPE_USE annotations
- fix NullableManager, when it can't find annotation in type
- fix nullability for `switch`

GitOrigin-RevId: c8a369f4ccf07297e520ec837b13cb9dbf49a67f
2024-06-26 20:34:48 +00:00
Mikhail Pyltsin
330ba98e01 [java] IDEA-354964 Migrate standard descriptors like JAVA_21 to TYPE_USE annotations
- fix NullableManager, when it can't find annotation in type

GitOrigin-RevId: 121927429534971abb4a50d1f670afbed9384045
2024-06-26 20:34:48 +00:00
Mikhail Pyltsin
638393e895 [java] IDEA-354964 Migrate standard descriptors like JAVA_21 to TYPE_USE annotations
GitOrigin-RevId: d13187d41d214bd2ccadecb4cadc925f7d787d60
2024-06-26 20:34:48 +00:00
Bart van Helvert
2fb679f5e4 [java] Remove test runner icon hiding for classes with only disabled tests
This feature can cause confusion to users, didn't work correctly and if implemented correctly can be fairly expensive to compute so it was decided that it was better to remove it. #IDEA-355402 Fixed

GitOrigin-RevId: 38e4fb787c41a55967811de9994708459da5e778
2024-06-26 18:23:10 +00:00
Bart van Helvert
a67965fce8 [java] Support go to test for implicit classes
#IDEA-353532 Fixed

GitOrigin-RevId: 5692c6d30579b3ca48aa875220a343c1040bbd6b
2024-06-26 18:23:10 +00:00
Bart van Helvert
0232d76e56 [java] Implement getName for implicit classes
GitOrigin-RevId: 069362cff5ebee9eaf5e75d566097a2deaed8e8f
2024-06-26 18:23:10 +00:00
Bart van Helvert
7a3729260a [java] Make implicit class index final
GitOrigin-RevId: 053e62b390ad3835b64295214551ae9b5fc1f24e
2024-06-26 18:23:10 +00:00
Aleksey Dobrynin
f3c3d74a8e [java, jigsaw] fix: flaky test. the test needs a read action IDEA-353200
GitOrigin-RevId: 4ebdc4ef92b9a1c317a0480533ced694a9714d05
2024-06-26 16:22:25 +00:00
Mikhail Pyltsin
42968dfc2f IJ-CR-137825 [java-typing] IDEA-354366 close braces after switch rule
- support multiline case rules

GitOrigin-RevId: 8c5dd5a3c4cb6b699c565ef39c2c29deacffc7e2
2024-06-26 14:34:55 +00:00
Alexey Kudravtsev
a0f3cf4983 rename for clarity
GitOrigin-RevId: b54d94a8ad8fd26010e9a57f9ee71ff9bff33b2d
2024-06-26 14:28:19 +00:00
Aleksey Dobrynin
1b2f919aed [java-intentions] calculate a CircularModuleDependencies in a non-blocking read action IDEA-327659
GitOrigin-RevId: d634f0d0ca5cf944df2f3d9ec92779c2a6edcae7
2024-06-26 14:15:17 +00:00
sergey.vasiliev
71c18c7a81 IDEA-355383 Services should be package-private by default
GitOrigin-RevId: 193b22c92254ca7354821122ac663aed74c16ab2
2024-06-26 13:38:12 +00:00
Alex Plate
8b228031a3 [Workspace Model] Refresh code by getting rid of the deprecated test function
GitOrigin-RevId: 67a80f51df0af4f081b0fd58d87f6cef1c306b08
2024-06-26 12:37:27 +00:00
Tagir Valeev
1ddafbe011 [java-refactoring] IDEA-354116 Make Static refactoring erroneously qualifies calls inside the anonymous inheritor of the outer class
GitOrigin-RevId: 732a36ab1c1577909e66175ac94efc4597121fe0
2024-06-26 11:52:02 +00:00
Tagir Valeev
172b663b9d [java] ExpressionUtils.getEffectiveQualifier: cosmetic
GitOrigin-RevId: ba65a05b1d26c48748044b29f7ff0d83099c8b77
2024-06-26 11:52:02 +00:00
Tagir Valeev
19fb624028 [java] Use PsiUtil.getContainingClass instead of ClassUtils.getContainingClass
GitOrigin-RevId: f8a6abc7358a2c39dc4c50deaabe14c676f0977c
2024-06-26 11:52:02 +00:00
Tagir Valeev
5a32449b23 [java-refactoring] MakeStaticUtil: avoid recursion
GitOrigin-RevId: 705bfd2e37f16133bccaa6a6b27a458e0eccd11e
2024-06-26 11:52:02 +00:00
Tagir Valeev
12ef12d02a [java-psi] UnhandledExceptions: reuse findThisOrSuperCallInConstructor
It works correctly since STATEMENTS_BEFORE_SUPER feature

GitOrigin-RevId: 935a4074d97794232135345b6b8f57fd6465c0c3
2024-06-26 11:52:02 +00:00
Maksim Zuev
7a22187670 [debugger] Fix statistics event name
GitOrigin-RevId: 46cf584a04429cf52667c45e024aa3bf70716bb4
2024-06-26 09:43:07 +00:00
Vladimir Krivosheev
e82400eb49 IJPL-155974 cleanup
GitOrigin-RevId: bd620ecf4a6ded0e385353723bb80b3941280a65
2024-06-26 08:01:10 +00:00
Mikhail Pyltsin
3b8b3f50f4 [java-typing] IDEA-354366 close braces after switch rule
GitOrigin-RevId: 057d759e922903ffca05c1ad6c405f4422e90d26
2024-06-25 19:07:29 +00:00
Vladimir Krivosheev
314683bdb4 IJPL-155974 cleanup
GitOrigin-RevId: 82f959e3edca705548b4e1c22eafc4cf1efa0aa5
2024-06-25 18:42:48 +00:00
Tagir Valeev
180c1fe1e9 [java-dfa] AssertJInliner: partially support contains* methods
GitOrigin-RevId: cb4954a6a869cf11f0741db06560f3f5c2a7b7c7
2024-06-25 18:26:16 +00:00
Tagir Valeev
2c31e99a77 [java-inspections] Use latest mockJDK instead of mocking individual classes
GitOrigin-RevId: 5bdde04b83f4a66e373724bc40ea5d129467bf25
2024-06-25 16:42:40 +00:00
Tagir Valeev
15bb3eb9f4 [java-incomplete-model] Support declared but unresolved exceptions
GitOrigin-RevId: 2e493f1820ce2e676708e191c0ff0b72b4ecaa59
2024-06-25 16:42:40 +00:00