Commit Graph

275 Commits

Author SHA1 Message Date
Konstantin Hudyakov
e490c3693b [IFT] IJOB-589 Fix breakpoint highlighting position
Need to finally find out how to calculate the position of the particular gutter icon :(


(cherry picked from commit bf52157c66a928b65d8dcb646626c6f10554d04f)

IJ-CR-155956

GitOrigin-RevId: 84ed0d545f007df024812a800af769afd3f318c4
2025-02-27 17:58:48 +00:00
Konstantin Hudyakov
dc3e4391fb PY-66050 Add Jupyter module to the Python learning course
It can't be explicitly added to the `PythonLearningCourse` because Python course can exist without Jupyter plugin, for example, in PyCharm Community.

GitOrigin-RevId: 89d30d38fe3a63fc6eec9fe6ff10ca1f4bdf9f6e
2025-01-23 12:12:08 +00:00
Vladimir Krivosheev
56d22a6b8d don't export intellij.xml.psi - update bazel files
GitOrigin-RevId: d32c1dbb965bf356ea3d948cf0ed68727da0b463
2025-01-19 17:03:43 +00:00
Vladimir Krivosheev
4453c70b07 don't export intellij.xml.psi
GitOrigin-RevId: 0186a8f9f878122dbb297ca06f64fa7fd4b2e579
2025-01-18 21:21:04 +00:00
Vladimir Krivosheev
8bd9511e77 cleanup - final and internal
GitOrigin-RevId: c08a53abe9527e19dcbced1b00abb75307f9e95a
2025-01-18 21:21:04 +00:00
Yann Cébron
9428900cd7 [devkit] Resolve action IDs for Activate$ToolwindowID$ToolWindow (IJPL-165055)
remove suppressions

GitOrigin-RevId: 98ae416120a3da1ef1de1567518e9e5af7c1eb5e
2025-01-16 17:48:29 +00:00
Yann Cébron
6d46b77f7e [devkit] inject reference "Action ID" (IJPL-116495)
add injections: featuresTrainer & lessons

GitOrigin-RevId: 910155a2594afa977c55b306fad377b25c412436
2025-01-14 16:06:04 +00:00
Konstantin Hudyakov
c015b73c0d [IFT] Refactor: do not pass non-action ID string in task method that expects an action ID
GitOrigin-RevId: 9530411f521527cc78ded6d98b659e8b6522749e
2025-01-13 17:36:44 +00:00
Vladimir Krivosheev
0bc1cf1557 update bazel files
GitOrigin-RevId: 7320d3eff3aba093692ce66839c720ece6d7c4db
2024-12-30 11:28:24 +00:00
Vladimir Krivosheev
a522f96d66 do not export deps blindly (part 3)
GitOrigin-RevId: 7277ece9ded25f1111febc8dccaba9ac8cc75c21
2024-12-22 20:28:42 +00:00
Andrey Vokin
05f48da550 IJOB-583 PyCharm onboarding lesson broken (at step 16)
After PY-55548 no need to change type hint `object` to `float`

GitOrigin-RevId: d9ba34fb955df644b7892b070dc1f5523db7fce9
2024-12-20 12:24:32 +00:00
Vladimir Krivosheev
98799639aa do not use _test as lib - test targets do not support this
GitOrigin-RevId: f2f49db4294b6a64040dbbd5f1d95e972cbd70a3
2024-12-15 18:32:30 +00:00
Alex Plate
0cf4cd71de [Python Onboarding] There is no need to require a module to open the interpreter settings
Also, silently returning from the function will leave the link non-working, what is confusing for the user

GitOrigin-RevId: 7b0384c5810ab38268420f172c7e3ddbef0d7b15
2024-12-06 10:54:48 +00:00
Vladimir Krivosheev
17916c90f8 libraries -> lib, resources, opt-in, test deps
GitOrigin-RevId: db66ee95dcb0f0553b40c9cc56cd6afed8634cdd
2024-11-27 13:53:42 +00:00
Konstantin Hudyakov
513b928a78 IJOB-26 Do now show Run and Debug lessons in Aqua
These lessons expect that `Current File` run configuration is available, but it is not enabled in Aqua.

GitOrigin-RevId: 0412925c501f3234444702c5f6657078e83d5f30
2024-10-24 14:45:15 +00:00
Ilya.Kazakevich
3689a45984 Python NPW and Add SDK refactoring:
In SDK:
* `v1`: legacy API that should be dropped (but still used by Python Plugin and DS)
* `v2`: slightly better API used both for new project and interpreter settings. Supports DSL UI validation. Must be adopted by DS and Python Plugin somehow.

In NPW:
* `newProject`, `newProject/steps` (aka `v1`) deprecated, used only by DS and Python Plugin.
* `newProjectWizard` (aka PyV3): the right new API to use. Sooner or later will be adopted by DS and Python Plugin

GitOrigin-RevId: c3d49ce95079dc5ba589955381ddfe42326295fd
2024-09-23 21:14:22 +00:00
Ilya.Kazakevich
76865ffa15 Pycharm: next iteration on not to hide errors rally.
No need to return null: throwing exception in case of severe unexpected error is also ok.

GitOrigin-RevId: f8dde3f6d95c08abd97143a5ce3dc9b6eee33e54
2024-07-18 23:23:27 +00:00
Ilya.Kazakevich
ac673868e5 One more iteration to replace null with Result not to suppress errors.
Lots of code returns `null` without any reason. This ill pattern covers errors effectively making it impossible to find the root cause of any problem.

We replace `null` with `Result` to log and report errors.


Merge-request: IJ-MR-139850
Merged-by: Ilya Kazakevich <ilya.kazakevich@jetbrains.com>

GitOrigin-RevId: 7cbb173f672a44a98f24e89e247428ab6e8ca01d
2024-07-18 16:07:28 +00:00
Konstantin Hudyakov
423a4cf421 IFT-573 Fix completion item detection in Python Basic completion lesson
GitOrigin-RevId: 83e1c2575c879fba8732417bd68ca783b52f5c99
2024-07-05 18:36:32 +00:00
Egor.Eliseev
0c73c9eff9 PY-72274 separating content for python core/pro plugins
1. Delete `intellij.python.community.impl.xml` (move content to `PythonCore` plugin). It is necessary to fix incorrect dependencies: `PythonCore`, `Pythonid` include the same module.
2. Fixed dependencies: if some plugin/module needs Python core functionality, then it should depend on `PythonCore`.


Co-authored-by: Vladimir Koshelev <Vladimir.Koshelev@jetbrains.com>

Merge-request: IJ-MR-136158
Merged-by: Egor Eliseev <Egor.Eliseev@jetbrains.com>

GitOrigin-RevId: ce9ed4c17f601ee1ca2b6cf608f4e30fdac1d879
2024-06-19 21:39:24 +00:00
Alexey Merkulov
a73b1e5713 [IFT] Refactoring: extract same logic about showing onboarding feedback
GitOrigin-RevId: 899001a8cd92e7dbe95c2ea1efcb0d00037f1df1
2024-02-27 17:50:22 +00:00
Konstantin Hudyakov
8d397b5b30 IFT-556 Edit the position of debug GotIt tooltips in onboarding lessons
Since the debug toolbar is showing on the left, edit the GotIt tooltips positions to not intersect with tool window stripes.

GitOrigin-RevId: a801c231e87728ae7bf16edfb8135660ef574266
2024-02-26 12:45:37 +00:00
Konstantin Hudyakov
6027da7a0b IFT-549 Enable the Main Toolbar forcefully in onboarding lessons
Previously we have enabled the navigation bar to make the actions of the IDE header visible, but in the New UI it makes no sense. So, we have to enable the Main Toolbar now.

GitOrigin-RevId: cc29207ecc86dd56280556b9a3b43df240acb53f
2024-02-20 18:40:46 +00:00
Konstantin Hudyakov
ff7ceba2fa IFT-555 Refactor: do not modify the lesson variables in the LessonContext
It would be better to get rid of using mutable lesson properties and store mutable lesson state inside the lesson context or something with a clear life cycle. But such a solution requires more work.

GitOrigin-RevId: 1ab2b16a9af2ecc9713f2b77501c68830cb61f33
2024-02-20 18:40:41 +00:00
Ilya.Kazakevich
9d4751f238 [python, ds, jupyter]: Migrate Python support to V2
Layout:

  JPS modules
  `intellij.python.community`
  `intellij.python.community.impl`
  `intellij.python.parser`
  `intellij.python.psi`
  `intellij.python.psi.impl`
  `intellij.python.ast`
  use package `com.jetbrains.python`
  and go to `intellij.python.community.impl` v2 module

  JPS module
  `intellij.python`
  uses package `com.intellij.python.pro`
  and goes to `intellij.python/pro` v2 module

  Both v2 modules (along with lots of others) come with
  `PythonId` (prof) or `PythonCore` (community) plugins

  DS bundles  `intellij.python.community.impl`

  Idea and other Mini IDEs get `PythonCore` or `PythonId` plugin that bundle modules for Idea and mini IDEs

GitOrigin-RevId: 98f418c52d90d51b9adf3250c561f2c36c767e2d
2024-01-22 20:26:58 +00:00
Ilya.Kazakevich
50f0e2820c Migrate python feature trainer to v2
GitOrigin-RevId: 369e795edac8f6b04634fc7ede78dff431d0bc21
2023-12-21 19:50:08 +00:00
Dmitry Pogrebnoy
c52e01c89c IDEA-338866 Set time scope for feedback collection for onboardings
(cherry picked from commit 0cba21a9137f10365bacb6d998601e570940b0cd)

IJ-CR-121256

GitOrigin-RevId: a90bc9c9ce1c6462c9719ed4ddd305a5e1a44f29
2023-12-11 11:54:11 +00:00
Mikhail Mazurkevich
ef612f90f5 [python] Add KDoc about the classpath for tests
GitOrigin-RevId: e14152ebd88b2fe4496904af728846649c88f32f
2023-11-30 15:53:49 +00:00
Konstantin Hudyakov
1073190fc7 IFT-518 Make Python onboarding lesson and promoter available only in PyCharm Community/Professional
GitOrigin-RevId: 12a710a6e519873c36d750d1967daf9dfe78e84f
2023-11-10 11:21:15 +00:00
Konstantin Hudyakov
c4e0ebbf54 IFT-510 Update text in the Python Editor Coding Assistance lesson
GitOrigin-RevId: f568826e07025f23c97587c219dea064c661da30
2023-11-03 08:05:46 +00:00
Konstantin Hudyakov
f8397c28f2 IFT-510 Use example with shorter warning description in the Python Editor Coding Assistance lesson
GitOrigin-RevId: d61c65000f4438c5fb79299da60967702d141f6e
2023-11-01 20:16:24 +00:00
Alexander Koshevoy
f863964159 Move methods from PyProjectVirtualEnvConfiguration object to top level
GitOrigin-RevId: bf9432e65295730395c5aac697fd26dc91037547
2023-10-23 00:47:08 +00:00
Alexander Koshevoy
2ed8ca951a Reformat PythonBasedLangSupport.kt
GitOrigin-RevId: 818e691d04108969f1ec1dca6ea9d77da42092f4
2023-10-23 00:47:08 +00:00
Konstantin Hudyakov
b3315624bb [IFT] Refactor: extract getCallBackActionId to Utils
GitOrigin-RevId: 798a1d1aaca11f9e5c207d9ea20b01867b91eb32
2023-09-27 13:21:00 +00:00
Konstantin Hudyakov
428ce848ab [IFT] Fix parsing of the callback ID if it is greater than 999
Found that `com.intellij.AbstractBundle.getMessage` applies the formatting to the parameters passed as a `Number`. For example, it translates 1032 int to "1,032" string. And then `toInt` method fails to parse it.
Better to use String value as ID for callbacks to avoid this problem.

GitOrigin-RevId: 95a667a35f6107ec71df0da26892541d1d964b98
2023-09-27 13:20:57 +00:00
Konstantin Hudyakov
c1d2faa12e IFT-482 Fix debugger tool window step in onboarding lessons
GitOrigin-RevId: 04f7e1349d67a30b54cf15dd7b271da146d614fe
2023-07-18 12:29:38 +00:00
Alexey Merkulov
70f44ac83e IFT-474 Fix Java and Python run configuration lessons
GitOrigin-RevId: 464a69b468271921ccfbc896578686da9a462240
2023-07-17 17:28:05 +00:00
Konstantin Hudyakov
f268185a00 IFT-478 Fix Declarations and Usages lesson for Python and Ruby
GitOrigin-RevId: 5b8aacb292c8be1adc7dde27ae807b16936c5dc9
2023-07-14 09:17:20 +00:00
Konstantin Hudyakov
bc56e3da3b IFT-455 Show GotIt tooltips during editor steps in onboarding lessons
GitOrigin-RevId: 7d7b2c7a32f1e7c1c01b28cd8b6401a38e7b08ca
2023-04-05 17:59:11 +00:00
Konstantin Hudyakov
d3999f2eb9 [IFT] Edit onboarding lessons text
GitOrigin-RevId: c2d0e9f297ab3b34e9670c1d2f91075d4f1817b0
2023-03-14 16:01:02 +00:00
Alexey Merkulov
8edb99ffbc [IFT] Change debugger toolbar highlighting defaults and remove pulsation and inside highlighting from Jupyter onboarding
GitOrigin-RevId: bd157fb57d4f0a52d7bf5d8ccd660c58ad16a1b0
2023-03-02 20:50:43 +00:00
Alexey Merkulov
f9e2be3b62 [IFT] Cleanup and fix hardcoded strings warnings
GitOrigin-RevId: b48d46bdcdc083105d6fe8b57faaa6ea46f4ffe2
2023-02-28 21:07:05 +00:00
Alexey Merkulov
aaea90d631 [IFT] Apply JBUI scaling in popup construction instead of call places
IJ-CR-103403

GitOrigin-RevId: 30b92fe24ca3b54a144fbc0ce4e6ac9adc7180e6
2023-02-24 15:00:53 +00:00
Alexey Merkulov
0291a4ce92 [IFT] Rework Python and Java run lessons and adjust them for the new UI
IJ-CR-103403

GitOrigin-RevId: 88218a3ef100af6592eea13a2ea3ee4c3a8070c6
2023-02-24 15:00:50 +00:00
Alexey Merkulov
bc6abbde05 [IFT] Fix restart icon in Python Debug lesson
IJ-CR-103403

GitOrigin-RevId: 9b97222aa75d755aea1f8018f5548d301cac0f36
2023-02-24 15:00:46 +00:00
Alexey Merkulov
9df774fcda [IFT] Split sample for run and for debug lessons
IJ-CR-103403

GitOrigin-RevId: 35f8b09b22771d9ab32bf20db9a7aed1b0443053
2023-02-24 15:00:34 +00:00
Konstantin Hudyakov
a1edd49d27 IFT-447 Adapt breakpoint highlighting area to new UI
Areas are the same in IDEA and GoLand, but different in PyCharm and WebStorm

GitOrigin-RevId: e73250743d62517efe6ffac89b326b07a9e136d9
2023-02-24 12:43:26 +00:00
Konstantin Hudyakov
061813ac12 [IFT] Adjust debug step in onboarding lessons to new debugger layout
There will be only one variant of the debugger layout in the 2023.1.

GitOrigin-RevId: ee2de2446e0c297b1f1e88e90ef604ad45eaeffc
2023-02-13 12:08:44 +00:00
Alexey Merkulov
d97aa80a08 IDEA-302820 Fix name, layout and forbid customization of run widget in the new UI
GitOrigin-RevId: 7ad8ae11fac2a178bf5aaf2f8d8d3d8b65cb8aa1
2023-02-03 15:36:37 +00:00
Konstantin Hudyakov
ff07e53f99 [IFT] Move findBaseSdks calls to background
There were the exceptions that it should be run in the EDT.

IJ-CR-102100

GitOrigin-RevId: a5195b812dcb79481ed4ef4d81dff315826dec4a
2023-01-31 08:56:24 +00:00