Kirill Likhodedov
b4fb551775
git: simplify: move SaveChangesPolicy to a separate class and convert to kotlin to get rid of boilerplate
...
GitOrigin-RevId: 76e0b525189c6d3aa2684ffa4621d2d5eefbb814
2019-12-28 12:05:19 +00:00
Yuriy Artamonov
804192c10e
T-IDE: introduce IDE for QA Engineers
...
GitOrigin-RevId: d64b06e937fb2ea3fe22850ce0bc0903759b7729
2019-12-27 19:05:37 +00:00
Ivan Semenov
928a950631
[github] Periodically reload details in timeline to show mergeable status
...
GitOrigin-RevId: f35691d2e0291d8382f8b1a466616f427dc54173
2019-12-26 16:03:11 +00:00
Ivan Semenov
5cb51fa189
[github] Rename files to new naming convention
...
GitOrigin-RevId: d81f944fd9884d8b0ae28350ee059cd66f69049b
2019-12-26 16:03:11 +00:00
Nadya Zabrodina
06e9c6466e
git: support getting auth data silently from GitHttpAuthDataProvider
...
* IDEA-211338 incoming/outgoing changes checking always fails for the private github repositories;
GitOrigin-RevId: e513dd7949de944b1ed14b4f1d54c6050be99398
2019-12-25 13:04:47 +00:00
Ivan Semenov
673096fb82
[github] Fix disposal order
...
UI should be disposed before context
GitOrigin-RevId: 7a4db1156d49026c28e1ec70e9bd97dfe0aa5b3f
2019-12-25 12:31:56 +00:00
Kirill Likhodedov
d1e0a52a59
Improve UX of the clone dialog when Git is not installed: IDEA-221692
...
Check Git executable right from the Clone dialog: on opening, and on receiving the focus. If it is not valid, disable the "Clone" button, and display the error. Depending on the OS, propose different ways to fix the error: on Mac start the default Command Line Tools installer; on Windows download the installer from git-scm.org.
Since now there are 3 ways to display and handle Git executable errors (inline in the clone dialog, modal errors from the Test button in the Settings, and notification balloon in other situations), separate the logic of identifying problem into GitExecutableProblemHandlers, and the UI into ErrorNotifiers.
In the inline UI of the Clone dialog, we need a proper ModalityState to modify the UI after executing the background task, especially to do it immediately after showing the dialog. Thus get the ModalityState when creating dialog components, and pass it to VcsCloneDialogExtensions.
GitOrigin-RevId: e71394d024a4bc6288e40d5594f00a0d873b08d3
2019-12-24 14:42:58 +00:00
Ivan Semenov
a83df88068
[github] Use the analog of three-dot-diff for PR diff
...
Synchronize diff implementation with GitHub
Previously non-related changes were included into diff
GitOrigin-RevId: 58ecfc6a9131bc1cf19720a0114ba967cd7509a9
2019-12-16 16:38:08 +00:00
Ivan Semenov
d0793feede
[github] Use two-dot lof notation to load PR commits
...
diff and log dots are different (opposite almost) and we only need unique PR branch commits, not master+branch
GitOrigin-RevId: 1830c74e44160ffa5dc0faafbfc9bec879567968
2019-12-16 16:38:08 +00:00
Dmitry Jemerov
502af96786
Plugin description update from Alexey Zhebel
...
GitOrigin-RevId: 465b3cabdd350317160e739d1458950686f82943
2019-12-11 10:02:43 +00:00
Dmitry Batrak
a06811a018
IDEA-211165, IDEA-228603 new API for gutter line number converters
...
update following IDEA-CR-56319
GitOrigin-RevId: b93421b30bea116efab1fd604037a1eef2e5d49f
2019-12-11 09:07:22 +00:00
Vladimir Krivosheev
a74acba87b
JPA — use ToolWindow.getDisposable
...
GitOrigin-RevId: 42faac19334aff37a438d7b3c0c3d24505ff643c
2019-12-10 14:09:44 +00:00
Vladimir Krivosheev
f022d46f05
cleanup, more reliable and simple unregister implementation
...
GitOrigin-RevId: 63fc12e58f76d3447ed0ed8c8042484d244fe1f6
2019-12-10 13:37:07 +00:00
Vladimir Krivosheev
cf6c546187
cleanup
...
GitOrigin-RevId: 43c4d3a8fd29ff7a03644769452b8760d52d5099
2019-12-09 17:37:56 +00:00
Dmitry Batrak
02cb2f3cbf
migrate off old line-number-conversion editor gutter APIs
...
GitOrigin-RevId: 23aa3fdab69b61e9ab423484815b9437722ea75f
2019-12-09 13:04:47 +00:00
Ivan Semenov
ac14c65125
[github] Migrate to a common editor inlays framework
...
GitOrigin-RevId: ed4432bb94c7199504fe54514f7f150ec837dfc0
2019-12-09 11:37:32 +00:00
Ivan Semenov
0cd3332fe2
[github] Allow un/requesting PR reviews from organization teams
...
GitOrigin-RevId: 66350479267e6f85a9f78185f9c2b87633d93bc8
2019-12-06 13:38:42 +00:00
Ivan Semenov
423a83fe7a
[github] Load and display team review requests
...
GitOrigin-RevId: 8501ec5e117f404b7a4cca6c07d971359cda5bf7
2019-12-06 13:38:42 +00:00
Ivan Semenov
0dfea670b0
[github] Rename file
...
More accurate name
GitOrigin-RevId: 9507488948119c40a7652c1669e1e3450306fe87
2019-12-06 13:38:42 +00:00
Ivan Semenov
aef78b0446
[github] Invalidate data providers when auth token changes
...
GitOrigin-RevId: 0bf1c9f7411b6398561145a0a18aa577b2b1b766
2019-12-06 13:38:42 +00:00
Ivan Semenov
814a9ae451
[github] Handle auth error when loading various PR data
...
GitOrigin-RevId: 2305656463767c1eb772dd07de85226d925c8d51
2019-12-06 13:38:42 +00:00
Ivan Semenov
074487f1dd
[github] Throw a separate exception when GQL query fails because of scopes
...
GitOrigin-RevId: 92c4df3e56433c5179092bbcdeaa0b9a8cf020d3
2019-12-06 13:38:42 +00:00
Ivan Semenov
fcd60ce897
[github] Check token scopes in settings accounts list
...
GitOrigin-RevId: 1656dd13cc92124959d57633fa4dbcf1d516d86e
2019-12-06 13:38:42 +00:00
Ivan Semenov
e0119ba2a1
[github] Rename file to new naming scheme
...
GitOrigin-RevId: 5927e28e533baa2d1931c42e9fd6d4131544b548
2019-12-06 13:38:42 +00:00
Ivan Semenov
06b46cc718
[github] Communicate access scopes information to user when loggin in
...
GitOrigin-RevId: 3678d1c5fa36d1a6da2c81b7a9ac819817afde0b
2019-12-06 13:38:42 +00:00
Ivan Semenov
b40ade8973
[github] Add org read scope to the list of required scopes
...
Teams can be assigned to PR as reviewers and without the scopes we can't even read the name of the team.
GitOrigin-RevId: c8da09b25260a52c3e000a5b09b54560877468ee
2019-12-06 13:38:42 +00:00
Ivan Semenov
bd8464feb0
[github] Rename file to new naming model
...
GitOrigin-RevId: 6e1fe45dd38ef25eaec4b2241e34bf064ef6aefe
2019-12-06 13:38:42 +00:00
Vladimir Krivosheev
bbfcb4331b
ToolWindowManagerImpl - one map for all, cleanup
...
GitOrigin-RevId: 10a77a988eb5bbc3bcbbaac7c5c9e957e6187cbd
2019-11-29 17:32:09 +00:00
Ivan Semenov
013355526c
[github] PR list state icon tooltip
...
GitOrigin-RevId: 7bfd6634a0495931bd7635a200c1c9e654f08ca4
2019-11-29 10:06:00 +00:00
Vladimir Krivosheev
4258b62eb7
1. dispose children of container (it is parent disposable) — using introduced Disposer.disposeChildren. This method must be called only in EDT (nothing changed, it is old contract).
...
2. set container state to `DISPOSE_IN_PROGRESS`
3. Write action started, some container-specific activities performed. All further steps **in** write action.
3.1 e.g. App shutdowns executor service.
3.2 e.g. ProjectManager closes project.
4. set container state to `DISPOSED`
5. dispose services/components (registered using separate disposable as parent) — using introduced special disposable `Disposer.dispose(serviceParentDisposable)`. This disposable is not registered in tree, disposed directly in the PlatformComponentManagerImpl.dispose method implementation.
6. set container state to `DISPOSE_COMPLETED`.
GitOrigin-RevId: 6819347645e1acdf2432fb15ad129b259eeedb9a
2019-11-28 19:36:33 +00:00
Ivan Semenov
efe92f0136
[github] Use provided base and head refs to show PR changes
...
GitOrigin-RevId: c6eb28810ac4dd06be9121eb20888883436a8416
2019-11-25 19:38:16 +00:00
Vladimir Krivosheev
6f359c7a9d
ensure that app is disposed correctly and message bus respect project container state
...
GitOrigin-RevId: d0ed042a9008c0397030694a2984b159dbd2c31b
2019-11-22 21:31:42 +00:00
Vladimir Krivosheev
0fb5b5d4fa
cleanup
...
GitOrigin-RevId: 6fc5a27770df29c3c602d1470d78dcd5f0349a11
2019-11-21 15:44:19 +00:00
Aleksandr Krasilnikov
ea0bf67cfb
github: stop disable directory field in clone dialog to avoid problem with focus
...
GitOrigin-RevId: ea2197478c61b3a5db0cef579950a4bf69003040
2019-11-14 15:53:01 +00:00
Kirill Likhodedov
c861b3871b
git: rename UpdateChangesPolicy to SaveChangesPolicy
...
Property is renamed as well, but it's OK, since shelf is going to be default in the next commit.
GitOrigin-RevId: f8208ec5c9e860242fac1f79d072dc1061186a31
2019-11-13 11:05:42 +00:00
Ivan Semenov
aa656a5d87
[github] Register GH PR refresh actions without changing their shortcuts
...
GitOrigin-RevId: 9179000a9f0bb59003be36e77fffedaef680ac21
2019-11-12 17:12:16 +00:00
Ivan Semenov
86903621fd
[github] Fix type
...
GitOrigin-RevId: 8d599ac0d71b2795266a5aebb14c855f9a87bc66
2019-11-12 17:12:16 +00:00
Ivan Semenov
b978fdeb40
[github] Fix pr details in context too
...
GitOrigin-RevId: c6a2710fea5c004a305881015fc47fe4315928bc
2019-11-12 17:12:16 +00:00
Ivan Semenov
cd2561d759
[github] Do not include newline in commentable range
...
GitOrigin-RevId: 4965f278a1dac7872deb40227501579dc9aa85ee
2019-11-07 17:02:46 +00:00
Ivan Semenov
7155a24915
[github] Fix inlay sizing
...
GitOrigin-RevId: 02c468089520a0ee9bf8bcc6cfa0022d7a8cbae0
2019-11-07 17:02:46 +00:00
Yaohui Wang
c62079c40c
Add SpeedSearch in GitHub PullRequest List
...
From PR https://github.com/JetBrains/intellij-community/pull/1234
GitOrigin-RevId: ec6c9a4c263657e639e46847c7533c2351bfe7db
2019-11-07 17:02:46 +00:00
Alexey Kudravtsev
c6cc9e42b0
cleanup: replace deprecated disposedOrInProgress usages
...
GitOrigin-RevId: f770da13a17a9aa13037edf2230f6415fa248d61
2019-11-07 17:02:46 +00:00
Sergey Malenkov
a659353d59
GithubIcons: remove deprecated icons scheduled for removal in 2020.1
...
GitOrigin-RevId: 61a02bab51c34e024a04e4b1768377ac6e90b3f1
2019-11-07 02:40:58 +00:00
Ivan Semenov
c455971329
[github] Disable PR comment button when field is blank
...
GitOrigin-RevId: 36974da3852b7b7ee3ccacfebeb4606ff6c5873d
2019-11-07 02:40:58 +00:00
Ivan Semenov
b40e846943
[github] Do not fail when loading PR details if review is requested from team
...
GitOrigin-RevId: d4d01a714d7a71ce6bb60df06f1ff1660e294635
2019-11-07 02:40:58 +00:00
Aleksey Pivovarov
9510777b63
ui: extract common class for toolbar label
...
GitOrigin-RevId: ef3ae99e724134b1b80861ebb252550db6ec07b6
2019-11-07 02:40:58 +00:00
Ivan Semenov
f91c68bd1e
[github] Fix PR comment icon gaps
...
GitOrigin-RevId: 5d077220a2a3c4d2c217965473f7862e041e9bea
2019-11-07 02:40:58 +00:00
Ivan Semenov
428e313b27
[github] Fix PR comment text field border
...
GitOrigin-RevId: cdfa575992b539aaffaacd9ecb4089165ac01727
2019-11-07 02:40:58 +00:00
Ivan Semenov
f70c4d77cd
[github] Fix PR timeline width restrictions
...
GitOrigin-RevId: a0d37f4f3d3ac004913b38c1e071dea4e931dea0
2019-11-07 02:40:58 +00:00
Ivan Semenov
6c1fea75ac
[github] rm unused statement
...
GitOrigin-RevId: f6c8effb074617eb87b2a2383da1dc53522799cc
2019-11-07 02:40:58 +00:00