Commit Graph

1638 Commits

Author SHA1 Message Date
Tagir Valeev da9c5dd049 Wrap switch rule statements into block fix (IDEA-202664, IDEA-207059)
GitOrigin-RevId: 184ebf34bd15c46f54685cf06521cee1d903b056
2019-07-02 06:52:16 +03:00
Artemiy Sartakov 8ec9a2e0ce HighlightUtil: suggest fix for cases when method has void return type and return statement value type is unknown (IDEA-216279)
GitOrigin-RevId: 2af7ce37a427c8ec6f5175fc820ec0eecbf719c9
2019-07-02 06:52:16 +03:00
Tagir Valeev a939a18e23 SimplifyBooleanExpression: Fix negation generation for xor case
GitOrigin-RevId: a6072460618ac0a7c6c29f0ad61c0bdde4d52318
2019-07-02 06:52:16 +03:00
Tagir Valeev 0b3fd46151 Simplify boolean expression improvements
1. Add "may change semantics" when side-effect cannot be extracted
2. Use condition reporting (instead of constant value reporting) for non-short-circuiting & and | (fixes IDEA-216245)
3. Use SimplifyBooleanExpressionFix for boolean constant value instead of replace fix.

GitOrigin-RevId: f3e63a75bd92a7305e36fce58bf9e34bdbb03c51
2019-07-02 06:52:16 +03:00
Tagir Valeev 77e2d54bb0 IDEA-216381 exclude non-comparable collection elements (IDEA-CR-48589)
GitOrigin-RevId: 58ab178f4b0c6662a08949c5adbc95fe64b3e770
2019-07-02 06:52:16 +03:00
Tagir Valeev 5907d8eed1 IDEA-216381 Stream.min and Collections.reverseOrder is not simplified to Stream.max
GitOrigin-RevId: 2c91b1cf5b8bc8c3c8beb2a07d65b86654eda425
2019-07-02 06:52:16 +03:00
Alexander Zolotov 391bda1c4b Update color schemes
- support the new Go colors

GitOrigin-RevId: 4ecd779a6ceae3f36b60c6656d9ff819fe844f89
2019-07-02 06:52:16 +03:00
Tagir Valeev ca1d2bed6d Do not suggest computeIfAbsent <=> putIfAbsent conversions if value could be nullable
Fixes IDEA-215931 Incorrect "Excessive lambda usage" warning

GitOrigin-RevId: 13fa8f5d7d283cd7a208053ed0271a644b713391
2019-06-16 08:15:42 +03:00
Rustam Vishnyakov 123242c4b2 EditorConfig documentation test
GitOrigin-RevId: fd52ace3d7a32ecd02c2c5ab90e077967604c15e
2019-06-16 04:03:21 +03:00
Egor Zhdan c1813cfb52 Cleanup: NotNull/Nullable
GitOrigin-RevId: b8e892f32ea84c2115973155dba7127b892cc36e
2019-06-16 04:02:08 +03:00
Eldar Abusalimov 1120c30a56 Merge remote-tracking branch 'origin/master' into eldar/cidr-debugger
# Conflicts:
#	CIDR/clion/src/com/jetbrains/cidr/cpp/toolchains/MSVC.java

GitOrigin-RevId: f3593b526d1870f32b3f1451cab0c6a653e5beb5
2019-06-16 03:01:38 +03:00
Tagir Valeev 13be43ae66 LambdaAndExplicitMethodPair: fixed negations (IDEA-CR-48396); imports in tests fixed
GitOrigin-RevId: 6dcd3aa510e733070f5f942d22ce68250d2c5cee
2019-06-15 07:01:36 +03:00
Tagir Valeev 9366f0ec2a Do not suggest computeIfAbsent <=> putIfAbsent conversions if value could be nullable
Fixes IDEA-215931 Incorrect "Excessive lambda usage" warning

GitOrigin-RevId: 13fa8f5d7d283cd7a208053ed0271a644b713391
2019-06-14 14:20:58 +03:00
Anna Kozlova 91f7445298 constructor reference: don't ignore constructor parameters during method reference inference (IDEA-185578)
GitOrigin-RevId: e836468e05db28157713e9edd3c70382f8ecdebc
2019-06-13 03:15:49 +03:00
Egor Zhdan 39d2d77155 Cleanup: NotNull/Nullable
GitOrigin-RevId: b8e892f32ea84c2115973155dba7127b892cc36e
2019-06-13 03:14:35 +03:00
Julia Beliaeva 3fee046d20 [vcs-log] cleanup RootCellRenderer
GitOrigin-RevId: bba216626193ac756cd133b8ae9bc4e577abea42
2019-06-10 04:10:14 +03:00
Eldar Abusalimov dcaeb8f8c7 OC-4061: ApplicationUtil: Make runWithCheckCanceled() return result
GitOrigin-RevId: 3aa9f23cc5097e644eddf82a4faca669759b4760
2019-06-10 04:09:35 +03:00
Tagir Valeev a67207d6c8 IDEA-215325 Provide "surround with instanceof" fix for possible class cast warning
Also 'assert x instanceof Type' fix is provided

GitOrigin-RevId: 56603a5cb9ce2040525b4147cc8fcabd6f6d7d5d
2019-06-03 09:06:15 +03:00
Tagir Valeev 2ba9a65828 IDEA-167980 Add quick fix to merge two annotations which are not marked as repeatable
GitOrigin-RevId: 6cc5742354b484ea996ec6a0d2bfa29f3013a08a
2019-05-30 12:07:55 +03:00
Anna Kozlova 4b9293e63f fix reference to inner class of generic outer in static context (IDEA-215061)
GitOrigin-RevId: b969c41b3282bf89c4b44da598c7ec408ea8fec5
2019-05-29 23:07:12 +03:00
Artemiy Sartakov f7bbc47fe8 SortContentAction: consider error element as separator between sortable entries (IDEA-214843)
GitOrigin-RevId: cda0be0ead288decd24b5dffe9ed00c327e7b14e
2019-05-29 13:07:50 +03:00
Tagir Valeev c5617ef120 SourceOperation: avoid copying final field to bound variable
GitOrigin-RevId: fd750ded28fac7a89e41c22610298fe9a23cc25b
2019-05-29 11:09:30 +03:00
Aleksey Rostovskiy 185284cee6 get rid of intellij.build.toolbox.litegen parameter and use BuildOptions.TOOLBOX_LITE_GEN_STEP to skip it instead
GitOrigin-RevId: 9aac8ee4ed1ebf2a29de18a238825fafb1ab88f9
2019-05-27 15:08:08 +03:00
Alexandr Suhinin 9215f4240b [duplicates] enable duplicates analysis in PyCharm/WebStorm/PhpStorm/RubyMine
GitOrigin-RevId: 1545b79fdca4888f4b94f47f22703fd37694fa7a
2019-05-27 15:07:30 +03:00
Anna Kozlova 4033fae095 disable create type parameter at annotation position
GitOrigin-RevId: 1d3518ff3bdeac406ee1d033cb203461cab128ca
2019-05-24 13:48:13 +03:00
Anna Kozlova 479cd22854 interface methods: adjust fixes to add/delete body (IDEA-212082)
GitOrigin-RevId: 4ecf568f2b8ed16ec0d11a56feaf2043b244302f
2019-05-23 14:04:56 +03:00
Aleksey Pivovarov 322db66a12 Recover after problematic merge
This commit reverts 65a557bb38f6ac03afa9aabaf02cb8d99fc68a91
                    3f5cfd958d9b6b54393c15983ac94f519c37fe61

GitOrigin-RevId: 8fb8ccbb17d0e217a83f265c185a943b0f5a7ed6
2019-05-03 01:52:21 +03:00
Nicolay Mitropolsky 9b850726ee [uast-groovy] UInjectionHost support
GitOrigin-RevId: 49ec454d1831796fa63b77fdc965f61985bf877e
2019-05-03 01:47:46 +03:00
Vladimir Plyashkun c33e69a545 CPP-16098 - Lags during inplace rename typing
- reverted some of the changes

GitOrigin-RevId: c7c07b80a76c29794ef31e0e916e62f7f302917a
2019-05-03 01:47:14 +03:00
Leonid Bushuev 34be4bbf7d Apply the change from Develar: cleanup - specify UTF_8 charset explicitly
GitOrigin-RevId: 3f5cfd958d9b6b54393c15983ac94f519c37fe61
2019-05-03 01:46:11 +03:00
Vladimir Plyashkun 61a3e18b78 Merge branch 'master' into vplyashkun/inplace_rename_lags
GitOrigin-RevId: aaecc2a32e4e42de827efb45b8df733874a722e4
2019-05-03 01:41:29 +03:00
Leonid Bushuev 970dc0fe32 Remove unnecessary downcasting
GitOrigin-RevId: b91110977db6e5b08d9f4aaffa8496d305d698e2
2019-05-03 01:40:23 +03:00
Vladimir Plyashkun 2d9369d983 CPP-16098 - Lags during inplace rename typing
- changed behaviour in safe way by introducing new method to check that particular expression does not depend
  on committed PSI

GitOrigin-RevId: f5ec732613cdafdcef8a1d48eb8d04135c634047
2019-05-03 01:39:50 +03:00
Leonid Bushuev 338ad6db56 SQL code style per dialect: UI: fix indent editor
GitOrigin-RevId: 3cb00f5c500523717c42f404b2f38fd1822d6db0
2019-05-03 01:39:18 +03:00
Vladimir Plyashkun d990d75dba Merge branch 'master' into vplyashkun/inplace_rename_lags
GitOrigin-RevId: 5c7f8c478e7328df1646879ede977efd7465adf8
2019-05-03 01:38:45 +03:00
Vladimir Plyashkun e3ca319824 CPP-16098 - Lags during inplace rename typing
- call `commitDocument` explicitly in cases when `calculateQuickResult` can redirect it's calculation to heavy `calculateResult`

GitOrigin-RevId: 41f0c47c57f4528d7d7a25208024ec28bb8c2e12
2019-05-03 01:38:12 +03:00
Leonid Bushuev dc1a52762e SQL code style per dialect: UI
GitOrigin-RevId: 9b1b3e745d4c8acef5a4a1018714e004e5423519
2019-05-03 01:37:38 +03:00
Vladimir Plyashkun d712ac9901 CPP-16098 - Lags during inplace rename typing
- removed `commitDocument` call when `isQuick` argument is passed
- pass `element` or `null` to `equalsToText` call (since there is not real need to take it for text comparison)

GitOrigin-RevId: 27c5e1a2f484fc56d41dfd210832ae94c9a9b7ab
2019-05-03 01:37:04 +03:00
Leonid Bushuev 9f35a30458 SQL code style per dialect: UI
GitOrigin-RevId: 72cca4d6a23a5e2aa2089c03932ab2e9d08bfa48
2019-05-03 01:36:24 +03:00
Tagir Valeev 61ac76cf48 IDEA-211702 Incorrect inspection "Can be replaced with single expression in functional style" when types differ
GitOrigin-RevId: 4006edb212486fa38b31b26ecbed881e6079f6e6
2019-04-29 13:28:39 +03:00
Anna Kozlova d3928de54b change method return type: avoid changes in hierarchy when assignable (IDEA-209931)
GitOrigin-RevId: 43166bdd806d2a0b6ed2e72e6630c9cf53fba7b4
2019-04-28 19:25:11 +03:00
Tagir Valeev 3368f8e2d5 ParenthesesUtils#removeParensFromPolyadicExpression: check operand validity
As processing the previous operands may completely rewrite the whole polyadic expression, we have to stop if this happens
No need to find the replacement and process the tail: it's already processed in removeParensFromParenthesizedExpression
Fixes EA-141996 - PIEAE: CompositePsiElement.getContainingFile

GitOrigin-RevId: 64162346a612e2d95eec426419bef51d6c5d46a3
2019-04-28 17:44:13 +03:00
Anna Kozlova 38f5055d00 replace type with var: allow anonymous type replacement (IDEA-210534)
though interface to implementation replacement may lead to implementation type propagation, anonymous type can't be propagated so it's safe to be used as var

GitOrigin-RevId: cae306614efcb92551f2aa907f8d66e1bd2db930
2019-04-28 16:02:06 +03:00
Tagir Valeev 9af3284048 StreamToLoopInspection: simplify getEffectiveQualifier usage; support unqualified Iterable.forEach, Map.forEach
Review ID: IDEA-CR-46452

GitOrigin-RevId: 7622f0f1274d9f23bfaef88096b3eedd2b4d18a6
2019-04-28 14:53:13 +03:00
Tagir Valeev 723c055455 FinishMarker: use the first movable value when mayNeedMarker is true (may generate shorter code) 2019-04-19 15:02:32 +07:00
Tagir Valeev 179a83f60e TrivialFunctionalExpressionUsageInspection: support parentheses for anonymous class 2019-04-19 11:55:23 +07:00
Tagir Valeev e13567df50 Better comment handling in ternary->if conversion & stream-to-loop 2019-04-19 11:45:55 +07:00
Tagir Valeev 9e1982a819 ExpressionUtils#getQualifierOrThis -> getEffectiveQualifier, nullable now (cannot construct this expression for outer anonymous class)
Fixes EA-140652 - assert: JavaParserUtil.parseFragment
2019-04-18 13:04:43 +07:00
Tagir Valeev e0d1fab43d ConvertToSingleReturn: default return value tuned; define it always before actual conversion 2019-04-12 17:19:54 +03:00
Tagir Valeev cb2e86701d IterableUsedAsVararg: fixes according to review IDEA-CR-45949 2019-04-10 14:49:18 +07:00