Tagir Valeev
f2cfc536e6
[java-inspections] ObviousNullCheckInspection: disable for methods that don't return the parameter
...
Even if the return value is not used, it's subject for IgnoreResultOfCallInspection to report it (as we consider only pure methods). It could sometimes be suppressed (e.g., inside assertThrows), in which case it's desired not to report anything.
Fixes IDEA-368213 False positive and code-breaking autofix for ObviousNullCheck
(cherry picked from commit 0ab2fd64b8a8f8599920cffad76fc830790f8269)
IJ-CR-156868
GitOrigin-RevId: cda30602e0c2af93f21a33501f7ad855b89fda1c
2025-03-10 22:29:02 +00:00
Tagir Valeev
4abe8788e2
[java-core] JavaPsiSingleFileSourceUtil moved to codeserver.core
...
GitOrigin-RevId: 2368062535cd331747a871d22f405e4683ae8bd6
2025-02-18 09:36:18 +00:00
Tagir Valeev
6fc7a8b6e5
[java-core] Split JavaServiceUtil
...
JavaServiceProviderUtil -> codeserver.core
JavaServiceLineMarkerUtil -> java-impl
GitOrigin-RevId: 65c42cdce19ab257ffd18143cc32ff4bd4aeacf7
2025-02-11 18:46:42 +00:00
Tagir Valeev
291c3cfbd9
[java-modules] More code moved to JavaPsiModuleUtil from JavaModuleGraphUtil
...
GitOrigin-RevId: 0a0e7d4bc713deb3d1d55857873c1f708da7a2af
2025-02-11 09:57:16 +00:00
Tagir Valeev
178b721cf7
[java-highlighting] Preview warning migrated
...
Also improve reporting, different messages for errors and warnings; reflective preview use reported by inspection
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: d7c85058aed3202d0599fc879a61c0fa56388fea
2025-02-10 14:02:54 +00:00
Vladimir Krivosheev
154e1b1445
update bazel files
...
GitOrigin-RevId: fdb2c5a8fbaaa72b4fba7053f4178f89e2ff48d5
2025-02-08 11:42:47 +00:00
Tagir Valeev
9b9ed3498f
[java-core] Move JavaPreviewFeatureUtil to codeserver.core
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 79db63637514eef45284a8535d8fa8d9bad129f7
2025-02-07 16:16:33 +00:00
Tagir Valeev
0e57ef0ef0
[java-core] Extract JavaPsiModuleUtil with minimized dependencies; new module intellij.java.codeserver.core
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 328779172e877b737a68624fa09ea88cf5fd1954
2025-02-07 16:16:32 +00:00
Tagir Valeev
5496aa647b
[java-highlighting] Refactor PreviewFeatureUtil
...
Get rid of visitor, simplify API
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 5f5cb37eb2d394fca36f5da72563321ceff8a5b5
2025-02-07 09:33:44 +00:00
Daniil Ovchinnikov
feb324866d
IJPL-176959 explicitly use deprecated Query.asIterable to raise awareness
...
GitOrigin-RevId: 5a2122d583775c3a30670058b6b292fa99b639dc
2025-02-06 16:14:45 +00:00
Tagir Valeev
cc643a5ae4
[java-highlighting] More control-flow-related stuff migrated
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 3c292fdf4869e6d13c16fabbf42e2055ea54f724
2025-02-06 10:35:32 +00:00
Daniil Ovchinnikov
be50661e02
IJPL-176959 explicitly use deprecated Query.asIterable to raise awareness
...
GitOrigin-RevId: b2f3837f13e2960929ac08b9f7de7aa0545086b4
2025-02-05 18:52:54 +00:00
Tagir Valeev
a98ba9ff92
[java-highlighting] More control-flow-related stuff migrated
...
Public methods from HighlightControlFlowUtil moved to ControlFlowUtil
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 64fa78391b02f9dec3d9f2410e764c8b8e479ea6
2025-02-05 11:59:05 +00:00
Tagir Valeev
ef36073f24
[java-highlighting] Some control-flow-related errors migrated
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 436eb256cb9c7f4fb4648472d369b99b63c2f8a9
2025-02-05 11:59:05 +00:00
Bas Leijdekkers
bd5e9ca16b
Java: make "Field can be local variable" Flexible Constructor Bodies aware (IDEA-364189)
...
GitOrigin-RevId: 370bf973497cc428ff1fa8047684c62e793941be
2025-02-05 10:21:50 +00:00
Bas Leijdekkers
66ec4c832d
Java: remove one more unnecessary method override
...
GitOrigin-RevId: 13fb46978e5ec6db023ee2abc007a3f8cddb6b90
2025-02-04 14:01:33 +00:00
Bas Leijdekkers
6082a8c4eb
Java: fix false negative on anonymous class argument (IDEA-352287)
...
for "Field can be local" inspection
GitOrigin-RevId: 6343d49ea97183f67765966bf05108c80a4d3094
2025-02-04 14:01:33 +00:00
Leonid Shalupov
e4e5753846
housekeeping: remove unused imports
...
GitOrigin-RevId: ccba6d05260f5eb551ffa87e0d8a38dc93148a3a
2025-02-04 11:00:15 +00:00
Bas Leijdekkers
5e1d5bb3cb
Java: FieldCanBeLocalInspection and ParameterCanBeLocalInspection cleanup
...
GitOrigin-RevId: 7d8a546460e510fd98933c9cd36749c0706a7c5b
2025-02-03 20:43:02 +00:00
Bas Leijdekkers
08e320c3ff
Java: remove unnecessary inspection method overrides
...
GitOrigin-RevId: 878fd2d520734fb839f798d52553a96ac07bb656
2025-02-03 20:43:02 +00:00
Bas Leijdekkers
9e54c0017f
Java: create final local variable when configured (IDEA-366908)
...
for the "Convert to local" quick-fix of the "Field can be local" inspection
GitOrigin-RevId: f82f38ca4c6eda299519eef80e6a90aa8d4b2f68
2025-02-03 20:43:02 +00:00
Bas Leijdekkers
c12a98fd10
Java: extract common code to ConvertToLocalUtils utility class
...
GitOrigin-RevId: 03c91bad0baa7396daa38489ada7c3014c99fb20
2025-02-03 18:41:33 +00:00
Vladimir Krivosheev
ca3554a3e4
IJ-CR-153713 reduce visibility for findUsages - should be public, but due to backward compatibility use protected
...
GitOrigin-RevId: 4ddc77e9f88cc288dae206802fe026f016980476
2025-02-03 15:01:10 +00:00
Tagir Valeev
00ce24a9b2
[java-inspections] Avoid non-counter limits with joining terminal
...
Fixes IDEA-362807 Incorrect result from "Collapse loop with stream 'collect()'" action
GitOrigin-RevId: 61c75668bb85f662222f97026511c4f6f10176c1
2025-01-31 19:13:18 +00:00
Vladimir Krivosheev
fe1a54bdc4
IJ-CR-153713 revert visibility to public
...
GitOrigin-RevId: 3ffb861b24257050035ccc6076716eab4b321dd4
2025-01-31 16:57:19 +00:00
Vladimir Krivosheev
f1121010f7
cleanup (final, visibility)
...
GitOrigin-RevId: 8faa58a751c19a553c1ba09763e56795cb36ed38
2025-01-31 08:55:04 +00:00
Vladimir Krivosheev
170b66cac6
fix package local access
...
GitOrigin-RevId: 771a1d3e8fc436d6e8fe9b1473a80bb9185ce7b0
2025-01-27 12:43:07 +00:00
Vladimir Krivosheev
97eb8081ed
update bazel files
...
GitOrigin-RevId: fc8f02d9532ef4f014925f793434e9b0bcfd9317
2025-01-26 19:04:16 +00:00
Tagir Valeev
61db218886
[java-highlighting] checkGenericArrayCreation -> GenericsChecker
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: cb63c9a7c244af1d53d6ab428b2c679ab61e47b8
2025-01-24 14:41:53 +00:00
Tagir Valeev
d5182121d1
[java-highlighting] checkConstructorCallProblems, checkSuperAbstractMethodDirectCall -> ExpressionChecker
...
Also: constructor-related methods from JavaHighlightUtil moved to JavaPsiConstructorUtil
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 75d736e0472b7f004dfce5de2aaf1e52b23dab20
2025-01-23 13:15:09 +00:00
Vladimir Krivosheev
56d22a6b8d
don't export intellij.xml.psi - update bazel files
...
GitOrigin-RevId: d32c1dbb965bf356ea3d948cf0ed68727da0b463
2025-01-19 17:03:43 +00:00
Vladimir Krivosheev
4453c70b07
don't export intellij.xml.psi
...
GitOrigin-RevId: 0186a8f9f878122dbb297ca06f64fa7fd4b2e579
2025-01-18 21:21:04 +00:00
Tagir Valeev
5e380ec4c7
[java-highlighting] Record, vararg problems -> MethodChecker, RecordChecker
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: fadea6fb55c8d4bfcfcd6bebfe83534a748c36af
2025-01-17 16:02:19 +00:00
Vladimir Krivosheev
f8805410b5
cleanup (final, reduce visibility)
...
GitOrigin-RevId: 70c74a738dc4dd871646f67a434461f969298999
2025-01-13 18:17:25 +00:00
Tagir Valeev
bca4f75501
[java-highlighting] checkMustNotBeLocal, checkClassAndPackageConflict, checkPublicClassInRightFile, checkWellFormedRecord, checkSealedClassInheritors, checkSealedSuper -> ClassChecker
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 96d04cbf95d1c92486090997d527b05f929169db
2025-01-09 18:51:18 +00:00
Vladimir Krivosheev
0bc1cf1557
update bazel files
...
GitOrigin-RevId: 7320d3eff3aba093692ce66839c720ece6d7c4db
2024-12-30 11:28:24 +00:00
Vladimir Krivosheev
cc667842f7
IJ-CR-146078 do not export intellij.platform.ide.impl
...
GitOrigin-RevId: 16a29b914bf81d4d5e3cdb43c64b088113a2fcd4
2024-12-30 10:16:07 +00:00
Vladimir Krivosheev
25233df1b1
cleanup - isEmpty
...
GitOrigin-RevId: 100d69abb6a423556574a72e82508fdb8f5d7fa3
2024-12-27 14:41:14 +00:00
Vladimir Krivosheev
051ed2529b
cleanup
...
GitOrigin-RevId: 6fa4f979e0a6641885e2225eb985b13713373ac5
2024-12-26 14:56:01 +00:00
Mikhail Pyltsin
1c5efb8d49
[java-inspections] IJ-CR-152124 IDEA-365031 Propose on info level convert to record for classes without getters
...
- conditions simplified
GitOrigin-RevId: 6288c1b6cba0503a0416abb4216c99a509ff0467
2024-12-26 10:30:16 +00:00
Mikhail Pyltsin
aff3d50d2b
[java-inspections] IDEA-365031 Propose on info level convert to record for classes without getters
...
GitOrigin-RevId: 393cf32c1fa1e1279d40b3444663b3c721bc2b80
2024-12-24 10:53:08 +00:00
Vladimir Krivosheev
7b4c77396e
do not export deps blindly (part 5)
...
GitOrigin-RevId: 48daba2ea218703ecd0f60b5b12cc813c8802338
2024-12-23 20:43:00 +00:00
Mikhail Pyltsin
d3e75c5951
[java-inspections] IDEA-365031 Propose on info level convert to record for classes without getters
...
GitOrigin-RevId: 77f56876a99f3e924bf39232f9cf5a32fb174211
2024-12-20 13:34:02 +00:00
Bas Leijdekkers
2b32d9bb56
Java: basic support for Valhalla Value Classes (IDEA-364548)
...
GitOrigin-RevId: 93b0394866aae35772ccc90e7de822af8a94c6ce
2024-12-18 18:05:29 +00:00
Vladimir Krivosheev
98799639aa
do not use _test as lib - test targets do not support this
...
GitOrigin-RevId: f2f49db4294b6a64040dbbd5f1d95e972cbd70a3
2024-12-15 18:32:30 +00:00
Mikhail Pyltsin
fec8a2de9c
[java-completion] IDEA-359174 command completion
...
- new implementation for quick-fixes
GitOrigin-RevId: 82cbad4e1de9eaa089027325d28bb0774ecd05b8
2024-12-14 13:31:08 +00:00
Tagir Valeev
8e0a1613f1
[java-inspections] Preview feature warning: limit highlighting to method name
...
Fixes IDEA-362013 Stream.of should not be highlighted because it's not a preview feature
GitOrigin-RevId: 0818188d2e5ae25916c0433dfe976c808eebf869
2024-12-09 16:26:42 +00:00
Mikhail Pyltsin
3c78fe69e6
[java-inspections] IDEA-363980 Support JEP 495. Update ImplicitToExplicit /ExplicitToImplicit inspections
...
- tests
GitOrigin-RevId: 946428cb5f8e397625acbec9446d731fb0550225
2024-12-06 19:03:38 +00:00
Bartek Pacia
5569a2965d
[java-inspections] IDEA-14669 fixed: suggest adding specific non-null assertions from test frameworks
...
(cherry picked from commit 0d22d640ea4ee77a6bdfb5b4af504332e7456b68)
IJ-MR-150371
GitOrigin-RevId: 04a5fe47cf874ae78c5ad73282b55123f55e84cb
2024-12-05 12:35:38 +00:00
Bartek Pacia
921e136028
[java-inspections] IDEA-352426 'Boolean.TRUE.equals(boolean)' should be simplified
...
fixed IDEA-352426
(cherry picked from commit a7570cc68be64a4d115a4683b1ccb0136cf713d7)
IJ-MR-150641
GitOrigin-RevId: 41c89166f7b988267f01834fdf79e8f4e12cf896
2024-12-05 01:26:24 +00:00
