Mikhail Pyltsin and intellij-monorepo-bot
8a4ce41c1c
IJPF-CR-30511 [java-highlighting] IDEA-252433 Suggest the correct import when the wrong one was chosen from ambiguous
...
- change `to` with `with`
(cherry picked from commit c3e68d77a1b5ee1a5b252b19027cc061609ca9d6)
GitOrigin-RevId: 9ad86fb558f91e64e4a1068f5ea134424e3aff67
2025-10-22 20:21:38 +00:00
Bartek Pacia and intellij-monorepo-bot
9f4c117fb2
[java-inspections] IJ-CR-177985 improve inspection descriptions
...
Related: IDEA-372834
GitOrigin-RevId: 6cceb2c89e45572f6244768031ef29fe455eb437
2025-10-13 23:16:24 +00:00
Bartek Pacia and intellij-monorepo-bot
4b8200ec04
[java-inspections] IDEA-372834 differentiate "catch" parameters in 'unnecessary final inspection'
...
Actually not originally talked about in IDEA-372834, but it is a logical addition.
GitOrigin-RevId: 977cdea9b98d7e2ccd31bf989dd77db2fa2db857
2025-10-09 09:20:53 +00:00
Bartek Pacia and intellij-monorepo-bot
ae3a13568d
[java-inspections] IDEA-372834 differentiate between "method" and "foreach" parameters in 'unnecessary final inspection'
...
GitOrigin-RevId: 7c2eb42d5964928ebc43dd171b8d702a91331c60
2025-10-09 09:20:52 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
5219102458
[java-inspection] IJ-CR-177592 IDEA-375813 It seems dataflow join works wrong for branching with division by zero
...
- fix naming
GitOrigin-RevId: 66fb80af4c9c5e69285eb62845265cc06f9718be
2025-10-07 19:42:03 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
789fdc06c6
[java-inspection] IJ-CR-177592 IDEA-375813 It seems dataflow join works wrong for branching with division by zero
...
- added descriptions and a new option
GitOrigin-RevId: 4d105d96b1b8fd0bae8560134479c959aaaa7d20
2025-10-06 13:15:06 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
e8b76edbf2
[java-inspection] IDEA-375813 It seems dataflow join works wrong for branching with division by zero
...
GitOrigin-RevId: c14db3aee067692092d2a96292082d81756c21a5
2025-10-03 15:46:22 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
48b384354e
[java-highlighting] IDEA-378781 Quick fixes for typos in keywords
...
- more cases
GitOrigin-RevId: 56f497789cb02e5c867053056458bbfdc20d3ac5
2025-09-30 16:20:30 +00:00
Bas Leijdekkers and intellij-monorepo-bot
8ed7abee22
Java: better quick-fix text
...
GitOrigin-RevId: 9b0e0ccd116171e515eef1e7c7f07d1c4cb07854
2025-09-26 16:09:45 +00:00
Bas Leijdekkers and intellij-monorepo-bot
4a28c011bd
Java: nicer quick-fix text
...
GitOrigin-RevId: c454f730670badff1df440b76adbd45de34c273a
2025-09-25 18:47:50 +00:00
Bas Leijdekkers and intellij-monorepo-bot
ee40c49e16
Java: improve inspection message
...
GitOrigin-RevId: 8691cc97b15d1a8bd2bfd6ec73ebe2ddafe27bac
2025-09-25 18:47:50 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
eebb6c4bb2
[java-highlighting] IDEA-378781 Quick fixes for typos in keywords
...
GitOrigin-RevId: 3984441825712d7f566461eaea10748d5b78f024
2025-09-22 14:16:34 +00:00
Marcin Mikosik and intellij-monorepo-bot
c4272dc602
[java] IDEA-216276 Add ShowDuplicateElementsFix that shows popup with a list of element duplicates and use it for duplicate-method error
...
#IDEA-216276 Fixed
Merge-request: IJ-MR-171237
Merged-by: Marcin Mikosik <marcin.mikosik@jetbrains.com >
GitOrigin-RevId: 5aab229888a361d3d4f653708b7f42d832c44645
2025-09-11 08:47:24 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
e1f23e7ca2
[java-highlighting] IDEA-252433 Suggest the correct import when the wrong one was chosen from ambiguous
...
GitOrigin-RevId: 45f0596a4a1a22d47f6a045eb1c1a65d47a4e5c8
2025-09-10 17:23:06 +00:00
Marcin Mikosik and intellij-monorepo-bot
9fd6ada970
[java] IDEA-283208 Add quickfix: Lift 'throw' out of 'switch' expression
...
Adds a quick-fix: "Lift 'throw' out of 'switch' expression" that that is provided for error "'switch' expression does not have any result expressions".
Some rare cases are not handled (fix is not provided for mentioned error).
For example when switch is used inside:
- initialization/condition/update part of for loop
- initializer of class field
- condition of do-while loop
- lock expression in synchronized statement
- any part of assert statement
- resource initializer of 'try' statement
#IDEA-283208 Fixed
Merge-request: IJ-MR-172146
Merged-by: Marcin Mikosik <marcin.mikosik@jetbrains.com >
GitOrigin-RevId: a2710c49e16b7f495974fb167bcae01b3d850f7b
2025-08-21 09:10:24 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
22b7af6762
[java-highlighting] IDEA-267379 "Non-canonical record constructor must delegate to another constructor" fix could be provided
...
GitOrigin-RevId: f27d1c6ae299debfaab0504921cf96487c9b62ab
2025-07-30 11:08:29 +00:00
Bart van Helvert and intellij-monorepo-bot
94d5fdf882
[java] Replace not-null with non-null
...
To make error messages consistent #IDEA-374747 Fixed
(cherry picked from commit 328c5b355fcf56a7d1c165aab32220d37bdfcbc1)
IJ-MR-170004
GitOrigin-RevId: f00fb74ddbff84b18839c60648d664774d566966
2025-07-22 21:25:49 +00:00
Tagir Valeev and intellij-monorepo-bot
ac013e30b2
[java] Make default annotations context-dependent
...
Default annotation is now defined from PSI context using an ordered list of nullable or notnull annotations. The first available annotation is selected.
For Spring Boot 3, default annotation is org.springframework.lang.NonNull/Nullable
For Spring Boot 4, default annotation is org.jspecify.annotations.NonNull/Nullable
Legacy settings with an unordered annotation list are converted to make them ordered
Non-context-specific default annotations are still used as a default for external and inferred annotation; also it's a fallback option in contexts where no annotation is available at all
ChangeNullableDefaultsFix is removed, as now it's unlikely to produce the desired result (and probably was not useful before as well)
Fixes IDEA-372145 Support for third-party nullability providers
GitOrigin-RevId: 31794eb024ba310ca35d4b3df33420d0bb344898
2025-07-17 15:56:29 +00:00
Tagir Valeev and intellij-monorepo-bot
09e6d7f595
[java-analysis] QuickFixBundle.properties: remove unused property
...
GitOrigin-RevId: f062be8a63a093a46f0b39a55a0b70503767d060
2025-06-17 13:31:39 +00:00
Nikolay Chashnikov and intellij-monorepo-bot
d039e59e88
[java] report access to package-private members declared in production code from tests (IDEA-372858)
...
GitOrigin-RevId: 6f046186e0f0a587e1aaab31dd55b9f76a28db96
2025-05-19 10:03:24 +00:00
Marat Dinmukhametov and intellij-monorepo-bot
f3df8ba421
[http-client, microservices-jvm] IJPL-179625 The URL part of MicroservicesJvm was moved to Java
...
Because HttpClient will be in Android Studio. It needs access to this API to have implementations of HTTP clients (Ktor, Retrofit, OkHttp) in Android Studio.
GitOrigin-RevId: 30771b08ec0a1642ca010cde8513703abc0f7b0f
2025-05-15 09:59:55 +00:00
Bas Leijdekkers and intellij-monorepo-bot
26d26d0caa
Java: update inspection name and description (IDEA-271214)
...
GitOrigin-RevId: 6c3b065c026b0de4e3b9cdf881ac2427c912390f
2025-05-13 17:43:07 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
037958feaf
[java-inspections] IDEA-360079 unused for main method modifiers
...
GitOrigin-RevId: 698a021a1c86d8365a113d2d1b47c085beec9489
2025-05-09 11:55:52 +00:00
Nikolay Chashnikov and intellij-monorepo-bot
aaa77e18b7
[java] remove UI for configuring groups of modules loaded together in 'Suspicious package-private access' inspection (IDEA-200047, IJPL-149126)
...
We got rid of such exceptions in intellij monorepo (see IJPL-149126), and it's better to remove the ability to add them back. Given that the inspection is currently visible in internal mode only, it shouldn't affect users. Moreover, since the usability of UI was questionable, after removing it we can make the inspection non-internal.
The option itself and code which reads its configuration are kept to avoid red code in older branches of the monorepo where the problems in code aren't fixed.
GitOrigin-RevId: 2bf42ade9ec35de6571a1d42889569790d0655b5
2025-05-02 08:05:38 +00:00
Tagir Valeev and intellij-monorepo-bot
5fd8eb4a09
[java-inspections] IDEA-371838 Convert SideEffectsMethodRefToLambdaFix to ModCommand
...
GitOrigin-RevId: 8e1fff8b05604adf5fe3e6dc853d8ac952b5a242
2025-04-29 13:01:39 +00:00
Dmitry Batkovich and intellij-monorepo-bot
cae9c6c268
java: re-use standard JavaSyntaxHighlighterFactory for lexer highlighting on frontend. Drop FrontendJavaSyntaxHighlighterFactory.
...
GitOrigin-RevId: a696a5deee2c2ea75b719c4995b4d5a20b808137
2025-04-17 13:10:08 +00:00
Bas Leijdekkers and intellij-monorepo-bot
e94aebcbf7
Java: allow to suppress inspection using @SuppressWarnings("module") that javac understands (IDEA-357459)
...
for "Java module name contradicts the convention" inspection
GitOrigin-RevId: bb1a350e601ec93f4c54c1fef096d3d771ec9617
2025-04-15 08:34:10 +00:00
Bas Leijdekkers and intellij-monorepo-bot
e24bcbd00c
Java: improve inspection messages and fix replacement with tab character
...
in "Unnecessary Unicode escape sequence" inspection
GitOrigin-RevId: 53cd08d56aba3aa23ab4580ebbaf0c3807a7047b
2025-04-12 16:28:13 +00:00
Tagir Valeev and intellij-monorepo-bot
85c83b0ecc
[java-highlighting] IDEA-368383 Create a new extension point to register error highlighting fixes
...
GitOrigin-RevId: 4a7f83a1c75c9b772bb68de6cc46346f68177a42
2025-03-03 12:11:00 +00:00
Bartek Pacia and intellij-monorepo-bot
bb7efcadba
[java-inspections] SequencedCollectionMethodCanBeUsedInspection should ignore named constants
...
#IDEA-367961 fixed
Merge-request: IJ-MR-155974
Merged-by: Bartek Pacia <bartek.pacia@jetbrains.com >
GitOrigin-RevId: aa16bf0758ef523f21c0eeaf73e27e418fc0cd89
2025-02-25 12:59:44 +00:00
Tagir Valeev and intellij-monorepo-bot
fff1c6af0c
[java-analysis] ClassDataIndexer: provide an extension to register custom file suppressors
...
Should help BAZEL-852 IntelliJ incorrectly infers "Contract(pure = true)" annotations for methods from ijar-s produced by Bazel
GitOrigin-RevId: 2fdfc9166737d0aba84372a5a2d127aeeb747f9d
2025-02-18 09:36:18 +00:00
Tagir Valeev and intellij-monorepo-bot
a0f777069b
[java-highlighting] move module-related warnings to JavaModuleDefinitionInspection
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 66179a41da5e02b759f07f9d6638b87711181348
2025-02-17 12:04:21 +00:00
Aleksey Dobrynin and intellij-monorepo-bot
d41422ac8f
[java, import-module] Replace 'import module' with class imports in module-info.java (IDEA-367505)
...
GitOrigin-RevId: 8a0ba58ca14698f553fdd6baf132d00d7ba0e504
2025-02-14 01:09:59 +00:00
Tagir Valeev and intellij-monorepo-bot
65dbbd5a3a
[java-highlighting] refactor MultiReleaseUtil.kt; merge with JavaMultiReleaseUtil
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 05487a43bb4277cef0d96ecf9f6fce789d292091
2025-02-13 16:25:21 +00:00
Michail Plushnikov and intellij-monorepo-bot
4a760237af
[lombok] IDEA-279512 Prevent false-positive for Local variable or parameter can be final inspection with lombok.val
...
GitOrigin-RevId: 9e4f945cf982e8099fcf626565babc576544d7a3
2025-02-11 23:24:15 +00:00
Dmitry Kichinsky and intellij-monorepo-bot
290d42517d
[maven] IDEA-255308 introduce MultiReleaseSupport extension
...
GitOrigin-RevId: 8652a6d5cf88b36272e18f574ce00be6878976af
2025-02-01 15:29:32 +00:00
Tagir Valeev and intellij-monorepo-bot
c7edfdbe4a
[java-highlighting] SafeVarargs checks -> AnnotationChecker
...
Also, warnings are moved out to inspections
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 2292723fde787454467307c213ea38e730aa0ff5
2025-01-08 16:42:47 +00:00
Bas Leijdekkers and intellij-monorepo-bot
2d7e9aec9c
Java: report implicit assignment or return of record components with mutable type (IDEA-325828)
...
GitOrigin-RevId: f7b7091c291db33468bb60b22cab01dc11aca586
2024-12-29 13:41:59 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
1fa30df2e4
[java-inspection] IDEA-364384 'Non-constant string as argument to ...' logging call has no quick fix if logger is returned from another method
...
GitOrigin-RevId: f33aa6b47a420fe610a440fd4321826a7a43452f
2024-12-27 16:44:32 +00:00
Yuriy Artamonov and intellij-monorepo-bot
e2d6af6765
[java] Suppress non-code annotations line marker on Java toString()
...
Object.toString() supposed to have the standard contract, and there is no real need to add explicit annotations there. This shrinks gutter width in final classes a bit.
GitOrigin-RevId: 1c06db7412603a145b9bc888ec6bf52bfedbb420
2024-12-21 08:58:41 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
94efe9cb4d
[java-completion] IDEA-359174 command completion
...
- add new actions: getter/setter/find usages, introduce variable
- fix set of actions
GitOrigin-RevId: 9f733d5b38cb8333c3c83e1a0f3d8ea43d7bcbb1
2024-12-03 21:33:19 +00:00
Tagir Valeev and intellij-monorepo-bot
da09d6373a
[java-intentions] Remove redundant properties
...
GitOrigin-RevId: 934b84c1f3ee9e14e665fdaf267000cc0e946c07
2024-12-03 14:25:33 +00:00
Vladimir Krivosheev and intellij-monorepo-bot
57a3174bf0
move resources to existing resources root
...
GitOrigin-RevId: 78997483cfe62983f667d27b6d03220e697cdb45
2024-11-23 08:09:44 +00:00
Bas Leijdekkers and intellij-monorepo-bot
a016f884d3
Java: add error for class extending sealed class from another package (IDEA-358672)
...
GitOrigin-RevId: d7b0c68100ddc60f42bfedc1f3b88e54cbd3ce74
2024-10-29 01:52:20 +00:00
Tagir Valeev and intellij-monorepo-bot
dd15592444
[java-inspections] Refactor and improve MismatchedCollectionQueryUpdate
...
1. Track separately updates that have no effect on empty collection
2. Extract MismatchedQueryUpdateRunner to avoid lots of arguments
3. Make QueryUpdateInfo immutable record
4. Track variables containing derived collections
5. Track iterators as derived collections
Fixes IDEA-356315 Incorrect suggestion of Stream.toList() when followed by Iterator.remove()
GitOrigin-RevId: 3b7fd99b2310f123e924034f7c623bd01e4e4c40
2024-10-21 17:40:32 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
1512d52efd
IJPF-CR-24873 IJ-CR-145218 [java-inspections] IDEA-201932 Provide inspection to highlight redundant creation operations in java date time api
...
GitOrigin-RevId: 5af6c994aca832256f73eaa301cc21f6bb738316
2024-10-11 20:45:20 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
f474d8047b
IJ-CR-145218 [java-inspections] IDEA-201932 Provide inspection to highlight redundant creation operations in java date time api
...
- combine into one inspection
- fix messages
GitOrigin-RevId: d4e064948f8c730c4d68c58e6c9b1277c6b66b4d
2024-09-27 17:12:29 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
9eb0e15e2c
IJ-CR-145121 [java-inspections] IDEA-357009 new option to configure custom classes for IncorrectMessageFormatInspection
...
- fix table for `IncorrectMessageFormatInspection`
GitOrigin-RevId: 272d89fafaac63517e990b1d2808ec54d4c58e69
2024-09-27 09:33:50 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
f73a4d96be
[java-inspections] IDEA-201932 Provide inspection to highlight redundant creation operations in java date time api
...
GitOrigin-RevId: 6b246167dda52272122d356c3f6a787eab5a2542
2024-09-20 14:10:17 +00:00
Mikhail Pyltsin and intellij-monorepo-bot
abb1899900
[java-inspections] IDEA-357009 new option to configure custom classes for IncorrectMessageFormatInspection
...
GitOrigin-RevId: ab026ee405f78ff29519afb0db62449a682b5bd3
2024-09-19 12:20:53 +00:00