This bumps CMP to 1.9.0-beta03, up from beta01.
It also:
* Updates the upgrade-compose.md docs
* Removes dupe dependencies from the compose.foundation.desktop.junit
library (they already come in through the foundation module)
* Fixes the images Markdown extension POM to actually depend on Coil3
closes https://github.com/JetBrains/intellij-community/pull/3188
(cherry picked from commit e7850c7f82a261f922d63d5926a0fe73aeb1f48e)
(cherry picked from commit c4c2434224b55043debb51b8960b20b5e95fc65b)
IJ-MR-173046
GitOrigin-RevId: e4ee67860327998870b14cdbdb5f3eea873c3a82
We now apply additional Compose rules to our Detekt checks. The rules
are documented at https://mrmans0n.github.io/compose-rules/rules/
A couple of rules have been disabled as they do not apply to Jewel as
a library. The rules JAR was added to the repository so that it can
also be used by the IntelliJ Detekt plugin, and show issues in the IJ
editor.
This applies trivial fixes from the rules, leaving difficult ones for
a later time (suppressed and filed tech debt issues to fix them).
Notable changes from applying the rules:
* Fixed a bug in `BasicLazyTree` where a derived state was not
remembered.
* Fixed a bug in `ButtonImpl` where the `onStateChange`, accessed in
a `LaunchedEffect`, was not used as a key to the effect. We have
recently fixed a similar bug in JEWEL-868.
* Fixed the same kind of bug in `ListComboBox`.
* Fixed the same kind of bug in `CircularProgressIndicator`.
* Fixed several missing remember keys in `PopupMenu`'s `MenuContent`.
* Fixed a bug in `ContextMenu` where the focus manager and input mode
manager were not remembered.
* Deprecated several mistakenly public APIs in Menu.kt, and made them
to delegate to a now-private implementation, so the public one can
be safely removed in the future.
* Made sure there is no indication set by default, instead of the
stock one provided by Compose.
* Adjusted the signature of many internal composables.
* Improved the SLC and tree samples in the showcase.
* Added a simpler variant to Modifier.outline().
This also adds an artifact so that we get a JAR for our own Detekt
rules plugin when the IDE is built from JPS.
closes https://github.com/JetBrains/intellij-community/pull/3161
(cherry picked from commit c8bb6f5c91fe96e7fce075d1d45dd6605019409b)
(cherry picked from commit f33b98d43d6d55fac30f7a8dda1efc07586b8be8)
IJ-MR-173046
GitOrigin-RevId: 3b7c0b294f141d011fc0e989bfa32d86fe56ca6b
Brings back ConPty update to version 1.22.11141.0 that was reverted in the pty4j 0.13.9.
(cherry picked from commit 8937f3e81683c528fac4afb915ad198c29c05d48)
IJ-CR-170320
GitOrigin-RevId: 730a5574074270c23465be87b5aa07674a8e4969
This cleans up a number of issues with the Markdown image extension:
1. APIs were not annotated as experimental, but everything under
Markdown should be
2. Coil3ImageRendererExtensionImpl was public for no good reason
3. The alt text for inline images was populated incorrectly
4. The dependencies were not set up correctly (partly not exported,
both in JPS and Gradle)
5. We were using an outdated Coil version
6. Naming conventions were not fully followed for the image loading
extension
7. The extension APIs were missing KDoc and the readme was not very
clear
8. In the sample and Markdown preview we were creating a new image
loader on every recomposition
9. We only had a composable way to init a new extension, when all we
needed was a Coil context
10. Some opportunistic cleanup of the Markdown sample, including
updating the Readme with more images
11. Images in Markdown were missing the tooltip with the alt text (if
any)
12. The Markdown editor in the standalone sample crashes at startup
(JEWEL-878)
(cherry picked from commit 12f160f42295fb7be53b08307c4a35881d9c2a85)
(cherry picked from commit a3951cdfb7a30a72c427a8b88174f628f2519194)
IJ-MR-168786
GitOrigin-RevId: e043ee2ec40b6373eeb51eaa8533f7c7ed8c61ac
The rule is a bit buggy, and difficult to read. It also
has essentially no tests. This addresses both concerns.
I also noticed for whatever reason we were not properly
running detektMain and detektTest on the GitHub CI,
which means we had a bunch of warnings. I have now added
both checks to the GitHub CI. Hopefully, we'll be able
to run the same checks on TeamCity at some point, too.
Note: this bumps Detekt to 1.23.8 (latest version) and
adds a test-only dependency to detekt-core — I'm not
sure if this will require manual merging due to Bazel.
It also tweaks the Jewel .editorconfig to 120 as that's
the value used by the CI, and fixes all outstanding
static analysis warnings.
closes https://github.com/JetBrains/intellij-community/pull/3123
(cherry picked from commit 4a7ff36896c9a23929dc37c11ac5c95fe1f2fc93)
(cherry picked from commit 6b888c6abedcc901aa3e6ef447eed1e6f7c2fcf1)
IJ-MR-168786
GitOrigin-RevId: 6c728fa8b73a69bfef87eba5f7a4853f63f38a9f
It supports every image as an inline node;
Using built-in coroutine library and ktor3 from the platform;
Added SVG support using a coil dependency.
Moved images into an extension so it can be loaded
on demand without pushin coil3 dependencies to everyone.
Add Coil3ImagesRendererExtension to rendering extensions to
render images.
Also expose `imageLoader` as a parameter to give fine
controls to apps wanting to pass in their global loader.
(cherry picked from commit f7b51b8239622c39297aeb8dcfd8fad3435111ec)
(cherry picked from commit 59f8cf9d80d1a53267e902f78976c97d24a898b3)
IJ-MR-168786
GitOrigin-RevId: 880feae68b283c1fce907557522a0d4e78a8cdd2
* Switched to the project-level dependency everywhere
* Introduced a new module intellij.platform.ml.logs to separate ml-api library usages from intellij.platform.ml and intellij.platform.ml.impl modules
* The following models has been adapted to the latest ML API version: python imports ranking, fuzzy resolve, completion trigger model, jetenry inline prompt detection, jetenry fleet code classification
Merge-request: IJ-MR-166415
Merged-by: Vladimir Fedorov <890readrid@gmail.com>
(cherry picked from commit 9056efba5a5397a700daabb453ee1477cfaabdf3)
GitOrigin-RevId: 7cfc63d35b55ac968d5a3b789d2ed5f29d4f12d6
Now all artifacts from this repo is migrated to intellij-dependencies
(cherry picked from commit 2ae0d4455dbaa5ffa169a711304d337d741bc9b4)
GitOrigin-RevId: cfb36c9faf2252bcc1ff7c6e3d6e2f1a061de100
This version reverts the ConPTY update that caused
the regression on Windows 10.
Reviewed and approved in IJ-CR-167781.
The changes are the same as in the original
commit except that the file lib-lock.json
doesn't exist in 252, hence the manual cherry-pick.
(cherry picked from commit c9d9e38a6e6ff194120788a90977af9f2a43053f)
GitOrigin-RevId: ab24488dad00c88369315e78e78c853fd4696942
Fixes exception "SecItemCopyMatching failed: The specified item could not be found in the keychain (was: System wide certificates not read by Gateway/IntelliJ/JB Client 2025.1.1 and above)"
See actual library changes at
https://github.com/JetBrains/jvm-native-trusted-roots/compare/v1.0.24...v1.1.7
(cherry picked from commit cf0ff4da2bea8f8332716d9a009c2388b6b54667)
IJ-MR-166664
GitOrigin-RevId: dca8d8568b757f1723801a332ccfb73c60be98fd
Now a module-descriptors.dat file is generated alongside module-descriptors.jar, and it's used to load the module descriptors at runtime. The new file contains the same data as module-descriptors.jar, but it's stored in binary format instead of XML files inside a ZIP file. This reduced the time required to load the data up to 10 times.
GitOrigin-RevId: 7b8e5e13e27f13db8ee252001784c7126527b4ea
Now a module-descriptors.dat file is generated alongside module-descriptors.jar, and it's used to load the module descriptors at runtime. The new file contains the same data as module-descriptors.jar, but it's stored in binary format instead of XML files inside a ZIP file. This reduced the time required to load the data up to 10 times.
GitOrigin-RevId: 9139d637b12bc01085d7dcf03a273ad8779b9d49