22064 Commits

Author SHA1 Message Date
Maksim Medvedev
9c551e753e Delete JavaMultiverseCodeVisionProviderTest in 251 branch
JavaMultiverseCodeVisionProviderTest blinks in 251.
But multiverse functionality is disabled in 251, so there is no sense to run this test at all.

GitOrigin-RevId: b2c2b9e7cc8ebe92e1361b7f034381cd1b05eccb
2025-07-11 12:40:29 +00:00
Tagir Valeev
dec7ad081b [java] StringFormatSymbolReferenceProvider: restore support of .formatted() (IDEA-372694)
Was broken during MessageFormat implementation (5bfb87b4 [java] IDEA-358431 Support MessageFormat specifier-to-argument navigation, similar to String.format) when moving away from FormatDecode.FormatArgument.extract. Was not covered by a test.


(cherry picked from commit b7fdecc6c70508608c9157090272b6b4140af0ba)

IJ-CR-163911

GitOrigin-RevId: a34b6822d6b250cb4e7fc1f1378e6f3c7856f70c
2025-05-23 18:53:44 +00:00
Tagir Valeev
c890dda4f6 [java-psi] LambdaUtil.getFunctionalInterfaceType: force returning null type for variables with inferred type
Otherwise, we may have a chicken-egg problem, when the inferred type is computed using its initializer and the initializer type is computed using the variable type which is not computed yet
Fixes IDEA-371650 [Java] test problem com.intellij.java.codeInsight.daemon.LightAdvLVTIHighlightingTest.testSimpleAvailability: Non-idempotent computation


(cherry picked from commit 69f4608ea9ba6ce98cda8c02acdc51134d4c5552)

IJ-CR-163729

GitOrigin-RevId: 6dbe3502b3d730b04766567feaff8442988971f9
2025-05-22 20:10:35 +00:00
Dmitry Avdeev
903b720631 IDEA-355836 Create new Java class / new Kotlin class actions should not be available on the top project level
make test compatible with 251


(cherry picked from commit 1e50ff79540f85b98d59aeebbb7999dfd40d6ac1)

IJ-CR-162668

GitOrigin-RevId: d34e833215932a02f2b8b5538d6263bcd86df38e
2025-05-13 14:12:42 +00:00
Dmitry Avdeev
da9f0d478e IDEA-355836 Create new Java class / new Kotlin class actions should not be available on the top project level
(cherry picked from commit 6a042e1dfc0b3920af39b70561f3d508757975e0)

IJ-CR-162668

GitOrigin-RevId: b68122ec616646c84ba65d0abf72631ac0d74c2a
2025-05-13 14:12:42 +00:00
Aleksey Dobrynin
56e19231b3 [java jpms] Consider file system case sensitivity when processing JDK modules IDEA-371051
(cherry picked from commit 1ccb5215bdf101f106882691cc4f5253a4a8b74d)

IJ-MR-162360

GitOrigin-RevId: 04a228ce8fd8b07d3698cc38f943638058125f34
2025-05-08 15:11:25 +00:00
Aleksey Dobrynin
2dd8312cf2 [java, jigsaw, index] prioritize newest Java descriptor in multi-release JARs (IDEA-365082)
(cherry picked from commit 10d03d5095264cf4e708b6154b4f4a90ea683155)

IJ-CR-156911

GitOrigin-RevId: 9af80db882a95d952565b74db2aa6e82e5dc6716
2025-04-30 10:56:32 +00:00
Aleksey Dobrynin
25a39de77f [java, jigsaw] Support JDK-8197532: add tests (IDEA-367339) IJ-CR-154794
(cherry picked from commit e3acb5c8848ae13da6f28c1593b432e27c81cd14)

IJ-CR-154794

GitOrigin-RevId: 881dcb8023063fcdd7116191c662b180986d4f93
2025-04-30 08:31:30 +00:00
Egor Ushakov
b5f7185b0b IDEA-371371 Stream trace debugging doesn't work with records
(cherry picked from commit bbe83739e3db7cd0b7a4b8842b6e5c1cbb8d1f32)

IJ-CR-161068

GitOrigin-RevId: a25b07b6d494e07c5bc018f5a6922b9bb4ad7978
2025-04-29 21:45:56 +00:00
Ilya Korennoy
cbd1a11c19 IJPL-182721: Fix RubyMine indexing degradation and remove custom processing for global libraries and SDKs
GitOrigin-RevId: f99fc02200f9a3ef065c5f20d4744aaba449226e
2025-04-17 08:36:57 +00:00
Tagir Valeev
a1141237c8 [java-inspections] When analyzing annotation conflict, ignore container annotation if non-container is present
Fixes IDEA-369220 JSpecify support - wrong warning when Nullable method is declared in NullMarked scope and overridden


(cherry picked from commit 50163bfda72bd1f583dda644c668b78859fac022)

IJ-CR-159281

GitOrigin-RevId: fc33b9c9f8ae165baba5a70c00b91267e57d68b1
2025-04-12 07:11:23 +00:00
Tagir Valeev
623504d6db [java-refactoring] IDEA-369011 Refactor -> introduce constant added NotNull annotation
(cherry picked from commit 485a0861caad52b591044e221dec0e44729b4c1e)

IJ-CR-158958

GitOrigin-RevId: a7555472e82a7a916c401a4e3eab30efee4279ac
2025-04-03 16:04:50 +00:00
Mikhail Pyltsin
0ff6bc9f98 [java-debugger] IDEA-367755 Stream trace debugging gives Internal Error in implicitly declared class
- set language level explicitly


(cherry picked from commit 01b844c4f0d812c4505491121429af3cc7df24c5)

IJ-CR-159083

GitOrigin-RevId: d6cca2ad6ad3a3717d27bba341419cb0c236833a
2025-04-02 22:12:05 +00:00
Tagir Valeev
87a0f8f217 [java-dfa] IDEA-358087 Local variable nullability annotations are ignored with default qualifier
(cherry picked from commit e640517083910df691b58415f7ba706be37223ec)

IJ-CR-157989

GitOrigin-RevId: 1bea6bffbedaf9d2b1b372a9c5683da64e5373d5
2025-04-01 11:29:08 +00:00
Tagir Valeev
914432b67a [java-dfa] IDEA-368172 Nullable return is not reported for lambda parameterized with unbounded type parameter under NullMarked
(cherry picked from commit 61623e582c856479d4a2222ef33a73178831e074)

IJ-CR-156030

GitOrigin-RevId: 450b280f93a17b3c8500b6cfeaf9be7464e4edd3
2025-04-01 08:23:22 +00:00
Bas Leijdekkers
780e7d2889 Test for "fix all problems in file" invoked in injection (IJ-CR-157392)
(cherry picked from commit b1751bff527f89f3e429bad73263ec118fdd4ce8)

IJ-CR-157392

GitOrigin-RevId: 20bb08852be07f10c08e3e6a641c0290eb42770a
2025-03-27 10:58:15 +00:00
Tagir Valeev
5e8306f8c8 [java-highlighting] Improve error message in IDEA-369310
Previous hasError status (after syntax error) was not reset. As a result, we did not report the next error on the surrounding element.
(cherry picked from commit 60c0be1cc6ca4967eb72e2fc24278cdc5cf2728e)
Review ID: IJ-CR-157915

GitOrigin-RevId: a44595d7b2e8fd472f6f084998901645bf29eab6
2025-03-20 10:59:14 +00:00
Tagir Valeev
22abc0a29b [java-highlighting] IDEA-369310 NPE in error highlighter
(cherry picked from commit 0944d4f1c9594d138df85041748ff72fb56e436d)
Review ID: IJ-CR-157915

GitOrigin-RevId: 08a1d92218b7164b3683018cf8ce1e865eea7c24
2025-03-20 10:59:13 +00:00
Bart van Helvert
345158158f [java] Don't generate main in implicit class with public modifier
#IDEA-369157 Fixed


(cherry picked from commit 6e8de88250b26b51e2f603eb04d751e1ea086a29)

IJ-CR-157703

GitOrigin-RevId: d7ec7c8e40e377d4e28c4f3f7b5b3d1944d6724c
2025-03-14 14:57:53 +00:00
Bas Leijdekkers
a8a552acf1 Java: add test for renaming record component with non-physical accessor (IJ-CR-157393)
(cherry picked from commit e88f2f4fc950c169d932220c48148a82e4c5bd34)

IJ-CR-157393

GitOrigin-RevId: 91c923ca5885ddf78611498b2e56876848bb2e5c
2025-03-13 19:44:29 +00:00
Bas Leijdekkers
7d17deb072 Java: don't break unrelated code in the same file when renaming record component (IDEA-367393)
(cherry picked from commit e262dd757e952cbd2a0cd6fba58f1448e96832b8)

IJ-CR-157393

GitOrigin-RevId: accd075b0a899ca14c2b95381cd08317f433abb1
2025-03-13 19:44:29 +00:00
Tagir Valeev
2b1dc0d76a [java-refactoring] IDEA-368729 Refactor -> introduce field fails if the expression contains unresolved type
(cherry picked from commit 564e2f82913f777c5c9e0b760b27fc0a859ec430)

IJ-CR-157054

GitOrigin-RevId: e6c98921966c48d5d4a90307c74fe42d6ad02fd7
2025-03-13 10:45:14 +00:00
Tagir Valeev
73beb4f7d9 [java-refactoring] IDEA-368385 Refactor introduce field added NotNull annotation
Additionally fix when LVTI local is converted to a field


(cherry picked from commit 274f9c199b0299986f6e381a109ef55424f0c333)

IJ-CR-156646

GitOrigin-RevId: 3d8d9405190e356eeb3c4114baa057a8213d4f08
2025-03-12 12:15:46 +00:00
Tagir Valeev
ff056b8c7a [java-refactoring] IDEA-368385 Refactor introduce field added NotNull annotation
(cherry picked from commit c695550e832b648d31097d85ee887358551e95ac)

IJ-CR-156646

GitOrigin-RevId: 6288ec8f7abe19c87a57f03121883c0f5049b2ad
2025-03-12 12:15:46 +00:00
Tagir Valeev
d3a7dcfa0a [java-highlighting] Avoid highlighting outside of PsiField psi element
Fixes IDEA-368916 IAE in error highlighting when several fields are declared with shared modifier list


(cherry picked from commit 012b6564f9ca1a775894a3fc2b003c4feb2477e6)

IJ-CR-157290

GitOrigin-RevId: 4640510fdabda87e7b2da384f001f93c9bf64af1
2025-03-12 11:46:51 +00:00
Tagir Valeev
f4f49236b6 [java-highlighting] IDEA-368498 Errors about incorrect TYPE_USE annotations are not reported by IntelliJ IDEA
(cherry picked from commit 05b017fe457e4efaf0685d429bfd6c2e743936cb)

IJ-CR-156764

GitOrigin-RevId: 5b39f41262152741ae21b83e27f3f61e93ad74c2
2025-03-12 11:33:13 +00:00
Tagir Valeev
1efe361fe9 [java-inspections] ExtractMethodRecommender: disable for non-denotable output variable
Fixes IDEA-364433 "Method can be extracted" with 'var' and anonymous class leads to compile error


(cherry picked from commit 8d2f0b12059c8412ed6e1c91d9b8e79ee70cb31c)

IJ-CR-156964

GitOrigin-RevId: ebc0ceab00b591e4b139f79bd9bdf2fbd24af1ee
2025-03-12 11:16:49 +00:00
Bart van Helvert
09b55a16cc [java] Migrate contract provider extension point to hard coded values
#IDEA-366120 #IJ-CR-155341

(cherry picked from commit f0a38cf77f2a636e4d2b58f93f6d225d57d5738f)

GitOrigin-RevId: 34263eb95a904729580bd9180dbbad2c1124ea33
2025-03-11 00:36:09 +00:00
Tagir Valeev
f2cfc536e6 [java-inspections] ObviousNullCheckInspection: disable for methods that don't return the parameter
Even if the return value is not used, it's subject for IgnoreResultOfCallInspection to report it (as we consider only pure methods). It could sometimes be suppressed (e.g., inside assertThrows), in which case it's desired not to report anything.
Fixes IDEA-368213 False positive and code-breaking autofix for ObviousNullCheck


(cherry picked from commit 0ab2fd64b8a8f8599920cffad76fc830790f8269)

IJ-CR-156868

GitOrigin-RevId: cda30602e0c2af93f21a33501f7ad855b89fda1c
2025-03-10 22:29:02 +00:00
Alexey Kudravtsev
f787776e16 KTIJ-33100 K2: Import action caches stale state
(cherry picked from commit d6e38602d07e05e3a64422ddb8b07c43c8f81caa)

IJ-CR-156814

GitOrigin-RevId: faf8d9f77c5b81f3977fe87b92b98fcfc3f77e64
2025-03-10 19:14:21 +00:00
Bart van Helvert
2342dbb3ff [java] Consider candidates from all class finders in class finder
This will make sure the best class is always found. For example, when there are multiple dependencies that contain the same class, the class from the first dependency should be picked, even if it only is found by a PsiElementFinder that appears later in the chain. #IDEA-342753 Fixed


(cherry picked from commit fcd905b1cea47dd488664eff62e2ff1049c4e336)

IJ-MR-155802

GitOrigin-RevId: 7d99cc055ddb03678d162f471dfb0e4fb46cd0a3
2025-03-06 20:18:59 +00:00
Tagir Valeev
e6aa4536a9 [java-psi] Proper order of annotations inside PsiNewExpressionImpl
Fixes IDEA-366918 Wrong order of annotations in new array expressions


(cherry picked from commit 29bbfb29123cd273f4c3d34f74e8a00bc6ab5ec1)

IJ-CR-156763

GitOrigin-RevId: 2eac2a8cae68edddc4f538f164764cb1cdcc2f0d
2025-03-06 10:09:58 +00:00
Mikhail Pyltsin
13b3181d3d [java-imports] IDEA-368382 incorrect place for module import
- support editorconfig
- more tests


(cherry picked from commit d7fd604e95b1dd197a3efbdbfcd54e81564b2490)

IJ-CR-156496

GitOrigin-RevId: 33f86d7996b2a7b5b255de0f67923c8e58d720ca
2025-03-04 23:50:21 +00:00
Mikhail Pyltsin
fc37441445 [java-imports] IDEA-368382 incorrect place for module import
- support static separately


(cherry picked from commit 8d1acc0e8d2bd7d60b1f03b1ebe367d7d9f2e2a9)

IJ-CR-156496

GitOrigin-RevId: b85061e1772f4b7b6603edb980e34d90f6693e42
2025-03-04 23:50:21 +00:00
Mikhail Pyltsin
314374a7c2 [java-imports] IDEA-368382 incorrect place for module import
- more tests


(cherry picked from commit 5b0b65e0b74bb858dab0a0ceeb5f176b0e3f0fdc)

IJ-CR-156496

GitOrigin-RevId: 11f88eff3e5ac2934721b175fb94d34f91a5daed
2025-03-04 23:50:21 +00:00
Mikhail Pyltsin
8830d6dde5 [java-imports] IDEA-368382 incorrect place for module import
(cherry picked from commit ce6ec1c65d5777e5e3059093fdd01baf24f95e50)

IJ-CR-156496

GitOrigin-RevId: 82bbd7a8f64ab39cf4fed24e4a5eb5457e29a49e
2025-03-04 23:50:21 +00:00
Tagir Valeev
2954f198ce [java-dfa] IDEA-365459 "Treat non-annotated members and parameters as @Nullable" inspections makes constructors @Nullable
(cherry picked from commit b4c0234154171b658451e9628fd1bbc873e4699f)

IJ-CR-156081

GitOrigin-RevId: 817d0389f7e0da1476a024d538fe588300c6e5e1
2025-02-28 12:47:10 +00:00
Mikhail Pyltsin
8a701f397f [java-frontend] IJPL-178336 Fix FrontendJavaTypingTest
(cherry picked from commit 2e04dcb38d9e6436420cf929e3298d58f8b2bc90)

IJ-CR-155585

GitOrigin-RevId: b2b04af171892213ae986bfb61cac362104504ca
2025-02-24 15:21:09 +00:00
Daria.Suvorova
7f12753f06 IJPL-339 tests on code vision, subscribing on context change in CodeVisionHost and caching usages count by psi file
GitOrigin-RevId: 5fffc2d63c078048098f70b14eaee19ed8c1ed81
2025-02-19 19:15:18 +00:00
Tagir Valeev
9e458c909c [java-highlighting] checkLabelSelectorCompatibility extracted and moved to SwitchChecker
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)

GitOrigin-RevId: bec076c5bff67e22d06e64e573d3219a4c89dd4d
2025-02-19 17:57:38 +00:00
Tagir Valeev
f8b210a481 [java-highlighting] Minor fixes in switch statement highlighting
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)

GitOrigin-RevId: 2924ae6c9984caa6e8a45f640c4de54e02134ad3
2025-02-19 14:57:00 +00:00
Tagir Valeev
ae7957d3c7 [java-refactoring] ChangeMethodSignatureFromUsageFix: remove external type annotations
Fixes IDEA-366962 Quick-fix for adding method parameter generates long jetbrains UnknownNullability annotation

GitOrigin-RevId: 03d9b8be45670e6a72696d740d7ca71d746c7267
2025-02-19 14:57:00 +00:00
Bas Leijdekkers
3b4e914cad Java: let join lines convert lambda with single line code block body to expression lambda (IDEA-344762)
GitOrigin-RevId: e5f895b4d6241fd4a15fa62e2ab764f9a4e3860a
2025-02-19 11:58:47 +00:00
Konstantin Nisht
69ca01169a [threading] IJPL-149765: Rename writeAction to edtWriteAction #2
GitOrigin-RevId: 82c9ed8b1b21bcb3ad0c4dc84debd3b51f083a80
2025-02-19 11:52:39 +00:00
Eugene Zhuravlev
e381284d13 revert change breaking module resolution from output path; explicit '--patch-module' compiler option enables compilation with 'module-path' instead of 'classpath'
GitOrigin-RevId: 5c22cf1b937a783aa02e298ea995c863dc8c567c
2025-02-19 11:41:46 +00:00
Konstantin Nisht
d65e309920 [threading] IJPL-149765: Rename writeAction to edtWriteAction #7
GitOrigin-RevId: 8e175a58a70823c740801926720a67ebe5bae02b
2025-02-19 11:17:01 +00:00
Vladimir Krivosheev
0d69d3b443 fix MyEditable visibility
GitOrigin-RevId: 6e137cee2c57cb6634c6d28c371ede97753f9f47
2025-02-19 08:33:02 +00:00
Vladimir Krivosheev
7ee9fe1c12 fix methodMatcher visibility
GitOrigin-RevId: 560ac7b766f3807514ac7e414c3b68ed8c170310
2025-02-19 08:33:02 +00:00
Vladimir Krivosheev
e8155a3da9 update bazel files
GitOrigin-RevId: a2a83de8d21a56885e3e3ea60cedf32f287c2dcd
2025-02-18 18:11:53 +00:00
Mikhail Pyltsin
71b95a736f Revert "[java-runner] IJ-CR-154797 IDEA-363985 Temporary workaround for JNI restriction"
This reverts commit dda8badb

GitOrigin-RevId: a52b17f30c338d7bb11caecf17e32690f6621582
2025-02-18 12:51:57 +00:00