808 Commits
Author SHA1 Message Date
Bas Leijdekkers 20ce72eb23 Java: JavaInvertBooleanDelegate cleanup
GitOrigin-RevId: e8c76be68e21b534f824cc864f4b2b903eac4db9
2025-01-07 10:05:14 +00:00
Bart van Helvert c73b6ea3c0 [java-debugger] Fix reflection access method builder for param types with type parameters
Previously, types were always erased, possibly resulting in incompilable code. #IDEA-364628 Fixed


(cherry picked from commit 9ed54043147d0190805f2adb9fbb6cf6160bf6e4)

IJ-MR-152217

GitOrigin-RevId: eefc9013303671195dff4028632a4b8d2467cb7b
2025-01-02 17:14:39 +00:00
Vladimir Krivosheev 0bc1cf1557 update bazel files
GitOrigin-RevId: 7320d3eff3aba093692ce66839c720ece6d7c4db
2024-12-30 11:28:24 +00:00
Vladimir Krivosheev cc667842f7 IJ-CR-146078 do not export intellij.platform.ide.impl
GitOrigin-RevId: 16a29b914bf81d4d5e3cdb43c64b088113a2fcd4
2024-12-30 10:16:07 +00:00
Vladimir Krivosheev 25233df1b1 cleanup - isEmpty
GitOrigin-RevId: 100d69abb6a423556574a72e82508fdb8f5d7fa3
2024-12-27 14:41:14 +00:00
Vladimir Krivosheev 051ed2529b cleanup
GitOrigin-RevId: 6fa4f979e0a6641885e2225eb985b13713373ac5
2024-12-26 14:56:01 +00:00
Vladimir Krivosheev 98799639aa do not use _test as lib - test targets do not support this
GitOrigin-RevId: f2f49db4294b6a64040dbbd5f1d95e972cbd70a3
2024-12-15 18:32:30 +00:00
Alexey Kudravtsev ad931763c2 mark @Unmodifiable
GitOrigin-RevId: 555fb0a0ef1a13e53dfc3faf4268e7b08ea4309e
2024-12-12 15:34:17 +00:00
Alexey Kudravtsev 10e7677c16 fix "immutable collection modified" warnings
GitOrigin-RevId: bc70a53538fa8eddf59d27197c5b74c3afcffb1b
2024-12-11 16:28:34 +00:00
Tagir Valeev 7584e0bd9d [java-refactoring] Avoid local ref cache during inline refactoring
Useless anyway, as the files are constantly updated; does many unrelated computations
IDEA-364541 Inline method spends a lot of time inside getVariableReferences

GitOrigin-RevId: 1814ada8815641cb9159bbe10bc28c719d2bbf44
2024-12-11 11:10:03 +00:00
Alexey Kudravtsev b2677fef4e NotNull
GitOrigin-RevId: cf24b2660138b5b9b37920963bc5efbcd96481a8
2024-12-04 15:57:44 +00:00
Alexey Kudravtsev e8151c8e55 annotate @Unmodifiable
GitOrigin-RevId: d669ea9e2a0034bfddf72145356a39d55a3c3c2f
2024-12-04 15:57:44 +00:00
Alexey Kudravtsev e54915b793 fix "immutable collection is modified", refactor API to work with unmodifiable collections
GitOrigin-RevId: b5309019497da01735d64ab0ead7cdb3c3d602be
2024-12-04 15:57:44 +00:00
Tatiana Elfimova 09c8267e12 IJPL-58451 Use JBBox instead of Box to avoid "filler" accessible role
GitOrigin-RevId: c68e82bb218de6335f5d987f384427a1e3a3ad9d
2024-12-04 15:27:02 +00:00
Mikhail Pyltsin 9348d2cfb5 IJ-CR-150661 [java-inspection] IDEA-311157 deleting component doesn't check usages
- fix test
- fast exit for unnamed variables

GitOrigin-RevId: cc6d6f646613e231aa4ab8a72693b95fbc3f1248
2024-12-03 21:33:19 +00:00
Mikhail Pyltsin cafbc411d8 [java-inspection] IDEA-311157 deleting component doesn't check usages
- use library methods

GitOrigin-RevId: a8a1b913b28e1d3b5e93911c0906bcf911005e3a
2024-12-03 17:35:44 +00:00
Mikhail Pyltsin bd9dc78aae [java-inspection] IDEA-311157 deleting component doesn't check usages
- fix recursive call with unconditional

GitOrigin-RevId: fb08111db21de7acb23ddef7368c1880da361e82
2024-12-02 23:20:02 +00:00
Mikhail Pyltsin 4b76fbce4f [java-inspection] IDEA-311157 deleting component doesn't check usages
GitOrigin-RevId: 55ef9a7d7fa7b96a8f54e91801060b7c3d44dd65
2024-12-02 18:59:47 +00:00
Max Medvedev 0cf34c096a Fix NPE EA-1514390
NamesValidator#isIdentifier and NamesValidator#isKeyword effectively has a nullable project,
but Groovy and Java implementations are not ready for that

GitOrigin-RevId: 4e74be80b2a58648e09db0c76e1a44dd12764a23
2024-12-02 11:41:21 +00:00
Vladimir Krivosheev 8c77c9ed84 don't export ide.core.impl from lang-impl
GitOrigin-RevId: 029fef0995b0d8e6b684f463bdd856dd17021366
2024-12-02 11:32:59 +00:00
Alexey Kudravtsev 3215d88629 remove usages of deprecated immutableSet
GitOrigin-RevId: 412c66898fa8af08406267ba73fbe7f108fd154c
2024-11-29 17:34:20 +00:00
Tagir Valeev 5dca817b05 Add missing @Override annotations
GitOrigin-RevId: 56b084f82d4f4ec5153645b4d745bc881b803a26
2024-11-29 12:51:16 +00:00
Vladimir Krivosheev 17916c90f8 libraries -> lib, resources, opt-in, test deps
GitOrigin-RevId: db66ee95dcb0f0553b40c9cc56cd6afed8634cdd
2024-11-27 13:53:42 +00:00
Alexey Kudravtsev 010833c4a3 fix "immutable passed where mutable expected" warnings
GitOrigin-RevId: 798498dc75c05221c9d77a7daa11d5e89b1a61d2
2024-11-27 12:57:34 +00:00
Alexey Kudravtsev 9cef099839 propagate @Unmodifiable to more methods calling ContainerUtil, to enable data-flow inspection to highlight more warnings
GitOrigin-RevId: 01d3c976ffd35c3290433d0cd6c0f2d59df894f1
2024-11-27 12:57:34 +00:00
Alexey Kudravtsev f2982c675f annotate @Unmodifiable collections to which unmodifiable data from ContainerUtil is assigned, to make it easier for data-flow inspection to spot mutability-related errors
GitOrigin-RevId: 4372383f31177cbc00d981a81adddc88325e98b3
2024-11-26 16:58:17 +00:00
Tagir Valeev ff60a4753c [java-refactoring] IDEA-360614 Replace with single implementation: no downcast when 'this' is used
GitOrigin-RevId: f2ea406a5cf229cf9e63b6c2b53b9d86f245a6d9
2024-11-26 09:06:06 +00:00
Aleksey Dobrynin 8fd5ef3638 [java refactoring ui] convert MoveClassesOrPackagesToNewDirectoryDialog to dsl IJ-CR-149188
GitOrigin-RevId: 8ebaafc194ac5b2275d68c856d4807cd69ac9835
2024-11-21 16:32:53 +00:00
Tagir Valeev d7ed8a605b [java-refactoring] Refactoring dialog: avoid updating var-type state on every updateControls()
It should be updated only on type change (which happens rarely, especially because in many cases, we do not allow to change the type at all)
Fixes IDEA-360822 Introduce Variable: "Replace all occurrences" (Alt+A) triggers flood of exceptions
Slow operations are still possible but should not cause 'flood'. Given that dialog mode in refactorings is rarely used (it's non-default), current fix looks good enough

GitOrigin-RevId: 6ad7e2826b11e1f39598e991201ba05620acae84
2024-11-19 12:34:06 +00:00
Bas Leijdekkers 343c0e569b Java: clean up RenameWrongRefHandler
GitOrigin-RevId: 25d7d7606fc55535330b51f984f3cd092fc00af7
2024-11-13 18:31:47 +00:00
Aleksey Dobrynin b58d0aa7e1 [java refactoring ui] convert MoveClassesOrPackagesToNewDirectoryDialog to dsl (IDEA-20779)
GitOrigin-RevId: da0ed88c96745c64059e66e7a7d969be568d3231
2024-11-12 19:05:53 +00:00
Aleksey Dobrynin 005e247aa8 Rename .java to .kt
IDEA-20779

GitOrigin-RevId: 23ad8e91e51c22313d6927ae8db3322edd91a60b
2024-11-12 19:05:53 +00:00
Bas Leijdekkers 3184367385 Java: keep "Inline this usage, keep the method" option enabled when inline is invoked on the only usage (IDEA-362625)
GitOrigin-RevId: df1e13ff01ce46b415e9466667bfe19ee67145f9
2024-11-11 20:27:58 +00:00
Tagir Valeev 731b66f737 [java-refactoring] isFirstUse: handle static method qualifier
Fixes IDEA-356148 Inlining method creates undesirable temporary variable

GitOrigin-RevId: 34091cb3a6c6388b2086d92e8cd4b206b9250202
2024-11-11 16:52:09 +00:00
Tagir Valeev a762d39396 [java-refactoring] isFirstUse: take PsiAssignmentExpression into account
Fixes IDEA-361852 Java Inline Method refactor introduces intermediate variables

GitOrigin-RevId: 680fbb62f3440b7ae29f4de1793260fe5be0ab36
2024-11-11 16:52:09 +00:00
Andrzej Głuszak cbca664f6c [bazel] Second attempt at generating tests
GitOrigin-RevId: 7763c9994b7c311310b83b98a542775feb00ed68
2024-11-09 11:06:41 +00:00
Tagir Valeev e40626ca11 [java-refactoring] MethodDuplicatesHandler: use NBRA; move ControlFlow and conflict message computation to background
Fixes IDEA-325064 F: ControlFlowAnalyzer.visitCodeBlock (MethodDuplicatesHandler)

GitOrigin-RevId: 35d40edf1ac03b1c25a8e4e58ab33a42eb5d3afb
2024-11-04 12:15:36 +00:00
Sergei Tachenov 978d220e97 IJPL-163868 More FindSettings -> FindUsagesSettings
Replace the few remaining places where it's more or less
obvious that the scope of "Find Usages" and not of "Find in Project"
should be used.

GitOrigin-RevId: f10d35b21bbf8f2e8d29cda67ffe2e5ed9bc5a7a
2024-10-30 19:32:19 +00:00
Tagir Valeev 447ff452ae [java-refactoring] Inline method: support invert transformer in polyadic
GitOrigin-RevId: 516bb8355466a6f994c30692e1432353885d8b04
2024-10-24 16:36:51 +00:00
Ramazan Dzhekshembaev b43027bb24 [fleet] FL-30343 fix file copy for quick fix apply
GitOrigin-RevId: 873abbf9e03691a10785efbad30bfc2a6de91c2c
2024-10-22 12:33:10 +00:00
Tagir Valeev f1473af5f4 [java-refactoring] IDEA-361117 Inline method does not collapse lambda expression back after single-line method inlining
GitOrigin-RevId: e54db7c5b175b264ac37c28a0cdab8ffd194c93f
2024-10-22 12:20:34 +00:00
Bas Leijdekkers 905b338cc3 Java: ignore parentheses when checking write access in Inline Parameter
GitOrigin-RevId: 3807aa5f627febd0f44acab16f8145148945f5a3
2024-10-17 19:06:58 +00:00
Bas Leijdekkers d9bb6a9b0b Java: avoid incorrect warnings when Inlining Parameter (IDEA-345199)
GitOrigin-RevId: 489422cffc7aecacd07468009da620a5732ce5ba
2024-10-17 19:06:58 +00:00
Bas Leijdekkers b9b2735045 Java: make Inline Object with Subsequent Call work for records with compact constructor (part of IDEA-255384)
GitOrigin-RevId: 497cb4f446c4ae6c90622e54898bfc105ba93bd6
2024-10-17 19:06:58 +00:00
Bas Leijdekkers e6233a181d Java: better check that parameter is still available after inlining (IDEA-308977)
GitOrigin-RevId: 4c9da5c574ed55e63dfef43d0d5dd655931533ee
2024-10-16 10:06:48 +00:00
Bas Leijdekkers f959b2e066 Java: update Inline Parameter refactoring messages
GitOrigin-RevId: 3c9c0e2886810b5ad14e7fb4b51250c83b829c39
2024-10-16 10:06:48 +00:00
Bas Leijdekkers f7fcafc161 Java: cleanup Inline Parameter refactoring
GitOrigin-RevId: b0f0e6a85abeaa91afa489bef7f4abe848f61aad
2024-10-16 10:06:48 +00:00
Bas Leijdekkers a6d3ae518f Java: pushing down nested class from interface to class should add static modifier (IDEA-241036)
GitOrigin-RevId: 9b6541f85a1ea73a3debe088ff32899db79aade4
2024-10-16 10:06:48 +00:00
Mikhail Pyltsin c65db5b11c [java-refactoring] IDEA-360637 impossible to rename fields in implicit classes
GitOrigin-RevId: b599af338bb6e1763204d9b03af78c5bd7f8a37b
2024-10-15 13:50:53 +00:00
Tagir Valeev 360772f05f [java-refactoring] InlineMethodHandler: clarifying comment added
GitOrigin-RevId: c5649ed1349897dd13c5ac726440f72b06ab4fd4
2024-10-14 15:13:57 +00:00