129 Commits

Author SHA1 Message Date
Mikhail Pyltsin
3348e7291f [java-inspection] IDEA-363979 Conflicts with on-demand and module imports
(cherry picked from commit 0857df90e3f9cc450b48b56186573a9a89b5b041)

GitOrigin-RevId: 8e1474a59c687561ba5f00a13fecd4d2a9057b7a
2025-02-13 14:23:52 +00:00
Tagir Valeev
d08daf82f5 [java-inspections] IDEA-364908 WhileLoopSpinsOnField doesn't recognize lock
(cherry picked from commit 7a9fb186e4c23bf81a57cf1766a22cd6f85b5097)

IJ-CR-152528

GitOrigin-RevId: 0c49f423e2043958a2b11a95244f58b8e7323085
2025-01-09 19:00:03 +00:00
Tagir Valeev
300adf91fc [java-inspections] IDEA-363792 Incorrect inspection suggestion to replace 0.0/0.0 with 1.0
(cherry picked from commit 72ea479f6b2c3a331685175b11459556ae0a29bf)

IJ-CR-150124

GitOrigin-RevId: 842566d57921ebcbe355cab6c17a6a09f08d486a
2024-11-26 12:30:58 +00:00
Mikhail Pyltsin
1512d52efd IJPF-CR-24873 IJ-CR-145218 [java-inspections] IDEA-201932 Provide inspection to highlight redundant creation operations in java date time api
GitOrigin-RevId: 5af6c994aca832256f73eaa301cc21f6bb738316
2024-10-11 20:45:20 +00:00
Mikhail Pyltsin
e729bc10c8 IJ-CR-146190 [java-inspections] IDEA-360134 Support %n in format string
- support escape symbols

GitOrigin-RevId: 46d46c58b5a43d4aed1c1549326035b0bc32161e
2024-10-09 11:22:00 +00:00
Mikhail Pyltsin
52fe84a033 [java-inspections] IDEA-360291 'Make method constructor' fix shouldn't be shown for implicit classes
GitOrigin-RevId: ba571565430db01d06d37f2da5ab49a97b466db4
2024-10-08 14:02:23 +00:00
Mikhail Pyltsin
81fe531f88 [java-inspections] IDEA-360134 Support %n in format string
GitOrigin-RevId: c7d3b60eec4a72ded2132a3ab24e035baf2c1241
2024-10-07 13:08:21 +00:00
Mikhail Pyltsin
77ec6df673 [java-inspections] IDEA-360135 Non-constant string concatenation in logging call could be triggered with exception argument
GitOrigin-RevId: b9a08671660f1a3cb27e566e1a9ed6a05cd211d4
2024-10-07 13:08:20 +00:00
Mikhail Pyltsin
3288586fdf [java-inspections] IDEA-359749 StringConcatenationArgumentToLogCallInspection could also be triggered by concatenation
GitOrigin-RevId: bb5024a6be79582644fff96b72a8ceeff0fbf15e
2024-10-01 13:32:46 +00:00
Mikhail Pyltsin
f474d8047b IJ-CR-145218 [java-inspections] IDEA-201932 Provide inspection to highlight redundant creation operations in java date time api
- combine into one inspection
- fix messages

GitOrigin-RevId: d4e064948f8c730c4d68c58e6c9b1277c6b66b4d
2024-09-27 17:12:29 +00:00
Tagir Valeev
208b57b0b7 [java-inspections] ProtectedMemberInFinalClass: do not report if hierarchy is unresolved
GitOrigin-RevId: 62796075b86adbf9fb26b81e46cbeb9aa0ea831f
2024-09-25 08:04:53 +00:00
Bas Leijdekkers
c3189981f6 Java: accept more patterns (IJ-CR-144289)
GitOrigin-RevId: c0692f8c924b32988ec98aae86c1ad9b466cb45a
2024-09-24 10:04:30 +00:00
Mikhail Pyltsin
f73a4d96be [java-inspections] IDEA-201932 Provide inspection to highlight redundant creation operations in java date time api
GitOrigin-RevId: 6b246167dda52272122d356c3f6a787eab5a2542
2024-09-20 14:10:17 +00:00
Mikhail Pyltsin
abb1899900 [java-inspections] IDEA-357009 new option to configure custom classes for IncorrectMessageFormatInspection
GitOrigin-RevId: ab026ee405f78ff29519afb0db62449a682b5bd3
2024-09-19 12:20:53 +00:00
Mikhail Pyltsin
3001c41aed [java-inspections] IDEA-357938 try to infer logging type inside methods for StringConcatenationArgumentToLogCallInspection
GitOrigin-RevId: a09f433bdc1cbed3c81ee4fab6f4986b5ada4271
2024-09-18 14:42:24 +00:00
Yuriy Artamonov
47f1c44a90 [java] IJPL-158521 Actions: fix ellipsis in messages for Java actions
GitOrigin-RevId: bfce0d6efa8747660c4b9af3d8defbfa47e4509a
2024-09-15 14:50:09 +00:00
Mikhail Pyltsin
ae365f891c [java-inspection] IDEA-358668 Red code after "Replace 'if' with 'switch' statement" with Enum's
- support enums in patterns

GitOrigin-RevId: b00182c5f77bda03552fb9750e960f74c75582a5
2024-09-05 16:13:13 +00:00
Bas Leijdekkers
028d526405 Java: fix false positive when using java 21 pattern matching (IDEA-357175)
in "'equals()' should check the class of its parameter" inspection

GitOrigin-RevId: f84071ea339bf690eadcba60d491eebe4cb21a7e
2024-09-05 15:02:58 +00:00
Mikhail Pyltsin
dd822c1bc7 IJ-CR-142710 [java-inspections] IDEA-357725 LoggerInitializedWithForeignClassInspection should skip when the logger is not the final field
- fix texts

GitOrigin-RevId: 85d86f362ce860118d2a047321bf4916e01757da
2024-09-02 18:36:41 +00:00
Mathias Boulay
19b9a28603 fix(JavaDoc): Refactoring misplaced tags
GitOrigin-RevId: 313091e94f8b65d379615f91dca7b975428aeeba
2024-09-02 10:36:29 +00:00
Mikhail Pyltsin
4aa99fd33a IJ-CR-143396 [java-inspection] IDEA-356207 incorrect work with typeUseWithType option
- more tests

GitOrigin-RevId: 14fc2ab77a0659541423741c704437c7fba446b6
2024-08-27 14:43:05 +00:00
Georgii Ustinov
c15dd29151 [Java. Inspections] Add test to ForwardCompatibilityInspection to check qualified yield call
IDEA-358316

GitOrigin-RevId: 9b1633787a92b719606c31f09499cad9bde8dcfb
2024-08-27 10:05:40 +00:00
Mikhail Pyltsin
76e51824bf [java-inspection] IDEA-356207 incorrect work with typeUseWithType option
GitOrigin-RevId: b4affe09ebbf3269881bf00d48f75cca3fd27a59
2024-08-27 09:13:47 +00:00
Bas Leijdekkers
e2e6809274 Java: avoid infinite loop when creating switch branches for enum with duplicate constants (IDEA-357561)
GitOrigin-RevId: e9c84396786baceb58501a56d5d7e529f5ae9276
2024-08-22 15:27:14 +00:00
Bas Leijdekkers
bd7f1f4270 Java: proper order of 'true' and 'false' in quick-fix name (IDEA-357973)
also fixes internationalization and the incorrect comma in the name
for "Create missing switch branches" quick-fix

GitOrigin-RevId: 16285e054447d8d15318df8889499bbbf91243a7
2024-08-21 09:12:08 +00:00
Mikhail Pyltsin
c56e5e7313 [java-inspections] IDEA-357725 LoggerInitializedWithForeignClassInspection should skip when the logger is the final field
GitOrigin-RevId: e910d9bb094f058c363148a3d08b695276bcc2c6
2024-08-15 18:02:00 +00:00
Bas Leijdekkers
adbb319537 Java: handle multiline headings a little better (IJ-CR-142291)
GitOrigin-RevId: 0c132d6b41dfc634c15bbe47d8176612909cf3f7
2024-08-15 15:56:37 +00:00
Bas Leijdekkers
31cd07cef6 Java: avoid exceptions on bad javadoc html (IJ-CR-142291)
GitOrigin-RevId: 40fe350fab9354863141929cd135a5f2d0393fc2
2024-08-15 15:56:37 +00:00
Mathias Boulay
abd7b1dded fix(JDoc): Formatting and inspections issues
GitOrigin-RevId: 910e9b3335fa7c3967fb79893ecba7c69595a201
2024-08-14 18:24:38 +00:00
Mathias Boulay
3825899d51 feat(IDEA-353092): early markdown jdoc support
GitOrigin-RevId: 8c02012551f1a97d3f5d6aed021889911b138b28
2024-08-13 11:44:06 +00:00
Mikhail Pyltsin
d8b8f63677 [java-inspections] IDEA-356745 False positive 'Incorrect 'MessageFormat' pattern' when argument is array
GitOrigin-RevId: 75b8f2d944f05ab124e0b1ac340383dcc240b885
2024-08-12 20:28:37 +00:00
Bas Leijdekkers
21d8008ff1 Java: don't break indentation of element after javadoc comment when converting to markdown
GitOrigin-RevId: df6e25727b13fe229531eb2636dcfafa9cb8a175
2024-08-12 17:37:07 +00:00
Bas Leijdekkers
426cda83e6 Java: support xhtml self-closing tags
GitOrigin-RevId: 97e23cb2054fc721e57a2017b952f35351675220
2024-08-12 13:37:26 +00:00
Bas Leijdekkers
1c2887a09c Java: basic support for headings when converting Javadoc to Markdown
GitOrigin-RevId: 0b8d1dcfa1324ff783a9b412b6fb330bbc6b0646
2024-08-09 11:14:15 +00:00
Bas Leijdekkers
ebbf5a1d20 Java: fix <br> support when converting Javadoc to Markdown
GitOrigin-RevId: d85489271ee65ff043f039eda4bfa82f8e50db77
2024-08-09 11:14:15 +00:00
Mikhail Pyltsin
0f5aa949cb [java-inspections] IDEA-357190 Support JEP477 - Remove unnecessary qualification is not suggested when it can be
- check if class is already imported

GitOrigin-RevId: 11a43bf80302194a4f8b34125de2bb741f1f3bac
2024-08-09 11:00:42 +00:00
Bas Leijdekkers
91cff4a4f1 Java: inspection for migration to Markdown documentation comments (IDEA-357191)
GitOrigin-RevId: 94d6c21d713073df58e2f6fb2bbd348a7039b9ce
2024-08-08 20:19:46 +00:00
Bas Leijdekkers
c122a5897f Java: remove heavily broken code from test data(IDEA-305898)
GitOrigin-RevId: 4bffa1842be6eaa4e9a48b8b5ee0ec381a6ff93f
2024-08-01 12:35:28 +00:00
Mikhail Pyltsin
4a9f1b4fee [java-inspections] IDEA-356945 'insert default branch' suggests uncompilable code
GitOrigin-RevId: 44f277da31601775e3ce75021155bf7c37a6311c
2024-08-01 12:29:33 +00:00
Tagir Valeev
90543d0e24 [java-inspections] InlineVariableFix: avoid PSI writes after highlighting
Highlighting causes PSI commit and reformatting. It looks like modifying PSI after that may cause problems. Probably we can fix it later in ModCommand API, but for now we can just reorder things.
Fixes IDEA-355992 "Inline variable" quick-fix doesn't work if the variable initializer is on the next line

GitOrigin-RevId: f0a2418ac5618f91291b1f74ad2168d26c612447
2024-07-31 11:41:55 +00:00
Mikhail Pyltsin
6d101f8467 [java-inspection] IDEA-356699 Support JEP 477. UnusedImportInspection doesn't support implicit imports and modules
GitOrigin-RevId: b3fbb9aea04067e704e3ef3dba9e16262e33b0c6
2024-07-25 09:33:08 +00:00
Mikhail Pyltsin
ee4964a9a9 [java] UnusedImportGlobalInspectionTest convert to string block
GitOrigin-RevId: cfa22e2d932d1dad579e907d2a7e018a8e277587
2024-07-25 09:33:08 +00:00
Mikhail Pyltsin
8f3e75e7db [java-inspections] IDEA-356672 Support JEP 477. Incorrect intentions and actions with implicit imports
- improve ImplicitImportChecker to support modules
- check conflict for modules
- new method `PsiImportModuleStatement.findImportedPackage` is added

GitOrigin-RevId: 0d0f61916bdda17b8c9d9146a13aa8d6d0876bb1
2024-07-25 09:33:07 +00:00
Mikhail Pyltsin
8ce06c83bb [java-inspection] IJ-CR-135317 IDEA-352587 Support JEP 455: Improve conversion from if to switch
- fix naming
- add more tests
- check cases when variables can be assigned
- track primitive variables when new cases are created

GitOrigin-RevId: 84a77676a627cc0fffce8e7219daa2b1fd13949d
2024-07-17 18:18:57 +00:00
Mikhail Pyltsin
61eda5ef9f [java-inspections] IDEA-356142 Support several unconditional cases in "Replace if with switch"
GitOrigin-RevId: 55d493b34da246aa205be0fab09bf538d25b49fa
2024-07-10 18:15:49 +00:00
Tagir Valeev
02b38656a1 [java-inspections] ExpressionComparedToItself: do not duplicate reports of constant values (IDEA-345669)
GitOrigin-RevId: 4a7158afc602b12e7dbcf4d8d55a75c9a66f642a
2024-07-09 16:13:26 +00:00
Tagir Valeev
bc024ed383 [java-inspections] AbstractClassNeverImplementedInspection: suppress for deprecated abstract classes
GitOrigin-RevId: 4c6f5eeec061cebd203a27ae845c9a4cf394ac6b
2024-07-09 16:13:25 +00:00
Tagir Valeev
d52f6c789f [java-dfa] IDEA-355908 Add new mutation contract option: io
GitOrigin-RevId: 206fae268d8444d475a4feac6ebc5ef96ffc57bb
2024-07-04 21:05:23 +00:00
Tagir Valeev
a90638139a [java-inspections] IDEA-355789 'equals()' called on itself: disable for comparator contract test
GitOrigin-RevId: e378fb4b0a2e76698f09c911bc2cce75abead793
2024-07-02 16:37:40 +00:00
Bas Leijdekkers
fb700afa0e Java: don't warn about infinite recursion on red code
GitOrigin-RevId: b136b315a1213d2526581b7281bbc81161dfb57e
2024-06-28 17:14:56 +00:00