This property is not needed as we don't want to expose the information about the internal interface. If the internal interface is needed, an explicit cast to `WorkspaceModelInternal` can be done
GitOrigin-RevId: 8bc63e258e4fd5fa69e9379b3548433c62da922b
The library may be disposed from the moment it got into the queue till the moment it's processed
GitOrigin-RevId: fe8a580766a267db11fb095ca71b589d17a34bbc
The NPW JDK combo can register a JDK if none were registered. This needs to be taken into account in tests #tearDown.
GitOrigin-RevId: bc407e3d7e18e192ab8bacc3e3e4f24803ca9de7
ProjectStructureDaemonAnalyzer often gets all modules of the current project
for update at once. If there are quite a lot of them (e.g., 5k), MergingUpdateQueue
wastes a huge amount of time trying to merge them one by one with complicated rules,
though the rules are extremely simple in our case: it's enough to just check updates
for equality. A simple hash map works great for this task.
So, I added SimpleMergingQueue.
This fix helps to reduce queueing tasks for intellij monorepo from ~6sec to less than
0.1sec.
GitOrigin-RevId: 33eaf1e7ccc66a1edb28addf7bbaedd00444a30b
This fixes "Test method isn't public: test_rename$lambda$..." warning which was shown because JUnit3 treats synthetic methods generated from lambdas as test methods.
GitOrigin-RevId: 2e1b874d3dfab9949833609ee155935aada60d85
To get a version of the storage, `currentSnapshot` should be used.
`WorkspaceModelImpl` and `VersionedEntityStorage` are marked as internal. `WorspaceModelImpl` should has an internal modifier, but this is currently not possible because Rider overrides it. `VersionedEntityStorage` may be removed in future at all.
There are some cases when the version of the storage is accessed. Probably we can create a special function to return an entity storage with its version.
This is a part of IJPL-345
GitOrigin-RevId: cc3d6c47099c91c54d571d7ca13c5ef9d84265a9
The new version of the new project wizard has been stable for more than a year. Anymore, we don't need fallback to old one.
GitOrigin-RevId: ac90eef05671f96d4c13f823fd9e8bc671efa184
Each modifiable model of library roots retains about 13Mb of data. Collecting batches 100 of these models is not feasible.
This reverts commit 35fd310b73b424ad695b7a9c550c76b78f217d4d.
GitOrigin-RevId: 09570b747365c37bcd489cf531337ba3da269fd2
Extract commit actions of model modification (editor.commit) and batch them in portions of 100 models per write action.
GitOrigin-RevId: 35fd310b73b424ad695b7a9c550c76b78f217d4d
There is no need to rewrite existing external annotations root when it does not really change
closes#2497
GitOrigin-RevId: 4f72d6139425d52c06379b72a2832acb2f6577ff
In Android Plugin version Giraffe Beta 2, AndroidSdkType is changed to decouple AndroidSdkType from JdkSdkType, and it now extends from SdkType instead of JavaDependentSdkType.
This caused Gradle JVM lookup to fail in the GradleJvmResolutionUtil#setupGradleJvm setup method.
Main reason of failure is that JdkAuto#createResolver method, which is used during SDK lookup, didn't handle scenario when there are more than one non-simple registered Java SDKs(Now we have two candidates: Java SDK and Android SDK).
When JdkAuto#createResolverImpl is invoked it returns null, because
Android Sdk and Java Sdk both evaluate to true for SimpleJavaSdkType#notSimpleJavaSdkTypeIfAlternativeExistsAndNotDependentSdkType call.
With this new change when multiple non simpleSdkType we pick a first SDK candidate available and proceed.
GitOrigin-RevId: 0ed9bd5313ac99ccb7f7c9c95c9d0ad20fe0874d
The rename of the packages is needed to follow the naming convention. See the attached ticket for the details.
GitOrigin-RevId: 24b2328e572efa23d67133fc495855cf662ea795
* Show fewer info notifications
* Make all operations non-modal
* Resolve libraries if absent instead of showing error before checksum computation
* Remove useless "rebuild existing checksums" action
* Get rid of deprecated Platform API usages
* Add info logging
GitOrigin-RevId: 8f4f2ec3172d8aec9a88957dc9b326c9e0bbf18a
...and add necessary checks. This fixes NullPointerException, which may happen if there is an InvalidFacetConfiguration without a configuration tag (reproduced in IntelliJConfigurationFilesFormatTest).
GitOrigin-RevId: 804d3271e97c8415a22e130ffd4ddddf93e944df
Some plugin writers occasionally chooses wrong property. For example build-system from Java language instead of Scala.
GitOrigin-RevId: a92e2b974a1c782271a5b8e6e9dde15617592e0a
Instead of forcing user to enable checksums manually, we decided to
build them automatically when library is added or changed. Same for
repository binding if it was not bind before.
RepositoryLibraryUtils are refactored, notifications'
messages made more detailed.
GitOrigin-RevId: 549a73749db08437ed0d8b3f61ca0da9aa5d1a1e
We don't want to force developers update checksums and
select bind repository manually when we can do this
automatically in listener when new library is added.
GitOrigin-RevId: 5af3ed3e12e4861819b3ce648870280c77a25231
Reload has side effect: it may change library roots.
In the context of out remote repository it's enough
to check whether library can be resolved, but not reload it.
GitOrigin-RevId: 6664aa77b835a26e003c40e72e22edf85219f7f2
Nikita Iarychenko
Tagir Valeev
Max Medvedev
Lev Serebryakov
Alex Plate
Vladimir Krivosheev
Louis Vignier
Andrei.Kuznetsov
Nikolay Chashnikov
Sergei Vorobyov
Mikhail Mazurkevich
Vladislav.Yaroshchuk
Nikita.Skvortsov
Roman Shevchenko
Nebojsa.Vuksic
Alexey Belkov
Bart van Helvert
Daniil Ovchinnikov