MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-11075 Class must implement all abstract methods: false negative for abstract decorators defined with fqn moved test data to the proper place

Browse Source
This commit is contained in:
Ekaterina Tuzova
2013-10-11 14:20:41 +04:00
parent 33a3ecf730
commit fe2852a7bb
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyAbstractClassInspection.java
+8 -2
View File
@@ -10,8 +10,10 @@ import com.jetbrains.python.PyNames;
import com.jetbrains.python.codeInsight.override.PyOverrideImplementUtil; import com.jetbrains.python.codeInsight.override.PyOverrideImplementUtil;
import com.jetbrains.python.inspections.quickfix.PyImplementMethodsQuickFix; import com.jetbrains.python.inspections.quickfix.PyImplementMethodsQuickFix;
import com.jetbrains.python.psi.PyClass; import com.jetbrains.python.psi.PyClass;
import com.jetbrains.python.psi.PyDecorator;
import com.jetbrains.python.psi.PyDecoratorList; import com.jetbrains.python.psi.PyDecoratorList;
import com.jetbrains.python.psi.PyFunction; import com.jetbrains.python.psi.PyFunction;
import com.jetbrains.python.psi.impl.PyQualifiedName;
import org.jetbrains.annotations.Nls; import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable; import org.jetbrains.annotations.Nullable;
@@ -51,8 +53,12 @@ public class PyAbstractClassInspection extends PyInspection {
for (PyFunction method : functions) { for (PyFunction method : functions) {
final PyDecoratorList list = method.getDecoratorList(); final PyDecoratorList list = method.getDecoratorList();
if (list != null && node.findMethodByName(method.getName(), false) == null) { if (list != null && node.findMethodByName(method.getName(), false) == null) {
if (list.findDecorator(PyNames.ABSTRACTMETHOD) != null || list.findDecorator(PyNames.ABSTRACTPROPERTY) != null) { for (PyDecorator decorator : list.getDecorators()) {
toBeImplemented.add(method); final PyQualifiedName qualifiedName = decorator.getQualifiedName();
if (qualifiedName != null && (PyNames.ABSTRACTMETHOD.equals(qualifiedName.getLastComponent()) || PyNames.ABSTRACTPROPERTY.equals(
qualifiedName.getLastComponent()))) {
toBeImplemented.add(method);
}
} }
} }
} }