EqualityCheck extracted and used in various inspections, other fixes

EqualsCalledOnEnumValueFix replaced with EqualsToEqualityFix which does the same
This commit is contained in:
Tagir Valeev
2018-03-27 15:01:56 +07:00
parent 3d0dc4ebf4
commit f61a13bfcd
20 changed files with 305 additions and 202 deletions
@@ -0,0 +1,22 @@
// "Fix all ''equals()' called on 'java.math.BigDecimal'' problems in file" "true"
import java.math.BigDecimal;
import java.util.Objects;
class BigDecimalEquals {
public void foo(BigDecimal qux)
{
final BigDecimal foo = new BigDecimal(3);
final BigDecimal bar = new BigDecimal(3);
foo.equals(bar);
if(foo.compareTo(bar) == 0)
{
return;
}
if(!(foo.compareTo(bar) == 0)) {
System.out.println("not equals");
}
if(qux != null && qux.compareTo(bar) == 0) {
System.out.println("equals");
}
}
}
@@ -0,0 +1,22 @@
// "Fix all ''equals()' called on 'java.math.BigDecimal'' problems in file" "true"
import java.math.BigDecimal;
import java.util.Objects;
class BigDecimalEquals {
public void foo(BigDecimal qux)
{
final BigDecimal foo = new BigDecimal(3);
final BigDecimal bar = new BigDecimal(3);
foo.equals(bar);
if(foo.eq<caret>uals(bar))
{
return;
}
if(!Objects.equals(foo, bar)) {
System.out.println("not equals");
}
if(Objects.equals(qux, bar)) {
System.out.println("equals");
}
}
}