Java: Don't create parameters for effectively local variables in extracted fragment (IDEA-180864)

2026-09-18 09:34:34 +07:00 · 2017-10-24 17:23:19 +03:00
parent 5fab484adf
commit f2eb220e2b
9 changed files with 188 additions and 14 deletions
@@ -0,0 +1,48 @@
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.util.Scanner;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class EffectivelyLocalVariables {
+    void test() {
+        Scanner inputStreamScanner = null;
+        String theFirstLineFromDestinationFile;
+        String originContent = "aaa";
+        String fileName = "bbb";
+
+        ddd(originContent, fileName);
+    }
+
+    private void ddd(String originContent, String fileName) {
+        Scanner inputStreamScanner;
+        String theFirstLineFromDestinationFile;
+        <selection>try {
+            inputStreamScanner =
+              new Scanner(new File(fileName));
+            theFirstLineFromDestinationFile = inputStreamScanner.nextLine();
+            assertEquals(theFirstLineFromDestinationFile, originContent);
+        } catch (FileNotFoundException e) {
+            e.printStackTrace();
+        }</selection>
+    }
+
+    void dup() {
+        Scanner inputStreamScanner = null;
+        String theFirstLineFromDestinationFile;
+        String originContent = "";
+        String fileName = "";
+
+        try {
+            inputStreamScanner =
+              new Scanner(
+                new File(fileName));
+            theFirstLineFromDestinationFile = inputStreamScanner.nextLine();
+            // destination should contain original file's content
+            assertEquals(theFirstLineFromDestinationFile, originContent);
+        } catch (FileNotFoundException e) {
+            e.printStackTrace();
+        }
+
+    }
+}