MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-01 18:58:31 +07:00
Code Issues Packages Projects Releases Wiki Activity

[kotlin] ensure that UastCallableReferenceExpression preserves receiver expression

Browse Source 
- uast based visitor in unused declaration should analyse receivers which might contain references to variables/functions/etc

- Currently simple references in receivers are not processed and thus test has false positive

^ KTIJ-23958

- KotlinJavaApiUsageInspectionTest.`test reference in callable reference` doesn't test actual problem because UastVisitorAdapter is used: meaning that psi hierarchy is traversed and converted to uast one-by-one.

GitOrigin-RevId: 01b2c31fe42181c428b2c8767dc18db73bdfd659
This commit is contained in:
Anna Kozlova
2023-07-31 10:10:56 +02:00
committed by intellij-monorepo-bot
parent f44c63348e
commit e2d7214918
6 changed files with 50 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
java/java-analysis-impl/src/com/intellij/codeInspection/reference/RefJavaUtilImpl.java
View File

@@ -248,6 +248,10 @@ public class RefJavaUtilImpl extends RefJavaUtil {
@Override
public boolean visitCallableReferenceExpression(@NotNull UCallableReferenceExpression methodRef) {
UExpression qualifierExpression = methodRef.getQualifierExpression();
if (qualifierExpression != null) {
qualifierExpression.accept(this);
}
RefElement refMethod = refManager.getReference(methodRef.getSourcePsi());
if (refFrom == refMethod) {
visitReferenceExpression(methodRef);
@@ -641,18 +645,17 @@ public class RefJavaUtilImpl extends RefJavaUtil {
return Integer.compare(getAccessNumber(a1), getAccessNumber(a2));
}
@SuppressWarnings("StringEquality")
private static int getAccessNumber(String a) {
if (a == PsiModifier.PRIVATE) {
if (PsiModifier.PRIVATE.equals(a)) {
return 0;
}
if (a == PsiModifier.PACKAGE_LOCAL) {
if (PsiModifier.PACKAGE_LOCAL.equals(a)) {
return 1;
}
if (a == PsiModifier.PROTECTED) {
if (PsiModifier.PROTECTED.equals(a)) {
return 2;
}
if (a == PsiModifier.PUBLIC) return 3;
if (PsiModifier.PUBLIC.equals(a)) return 3;
return -1;
}