RedundantExplicitCloseInspection: support parentheses in close(); fixed support of resource expression; check field qualifiers

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantExplicitClose/afterRemoveTry.java

@@ -2,7 +2,7 @@
 
 class MyAutoCloseable implements AutoCloseable {
   @Override
-  void close() {
+  public void close() {
 
   }
 }

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantExplicitClose/afterRemoveTryFieldJava9.java

@@ -0,0 +1,18 @@
+// "Remove redundant close" "true"
+
+class MyAutoCloseable implements AutoCloseable {
+  @Override
+  public void close() {
+
+  }
+}
+
+class RemoveTry {
+  final MyAutoCloseable ac;
+
+  public void main(RemoveTry other) {
+    try(other.ac) {
+      System.out.println("asdasd");
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantExplicitClose/afterRemoveTryJava9.java

@@ -0,0 +1,16 @@
+// "Remove redundant close" "true"
+
+class MyAutoCloseable implements AutoCloseable {
+  @Override
+  public void close() {
+
+  }
+}
+
+class RemoveTry {
+  public static void main(MyAutoCloseable ac) {
+    try(ac) {
+      System.out.println("asdasd");
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantExplicitClose/beforeRemoveTry.java

@@ -2,7 +2,7 @@
 
 class MyAutoCloseable implements AutoCloseable {
   @Override
-  void close() {
+  public void close() {
 
   }
 }
@@ -11,7 +11,7 @@ class RemoveTry {
   public static void main(String[] args) {
     try(MyAutoCloseable ac = new MyAutoCloseable()) {
       System.out.println("asdasd");
-      ac.close<caret>();
+      (ac).close<caret>();
     }
   }
 }

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantExplicitClose/beforeRemoveTryField2Java9.java

@@ -0,0 +1,19 @@
+// "Remove redundant close" "false"
+
+class MyAutoCloseable implements AutoCloseable {
+  @Override
+  public void close() {
+
+  }
+}
+
+class RemoveTry {
+  final MyAutoCloseable ac;
+
+  public void main(RemoveTry other) {
+    try(other.ac) {
+      System.out.println("asdasd");
+      this.ac.clo<caret>se();
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantExplicitClose/beforeRemoveTryFieldJava9.java

@@ -0,0 +1,19 @@
+// "Remove redundant close" "true"
+
+class MyAutoCloseable implements AutoCloseable {
+  @Override
+  public void close() {
+
+  }
+}
+
+class RemoveTry {
+  final MyAutoCloseable ac;
+
+  public void main(RemoveTry other) {
+    try(other.ac) {
+      System.out.println("asdasd");
+      other.ac.clo<caret>se();
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantExplicitClose/beforeRemoveTryJava9.java

@@ -0,0 +1,17 @@
+// "Remove redundant close" "true"
+
+class MyAutoCloseable implements AutoCloseable {
+  @Override
+  public void close() {
+
+  }
+}
+
+class RemoveTry {
+  public static void main(MyAutoCloseable ac) {
+    try(ac) {
+      System.out.println("asdasd");
+      (ac).close<caret>();
+    }
+  }
+}