MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Revert incorrect fixes for IDEA-184723 Data flow algorithm complexity

Browse Source 
This reverts commits 9a837e70d3 and 6d52b5462e.
This commit is contained in:
Tagir Valeev
2018-01-11 10:21:08 +07:00
parent 3108674de2
commit d7fba34d4c
5 changed files with 0 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-tests/testData/inspection/dataFlow/fixture/NullabilityBasics.java
-31
View File
@@ -1,31 +0,0 @@
import org.jetbrains.annotations.*;
class NullabilityBasics {
void test2() {
String x = getNullable();
if (x == null) {
System.out.println("x is null!");
}
if (isEmpty(x) && Math.random() > 0.5) {
return;
}
System.out.println(x.<warning descr="Method invocation 'trim' may produce 'java.lang.NullPointerException'">trim</warning>());
}
@Nullable String getNullable() {
return Math.random() > 0.5 ? null : "";
}
@Contract(value = "null -> true",pure = true)
static boolean isEmpty(@Nullable String s) {
return s == null || s.isEmpty();
}
void test(String x) {
if (x == null) {
System.out.println("x is null!");
}
System.out.println(x.<warning descr="Method invocation 'trim' may produce 'java.lang.NullPointerException'">trim</warning>());
}
}
java/java-tests/testData/inspection/dataFlow/fixture/OptionalTooComplex.java
-48
View File
@@ -1,48 +0,0 @@
import java.util.Optional;
// IDEA-184723
class OptionalTooComplex {
// Should not be too complex
public Long fetch() {
final PreparedStatement ps = builder
.setInteger(<warning descr="Argument 'opt().orElse(null)' might be null but passed to non annotated parameter">opt().orElse(null)</warning>)
.setInteger(<warning descr="Argument 'opt().orElse(null)' might be null but passed to non annotated parameter">opt().orElse(null)</warning>)
.setInteger(<warning descr="Argument 'opt().orElse(null)' might be null but passed to non annotated parameter">opt().orElse(null)</warning>)
.setInteger(<warning descr="Argument 'opt().orElse(null)' might be null but passed to non annotated parameter">opt().orElse(null)</warning>)
.setInteger(<warning descr="Argument 'opt().orElse(null)' might be null but passed to non annotated parameter">opt().orElse(null)</warning>)
.build();
ResultSet rs = null;
try {
rs = ps.executeQuery();
if (rs.next()) {
return rs.getLong();
}
} catch (final Exception e) {
throw new RuntimeException(e);
} finally {
}
return 0L;
}
interface ResultSet {
boolean next() throws Exception;
long getLong() throws Exception;
}
interface PreparedStatement {
ResultSet executeQuery() throws Exception;
}
native Optional<Integer> opt();
interface QueryBuilder {
QueryBuilder setInteger(Integer value);
PreparedStatement build();
}
QueryBuilder builder;
}