MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-30 18:28:55 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java] Support varargs and named arguments in SameParameterValueInspection

Browse Source 
#KTIJ-13986 Fixed.

GitOrigin-RevId: 91663d30b62cdd067a7ec447b65edfcc9b2bba9a
This commit is contained in:
Bart van Helvert
2023-02-16 15:25:25 +01:00
committed by intellij-monorepo-bot
parent 73928dcc35
commit d34ad5345e
10 changed files with 150 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
java/java-analysis-impl/src/com/intellij/codeInspection/reference/RefJavaUtilImpl.java
View File

@@ -47,7 +47,7 @@ public class RefJavaUtilImpl extends RefJavaUtil {
element.accept(new AbstractUastVisitor() {
@Override
public boolean visitEnumConstant(@NotNull UEnumConstant node) {
processNewLikeConstruct(node.resolve(), node.getValueArguments());
processNewLikeConstruct(node.resolve(), node);
return false;
}
@@ -166,8 +166,7 @@ public class RefJavaUtilImpl extends RefJavaUtil {
}
if (node.getKind() == UastCallKind.CONSTRUCTOR_CALL) {
PsiElement resolvedMethod = returnToPhysical(node.resolve());
final List<UExpression> argumentList = node.getValueArguments();
RefMethod refConstructor = processNewLikeConstruct(resolvedMethod, argumentList);
RefMethod refConstructor = processNewLikeConstruct(resolvedMethod, node);
if (refConstructor == null) { // No explicit constructor referenced. Should use default one.
UReferenceExpression reference = node.getClassReference();
@@ -275,19 +274,19 @@ public class RefJavaUtilImpl extends RefJavaUtil {
}
@Nullable
private RefMethod processNewLikeConstruct(PsiElement javaConstructor, List<UExpression> argumentList) {
private RefMethod processNewLikeConstruct(PsiElement javaConstructor, UCallExpression call) {
if (javaConstructor == null) return null;
RefMethodImpl refConstructor =
ObjectUtils.tryCast(refManager.getReference(javaConstructor.getOriginalElement()), RefMethodImpl.class);
refFrom.addReference(refConstructor, javaConstructor, decl, false, true, null);
for (UExpression arg : argumentList) {
for (UExpression arg : call.getValueArguments()) {
arg.accept(this);
}
if (refConstructor != null) {
refConstructor.initializeIfNeeded();
refConstructor.updateParameterValues(argumentList, javaConstructor);
refConstructor.updateParameterValues(call, javaConstructor);
}
return refConstructor;
}
@@ -454,9 +453,8 @@ public class RefJavaUtilImpl extends RefJavaUtil {
call = ObjectUtils.tryCast(qualifiedReference.getSelector(), UCallExpression.class);
}
if (call != null) {
List<UExpression> argumentList = call.getValueArguments();
if (!argumentList.isEmpty()) {
refMethod.updateParameterValues(argumentList, psiResolved);
if (!call.getValueArguments().isEmpty()) {
refMethod.updateParameterValues(call, psiResolved);
}
final PsiType usedType = call.getReceiverType();