MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 22:51:17 +07:00
Code Issues Packages Projects Releases Wiki Activity

HardcodedContracts#isHardcodedPure: Arrays methods properly marked

Browse Source
This commit is contained in:
Tagir Valeev
2017-05-25 14:36:22 +07:00
parent 445846597a
commit d235bc08ae
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/HardcodedContracts.java
View File

@@ -18,7 +18,6 @@ package com.intellij.codeInspection.dataFlow;
import com.intellij.codeInspection.dataFlow.value.DfaRelationValue.RelationType;
import com.intellij.lang.injection.InjectedLanguageManager;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiUtil;
import com.intellij.util.containers.ContainerUtil;
import com.siyeh.ig.psiutils.ExpressionUtils;
import com.siyeh.ig.psiutils.MethodUtils;
@@ -302,18 +301,25 @@ public class HardcodedContracts {
}
public static boolean isHardcodedPure(PsiMethod method) {
String qName = PsiUtil.getMemberQualifiedName(method);
if ("java.lang.System.exit".equals(qName)) {
return false;
}
PsiClass aClass = method.getContainingClass();
if (aClass == null) return false;
String className = aClass.getQualifiedName();
if (className == null) return false;
String name = method.getName();
if ("java.util.Objects.requireNonNull".equals(qName)) {
if ("java.util.Objects".equals(className) && "requireNonNull".equals(name)) {
PsiParameter[] parameters = method.getParameterList().getParameters();
if (parameters.length == 2 && parameters[1].getType().getCanonicalText().contains("Supplier")) {
return false;
}
}
if ("java.lang.System".equals(className)) {
return false;
}
if (CommonClassNames.JAVA_UTIL_ARRAYS.equals(className)) {
return name.equals("binarySearch") || name.equals("spliterator") || name.equals("stream");
}
return true;
}