prefer expected type generics suggestions in java completion, overwrite existing type arguments (IDEA-145119)

java/java-tests/testData/codeInsight/completion/smartType/TypeArgsOverwrite-out.java

@@ -0,0 +1,9 @@
+import java.util.*;
+
+class Foo {
+
+    void bar() {
+        Map<Integer, String> a = new HashMap<Integer, String>(<caret>);
+    }
+
+}

java/java-tests/testData/codeInsight/completion/smartType/TypeArgsOverwrite.java

@@ -0,0 +1,9 @@
+import java.util.*;
+
+class Foo {
+
+    void bar() {
+        Map<Integer, String> a = new HashMap<<caret>, String>();
+    }
+
+}

java/java-tests/testSrc/com/intellij/codeInsight/completion/NormalCompletionTest.groovy

@@ -1324,8 +1324,7 @@ class XInternalError {}
 
   public void testSuggestAllTypeArguments() {
     configure()
-    assert 'String, String' == lookup.items[1].lookupString
-    lookup.currentItem = lookup.items[1]
+    assert 'String, String' == lookup.items[0].lookupString
     type '\n'
     checkResult()
   }

java/java-tests/testSrc/com/intellij/codeInsight/completion/SmartTypeCompletionTest.java

@@ -909,6 +909,7 @@ public class SmartTypeCompletionTest extends LightFixtureCompletionTestCase {
   public void testTypeArgs2() throws Exception {
     doTest();
   }
+  public void testTypeArgsOverwrite() { doTest(); }
 
   public void testIfConditionExpectedType() throws Exception { doTest(); }