MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-03 03:37:58 +07:00
Code Issues Packages Projects Releases Wiki Activity

[codeInsight] IDEA-240288 Inspection for StringBuilder.toString().substring()

Browse Source 
This patch replaces the excessive extraction of a qualifier via `ExpressionUtils.getEffectiveQualifier` with a simple `call.getMethodExpression().getQualifierExpression`

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 4a4f1c6b218c63691fa2bd4610e9901874d3c712
This commit is contained in:
Nikita Eshkeev
2020-05-15 14:56:41 +03:00
committed by intellij-monorepo-bot
parent b12dfe5539
commit ce7dae26b1
3 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantStringOperation/afterStringBuilderToString.java
View File

@@ -27,6 +27,8 @@ class StringBuilderToString {
System.out.println(new StringBuilder().substring(1, 3).length());
"hello".substring(sb.toString());
System.out.println((((new StringBuilder()))).substring(1, 3));
System.out.println((new StringBuilder()).substring(1, 3).length());
}
void builder(StringBuilder sb) {

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantStringOperation/beforeStringBuilderToString.java
View File

@@ -20,6 +20,8 @@ class StringBuilderToString {
System.out.println(new StringBuilder().substring(1, 3).length());
"hello".substring(sb.toString());
System.out.println((((new StringBuilder()))).substring(1, 3));
System.out.println((new StringBuilder()).substring(1, 3).length());
}
void builder(StringBuilder sb) {