MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 14:23:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

[uast-inspections] IDEA-134025 Quickfix for "Log condition does not match logging call"

Browse Source 
GitOrigin-RevId: 9bf9f012525aab45167daf84dd13ebd0a8c135fa
This commit is contained in:
Mikhail Pyltsin
2024-01-08 18:32:03 +01:00
committed by intellij-monorepo-bot
parent e6597bc5a8
commit cb7187787c
5 changed files with 354 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

111
jvm/jvm-analysis-java-tests/testSrc/com/intellij/codeInspection/tests/java/logging/JavaLoggingConditionDisagreesWithLogLevelStatementInspectionTest.kt
View File

@@ -1,5 +1,6 @@
package com.intellij.codeInspection.tests.java.logging
import com.intellij.analysis.JvmAnalysisBundle
import com.intellij.jvm.analysis.internal.testFramework.logging.LoggingConditionDisagreesWithLogLevelStatementInspectionTestBase
import com.intellij.jvm.analysis.testFramework.JvmLanguage
@@ -123,6 +124,114 @@ class JavaLoggingConditionDisagreesWithLogLevelStatementInspectionTest : Logging
}
}
}
""".trimIndent())
""".trimIndent())
}
fun `test fixes log4j2 change calls`() {
myFixture.testQuickFix(
testPreview = true,
lang = JvmLanguage.JAVA,
before = """
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
class Logging {
private static final Logger LOG = LogManager.getLogger();
private static void request1(String i) {
String msg = "log messages2: {}";
if (LOG.is<caret>DebugEnabled()) {
LOG.info(msg, i);
}
}
}""".trimIndent(),
after = """
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
class Logging {
private static final Logger LOG = LogManager.getLogger();
private static void request1(String i) {
String msg = "log messages2: {}";
if (LOG.isDebugEnabled()) {
LOG.debug(msg, i);
}
}
}""".trimIndent(),
hint = JvmAnalysisBundle.message("jvm.inspection.logging.condition.disagrees.with.log.statement.fix.name", 1)
)
}
fun `test fixes log4j2 change guards`() {
myFixture.testQuickFix(
testPreview = true,
lang = JvmLanguage.JAVA,
before = """
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
class Logging {
private static final Logger LOG = LogManager.getLogger();
private static void request1(String i) {
String msg = "log messages2: {}";
if (LOG.is<caret>DebugEnabled()) {
LOG.info(msg, i);
}
}
}""".trimIndent(),
after = """
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
class Logging {
private static final Logger LOG = LogManager.getLogger();
private static void request1(String i) {
String msg = "log messages2: {}";
if (LOG.isInfoEnabled()) {
LOG.info(msg, i);
}
}
}""".trimIndent(),
hint = JvmAnalysisBundle.message("jvm.inspection.logging.condition.disagrees.with.log.statement.fix.name", 0)
)
}
fun `test fixes slf4j change guards`() {
myFixture.testQuickFix(
testPreview = true,
lang = JvmLanguage.JAVA,
before = """
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
class Slf4J {
private final static Logger log = LoggerFactory.getLogger(Slf4J.class);
private static void request1(String i) {
String msg = "log messages2: {}";
if (log.is<caret>DebugEnabled()) {
log.info(msg, i);
}
}
}""".trimIndent(),
after = """
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
class Slf4J {
private final static Logger log = LoggerFactory.getLogger(Slf4J.class);
private static void request1(String i) {
String msg = "log messages2: {}";
if (log.isInfoEnabled()) {
log.info(msg, i);
}
}
}""".trimIndent(),
hint = JvmAnalysisBundle.message("jvm.inspection.logging.condition.disagrees.with.log.statement.fix.name", 0)
)
}
}