MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-09 08:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

[debugger] do not leak results values in helper - fixes for review

Browse Source 
GitOrigin-RevId: d75d1b9f361c8382afe420779c69ea3e6fafbb8f
This commit is contained in:
Egor Ushakov
2025-02-11 16:36:15 +01:00
committed by intellij-monorepo-bot
parent c8c9b54efb
commit cb646fee57
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
java/java-runtime/src/com/intellij/rt/debugger/MethodInvoker.java
View File

@@ -234,8 +234,13 @@ public final class MethodInvoker {
private static Object keepReference(Object ref, boolean soft) {
List<Object> objects = keptValues.get();
removeStaleReferences(objects);
Object wrapper = soft ? new SoftReference<>(ref) : new Object[]{ref};
objects.add(wrapper);
return wrapper;
}
// remove stale references first
private static void removeStaleReferences(List<Object> objects) {
Iterator<Object> iterator = objects.iterator();
while (iterator.hasNext()) {
Object object = iterator.next();
@@ -250,9 +255,5 @@ public final class MethodInvoker {
}
}
}
Object wrapper = soft ? new SoftReference<>(ref) : new Object[]{ref};
objects.add(wrapper);
return soft ? ref : wrapper;
}
}