remove redundant suppressions

2026-09-27 10:03:11 +07:00 · 2018-10-04 12:09:46 +02:00
parent 101277a1a0
commit c4b7de202d
862 changed files with 302 additions and 1271 deletions
@@ -138,7 +138,6 @@ public final class LwXmlReader {
    final String str = getRequiredString(element, attributeName);
    try {
      final Method method = valueClass.getMethod("valueOf", new Class[]{String.class});
-      //noinspection unchecked
      return method.invoke(null, new Object[]{str});
    }
    catch (NumberFormatException e) {
@@ -33,17 +33,13 @@ public class BuildPropertiesImpl extends BuildProperties {
  public BuildPropertiesImpl(Project project, final GenerationOptions genOptions) {
    add(new Property(genOptions.getPropertiesFileName()));

-    //noinspection HardCodedStringLiteral
    add(new Comment(CompilerBundle.message("generated.ant.build.disable.tests.property.comment"),
                    new Property(PROPERTY_SKIP_TESTS, "true")));
    final JpsJavaCompilerOptions javacSettings = JavacConfiguration.getOptions(project, JavacConfiguration.class);
    add(new Comment(CompilerBundle.message("generated.ant.build.compiler.options.comment")), 1);
-    //noinspection HardCodedStringLiteral
    add(new Property(PROPERTY_COMPILER_GENERATE_DEBUG_INFO, javacSettings.DEBUGGING_INFO ? "on" : "off"), 1);
-    //noinspection HardCodedStringLiteral
    add(new Property(PROPERTY_COMPILER_GENERATE_NO_WARNINGS, javacSettings.GENERATE_NO_WARNINGS ? "on" : "off"));
    add(new Property(PROPERTY_COMPILER_ADDITIONAL_ARGS, javacSettings.ADDITIONAL_OPTIONS_STRING));
-    //noinspection HardCodedStringLiteral
    final int heapSize = CompilerConfiguration.getInstance(project).getBuildProcessHeapSize(javacSettings.MAXIMUM_HEAP_SIZE);
    add(new Property(PROPERTY_COMPILER_MAX_MEMORY, heapSize + "m"));

@@ -47,7 +47,6 @@ public class ModuleChunkClasspath extends Path {
   * @param generateRuntimeClasspath if true, runtime classpath is being generated. Otherwise a compile time classpath is constructed
   * @param generateTestClasspath    if true, a test classpath is generated.
   */
-  @SuppressWarnings({"unchecked"})
  public ModuleChunkClasspath(final ModuleChunk chunk,
                              final GenerationOptions genOptions,
                              final boolean generateRuntimeClasspath,
@@ -93,7 +93,6 @@ public abstract class ProjectBuild extends Generator {

  @Override
  public void generate(PrintWriter out) throws IOException {
-    //noinspection HardCodedStringLiteral
    writeXmlHeader(out);
    myAntProject.generate(out);
  }
@@ -150,7 +150,6 @@ public class OperationChain {
    return Arrays.toString(path) + " on " + myQualifierClass.getName();
  }

-  @SuppressWarnings("ConstantConditions")
  public static CompareResult compare(@NotNull OperationChain left, @NotNull OperationChain right) {
    if (left.length() == 0 || right.length() == 0) {
      throw new IllegalStateException("chains can't be empty");
@@ -38,7 +38,6 @@ public abstract class BuildTargetScopeProvider {
   * @deprecated override {@link #getBuildTargetScopes(CompileScope, Project, boolean)} instead
   */
  @Deprecated
-  @SuppressWarnings("DeprecatedIsStillUsed")
  @NotNull
  public List<TargetTypeBuildScope> getBuildTargetScopes(@NotNull CompileScope baseScope, @NotNull CompilerFilter filter,
                                                                  @NotNull Project project) {
@@ -584,7 +584,6 @@ public class InstrumentationClassFinder {
    private static class FileLoader extends Loader {
      private final File myRootDir;

-      @SuppressWarnings({"HardCodedStringLiteral"})
      FileLoader(URL url, int index) throws IOException {
        super(url, index);
        if (!FILE_PROTOCOL.equals(url.getProtocol())) {
@@ -223,7 +223,6 @@ public abstract class BuildProperties extends CompositeGenerator {
   */
  @NonNls
  public static String convertName(@NonNls final String name) {
-    //noinspection HardCodedStringLiteral
    return name.replaceAll("\"", "").replaceAll("\\s+", "_").toLowerCase();
  }

@@ -86,7 +86,7 @@ public abstract class ChunkCustomCompilerExtension {
   * @param chunk a chunk to check
   * @return true if the facet requires custom comiplation.
   */
-  @SuppressWarnings({"UnusedDeclaration", "MethodMayBeStatic"})
+  @SuppressWarnings({"UnusedDeclaration"})
  public abstract boolean hasCustomCompile(final ModuleChunk chunk);

  /**
@@ -22,7 +22,6 @@ import com.intellij.openapi.util.Couple;
 /**
 * @author Eugene Zhuravlev
 */
-@SuppressWarnings({"HardCodedStringLiteral"})
 public class AntCall extends Tag{

  public AntCall(final String target) {
@@ -25,7 +25,6 @@ import org.jetbrains.annotations.NonNls;
 */
 public class Attribute extends Tag{
  public Attribute(@NonNls String name, String value) {
-    //noinspection HardCodedStringLiteral
    super("attribute", Couple.of("name", name), Couple.of("value", value));
  }
 }
@@ -25,7 +25,6 @@ import org.jetbrains.annotations.NonNls;
 */
 public class Delete extends Tag{
  public Delete(@NonNls String dir) {
-    //noinspection HardCodedStringLiteral
    super("delete", Couple.of("dir", dir));
  }
 }
@@ -26,7 +26,6 @@ import org.jetbrains.annotations.NonNls;
 public class DirSet extends Tag{

  public DirSet(@NonNls final String dir) {
-    //noinspection HardCodedStringLiteral
    super("dirset", Couple.of("dir", dir));
  }
 }
@@ -25,7 +25,6 @@ import org.jetbrains.annotations.NonNls;
 */
 public class Dirname extends Tag{
  public Dirname(@NonNls String property, @NonNls String file) {
-    //noinspection HardCodedStringLiteral
    super("dirname", Couple.of("property", property), Couple.of("file", file));
  }
 }
@@ -26,7 +26,6 @@ import org.jetbrains.annotations.NonNls;
 public class Exclude extends Tag {

  public Exclude(@NonNls final String name) {
-    //noinspection HardCodedStringLiteral
    super("exclude", Couple.of("name", name));
  }

@@ -30,7 +30,6 @@ public class Import extends Tag{
  }

  public Import(@NonNls String file) {
-    //noinspection HardCodedStringLiteral
    super("import", Couple.of("file", file));
  }
 }
@@ -25,7 +25,6 @@ import org.jetbrains.annotations.NonNls;
 */
 public class Mkdir extends Tag {
  public Mkdir(@NonNls String directory) {
-    //noinspection HardCodedStringLiteral
    super("mkdir", Couple.of("dir", directory));
  }
 }
@@ -25,7 +25,6 @@ import org.jetbrains.annotations.NonNls;
 */
 public class Param extends Tag {
  public Param(@NonNls final String name, final String value) {
-    //noinspection HardCodedStringLiteral
    super("param", Couple.of("name", name), Couple.of("value", value));
  }

@@ -25,8 +25,7 @@ import org.jetbrains.annotations.NonNls;
 public class PathElement extends Tag {

    public PathElement(@NonNls String dir) {
-        //noinspection HardCodedStringLiteral
-        super("pathelement", pair("location", dir));
+      super("pathelement", pair("location", dir));
    }

 }
@@ -26,12 +26,10 @@ import org.jetbrains.annotations.NonNls;
 public class Property extends Tag {

  public Property(@NonNls final String name, final String value) {
-    //noinspection HardCodedStringLiteral
    super("property", Couple.of("name", name), Couple.of("value", value));
  }

  public Property(@NonNls final String filePath) {
-    //noinspection HardCodedStringLiteral
    super("property", Couple.of("file", filePath));
  }

@@ -45,7 +45,6 @@ public class CompilerPaths {
   * @return a root directory where generated files for various compilers are stored
   */
  public static File getGeneratedDataDirectory(Project project) {
-    //noinspection HardCodedStringLiteral
    return new File(getCompilerSystemDirectory(project), ".generated");
  }

@@ -53,7 +52,6 @@ public class CompilerPaths {
   * @return a root directory where compiler caches for the given project are stored
   */
  public static File getCacheStoreDirectory(final Project project) {
-    //noinspection HardCodedStringLiteral
    return new File(getCompilerSystemDirectory(project), ".caches");
  }