MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-03-22 15:19:59 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java-dfa] More annotations; annotations for comparators; warn on nullity violation from methodref return

Browse Source 
GitOrigin-RevId: d0b1a4967d361f409d4d25562c595e2812fc8044
This commit is contained in:
Tagir Valeev
2024-09-19 16:11:17 +02:00
committed by intellij-monorepo-bot
parent 5b16802ed3
commit c3ecaaa190
7 changed files with 202 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/java/inst/MethodReferenceInstruction.java
View File

@@ -61,9 +61,14 @@ public class MethodReferenceInstruction extends ExpressionPushingInstruction {
NullabilityProblemKind.callMethodRefNPE.problem(methodRef, null));
}
List<? extends MethodContract> contracts = JavaMethodContractUtil.getMethodCallContracts(method, null);
if (contracts.isEmpty() || !JavaMethodContractUtil.isPure(method)) return;
PsiType returnType = substitutor.substitute(method.getReturnType());
DfaValue defaultResult = interpreter.getFactory().fromDfType(typedObject(returnType, DfaPsiUtil.getElementNullability(returnType, method)));
Nullability expectedNullability = DfaPsiUtil.getTypeNullability(LambdaUtil.getFunctionalInterfaceReturnType(methodRef));
if (expectedNullability == Nullability.NOT_NULL) {
CheckNotNullInstruction.checkNotNullable(interpreter, state, defaultResult,
NullabilityProblemKind.nullableFunctionReturn.problem(methodRef, null));
}
if (contracts.isEmpty() || !JavaMethodContractUtil.isPure(method)) return;
Set<DfaCallState> currentStates = Collections.singleton(new DfaCallState(state.createClosureState(), callArguments, defaultResult));
JavaMethodReferenceReturnAnchor anchor = new JavaMethodReferenceReturnAnchor(methodRef);
DfaValue[] args = callArguments.toArray();