MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

avoid evaluations under readAction - this may lead to UI lock when the debuggee stops responding

Browse Source
This commit is contained in:
Eugene Zhuravlev
2012-05-22 13:00:02 +02:00
parent 50040305f0
commit c31341e470
1 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/debugger/impl/src/com/intellij/debugger/ui/impl/FrameVariablesTree.java
+1 -11
View File
@@ -29,8 +29,6 @@ import com.intellij.debugger.engine.evaluation.EvaluateException;
import com.intellij.debugger.engine.evaluation.EvaluationContextImpl;
import com.intellij.debugger.engine.evaluation.TextWithImports;
import com.intellij.debugger.engine.evaluation.TextWithImportsImpl;
import com.intellij.debugger.engine.evaluation.expression.EvaluatorBuilderImpl;
import com.intellij.debugger.engine.evaluation.expression.ExpressionEvaluator;
import com.intellij.debugger.engine.events.DebuggerCommandImpl;
import com.intellij.debugger.impl.DebuggerContextImpl;
import com.intellij.debugger.impl.DebuggerSession;
@@ -523,15 +521,7 @@ public class FrameVariablesTree extends DebuggerTree {
boolean isConstant = (var instanceof PsiEnumConstant) ||
(modifierList != null && modifierList.hasModifierProperty(PsiModifier.STATIC) && modifierList.hasModifierProperty(PsiModifier.FINAL));
if (!isConstant) {
final TextWithImportsImpl textWithImports = new TextWithImportsImpl(reference);
try {
final ExpressionEvaluator evaluator = EvaluatorBuilderImpl.build(textWithImports, reference, myPosition);
evaluator.evaluate(myEvalContext);
//collect only expressions that do not produce any exceptions on evaluation
myExpressions.add(textWithImports);
}
catch (EvaluateException ignored) {
}
myExpressions.add(new TextWithImportsImpl(reference));
}
}
}