MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-30 18:28:55 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java-inspections] IDEA-275886 IntelliJ is proposing wrong usage of equalsIgnoreCase refactoring

Browse Source 
GitOrigin-RevId: 2f7e2091e31c781e42908c9fb0b849f56e50065c
This commit is contained in:
Tagir Valeev
2021-08-12 16:19:39 +07:00
committed by intellij-monorepo-bot
parent c8d6184c46
commit c0571a10d5
3 changed files with 50 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantStringOperation/afterChangeCase.java
View File

@@ -12,16 +12,16 @@ public class Main {
boolean value2WithBrackets = ("foo").equalsIgnoreCase((args[0]));
boolean value3WithBrackets = (args[0].toLowerCase()).equalsIgnoreCase((args[0].toLowerCase()));
boolean valueUpperCase1 = args[0].equalsIgnoreCase("foo");
boolean valueUpperCase2 ="foo".equalsIgnoreCase(args[0]) ;
boolean valueUpperCase1 = args[0].equalsIgnoreCase("FOO");
boolean valueUpperCase2 ="FOO".equalsIgnoreCase(args[0]) ;
boolean valueUpperCase3 = args[0].equalsIgnoreCase(args[0]);
boolean valueIgnoreCase = args[0].equalsIgnoreCase("foo");
boolean valueIgnoreCase2 ="foo".equalsIgnoreCase(args[0]) ;
boolean valueIgnoreCase3 = args[0].toLowerCase().equalsIgnoreCase(args[0].toLowerCase());
boolean valueIgnoreCaseUpperCase1 = args[0].equalsIgnoreCase("foo");
boolean valueIgnoreCaseUpperCase2 ="foo".equalsIgnoreCase(args[0]) ;
boolean valueIgnoreCaseUpperCase1 = args[0].equalsIgnoreCase("FOO");
boolean valueIgnoreCaseUpperCase2 ="FOO".equalsIgnoreCase(args[0]) ;
boolean valueIgnoreCaseUpperCase3 = args[0].equalsIgnoreCase(args[0]);
boolean nonChangeValue1 = args[0].toLowerCase(Locale.ROOT).equalsIgnoreCase("foo");
@@ -50,16 +50,16 @@ public class Main {
if(!! args[0].toLowerCase().equalsIgnoreCase(args[0].toLowerCase())){}
if(args[0].equalsIgnoreCase("foo")){}
if("foo".equalsIgnoreCase(args[0].toUpperCase())){}
if(args[0].equalsIgnoreCase("FOO")){}
if("FOO".equalsIgnoreCase(args[0].toUpperCase())){}
if( args[0].toUpperCase().equalsIgnoreCase(args[0].toLowerCase())){}
if(args[0].equalsIgnoreCase("foo")){}
if("foo".equalsIgnoreCase(args[0].toUpperCase())){}
if( args[0].toLowerCase().equalsIgnoreCase(args[0].toLowerCase())){}
if(args[0].equalsIgnoreCase("foo")){}
if("foo".equalsIgnoreCase(args[0].toUpperCase())){}
if(args[0].equalsIgnoreCase("FOO")){}
if("FOO".equalsIgnoreCase(args[0].toUpperCase())){}
if( args[0].toUpperCase().equalsIgnoreCase(args[0].toLowerCase())){}
@@ -74,5 +74,10 @@ public class Main {
if(/* one */args/* two */[/* three */0/* four */]/* six */./* seven */equalsIgnoreCase(/* eight */args/* nine */[/* ten */1/* eleven */]/* fourteen */)){}
/* five */
if(!/* one */args/* two */[/* three */0/* four */]/* six */./* seven */equalsIgnoreCase(/* eight */"foo" /* nine */)){}
if("HELLO".equals(args[0].toLowerCase())) {}
if("Hello".equals(args[0].toLowerCase())) {}
if("hello".equals(args[0].toUpperCase())) {}
if("Hello".equals(args[0].toUpperCase())) {}
}
}

21
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantStringOperation/beforeChangeCase.java
View File

@@ -12,16 +12,16 @@ public class Main {
boolean value2WithBrackets = ("foo").equals((args[0].toLowerCase()));
boolean value3WithBrackets = (args[0].toLowerCase().toLowerCase()).equals((args[0].toLowerCase().toLowerCase()));
boolean valueUpperCase1 = args[0].toUpperCase().equals("foo");
boolean valueUpperCase2 ="foo".equals(args[0].toUpperCase()) ;
boolean valueUpperCase1 = args[0].toUpperCase().equals("FOO");
boolean valueUpperCase2 ="FOO".equals(args[0].toUpperCase()) ;
boolean valueUpperCase3 = args[0].toUpperCase().equals(args[0].toUpperCase());
boolean valueIgnoreCase = args[0].toLowerCase().equalsIgnoreCase("foo");
boolean valueIgnoreCase2 ="foo".equalsIgnoreCase(args[0].toLowerCase()) ;
boolean valueIgnoreCase3 = args[0].toLowerCase().toLowerCase().equalsIgnoreCase(args[0].toLowerCase().toLowerCase());
boolean valueIgnoreCaseUpperCase1 = args[0].toUpperCase().equalsIgnoreCase("foo");
boolean valueIgnoreCaseUpperCase2 ="foo".equalsIgnoreCase(args[0].toUpperCase()) ;
boolean valueIgnoreCaseUpperCase1 = args[0].toUpperCase().equalsIgnoreCase("FOO");
boolean valueIgnoreCaseUpperCase2 ="FOO".equalsIgnoreCase(args[0].toUpperCase()) ;
boolean valueIgnoreCaseUpperCase3 = args[0].toUpperCase().equalsIgnoreCase(args[0].toUpperCase());
boolean nonChangeValue1 = args[0].toLowerCase(Locale.ROOT).equalsIgnoreCase("foo");
@@ -50,16 +50,16 @@ public class Main {
if(!! args[0].toLowerCase().toLowerCase().equals(args[0].toLowerCase().toLowerCase())){}
if(args[0].toUpperCase().equals("foo")){}
if("foo".equals(args[0].toUpperCase().toUpperCase())){}
if(args[0].toUpperCase().equals("FOO")){}
if("FOO".equals(args[0].toUpperCase().toUpperCase())){}
if( args[0].toUpperCase().toUpperCase().equals(args[0].toLowerCase().toUpperCase())){}
if(args[0].toLowerCase().equalsIgnoreCase("foo")){}
if("foo".equalsIgnoreCase(args[0].toUpperCase().toLowerCase())){}
if( args[0].toLowerCase().toLowerCase().equalsIgnoreCase(args[0].toLowerCase().toLowerCase())){}
if(args[0].toUpperCase().equalsIgnoreCase("foo")){}
if("foo".equalsIgnoreCase(args[0].toUpperCase().toUpperCase())){}
if(args[0].toUpperCase().equalsIgnoreCase("FOO")){}
if("FOO".equalsIgnoreCase(args[0].toUpperCase().toUpperCase())){}
if( args[0].toUpperCase().toUpperCase().equalsIgnoreCase(args[0].toLowerCase().toUpperCase())){}
@@ -67,5 +67,10 @@ public class Main {
if(/* one */"foo"/* two */./* three */equals(/* four */args/* five */[/* six */0/* seven */]/* eight */./* nine */toLowerCase()/* ten */)){}
if(/* one */args/* two */[/* three */0/* four */]./* five */toLowerCase()/* six */./* seven */equals(/* eight */args/* nine */[/* ten */1/* eleven */]/* twelve */./* thirteen */toLowerCase()/* fourteen */)){}
if(!/* one */args/* two */[/* three */0/* four */]./* five */toLowerCase()/* six */./* seven */equals(/* eight */"foo" /* nine */)){}
if("HELLO".equals(args[0].toLowerCase())) {}
if("Hello".equals(args[0].toLowerCase())) {}
if("hello".equals(args[0].toUpperCase())) {}
if("Hello".equals(args[0].toUpperCase())) {}
}
}