MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 14:23:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-46592 Use of function parameter marked as possibly used before assignment

Browse Source 
Create DELETE instructions only for unqualified names, as it seems we don't need other ones at the moment.


Merge-request: IJ-MR-159047
Merged-by: Aleksandr Govenko <aleksandr.govenko@jetbrains.com>

(cherry picked from commit e0d9c636c20facf587cb96d8117e6f5f804b847a)

IJ-MR-159047

GitOrigin-RevId: df8a820d13d2cffba0b24db975b30dfce809a678
This commit is contained in:
Aleksandr.Govenko
2025-04-23 22:31:19 +00:00
committed by intellij-monorepo-bot
parent 0e075b98cb
commit b571f8a1a3
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/python-psi-impl/src/com/jetbrains/python/codeInsight/controlflow/PyControlFlowBuilder.java
View File

@@ -39,8 +39,6 @@ import org.jetbrains.annotations.Nullable;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import static com.jetbrains.python.psi.PyUtil.as;
public class PyControlFlowBuilder extends PyRecursiveElementVisitor { public class PyControlFlowBuilder extends PyRecursiveElementVisitor {
private final ControlFlowBuilder myBuilder = new ControlFlowBuilder(); private final ControlFlowBuilder myBuilder = new ControlFlowBuilder();
@@ -219,11 +217,13 @@ public class PyControlFlowBuilder extends PyRecursiveElementVisitor {
myBuilder.startNode(node); myBuilder.startNode(node);
for (PyExpression target : node.getTargets()) { for (PyExpression target : node.getTargets()) {
if (target instanceof PyReferenceExpression expr) { if (target instanceof PyReferenceExpression expr) {
myBuilder.addNode(ReadWriteInstruction.newInstruction(myBuilder, target, expr.getName(), ReadWriteInstruction.ACCESS.DELETE));
PyExpression qualifier = expr.getQualifier(); PyExpression qualifier = expr.getQualifier();
if (qualifier != null) { if (qualifier != null) {
qualifier.accept(this); qualifier.accept(this);
} }
else {
myBuilder.addNode(ReadWriteInstruction.newInstruction(myBuilder, target, expr.getName(), ReadWriteInstruction.ACCESS.DELETE));
}
} }
else { else {
target.accept(this); target.accept(this);

9
python/testSrc/com/jetbrains/python/inspections/PyUnboundLocalVariableInspectionTest.java
View File

@@ -319,6 +319,15 @@ public class PyUnboundLocalVariableInspectionTest extends PyInspectionTestCase {
""" """
); );
} }
// PY-46592
public void testUseParameterAfterDeletingAttribute() {
doTestByText("""
def func(foo, bar):
del foo.bar
print(bar) # false positive
""");
}
// PY-4537 // PY-4537
public void testReferencedAfterDeletion() { public void testReferencedAfterDeletion() {