IDEA-119052 Java smart type code completion proposes incorrect variant if non-matching local variable hides a matching instance variable

java/java-tests/testData/codeInsight/completion/smartType/NoHiddenParameter-out.java

@@ -0,0 +1,18 @@
+import java.util.Collection;
+
+class A {
+  String join(Collection<String> strings) {
+    return StringUtil.join(strings, ",");
+  }
+
+  void method(Collection<String> param) {
+    new ActionListener() {
+      @Override
+      public void actionPerformed(ActionEvent e) {
+        String[] param = {""}; // hides the parameter
+        Collection<String> params = Arrays.asList(param);
+        join(params)<caret>
+      }
+    };
+  }
+}

java/java-tests/testData/codeInsight/completion/smartType/NoHiddenParameter.java

@@ -0,0 +1,18 @@
+import java.util.Collection;
+
+class A {
+  String join(Collection<String> strings) {
+    return StringUtil.join(strings, ",");
+  }
+
+  void method(Collection<String> param) {
+    new ActionListener() {
+      @Override
+      public void actionPerformed(ActionEvent e) {
+        String[] param = {""}; // hides the parameter
+        Collection<String> params = Arrays.asList(param);
+        join(<caret>)
+      }
+    };
+  }
+}

java/java-tests/testSrc/com/intellij/codeInsight/completion/SmartTypeCompletionTest.java

@@ -994,6 +994,8 @@ public class SmartTypeCompletionTest extends LightFixtureCompletionTestCase {
 
   public void testCaseMissingEnumValue() throws Throwable { doTest(); }
   public void testCaseMissingEnumValue2() throws Throwable { doTest(); }
+  
+  public void testNoHiddenParameter() { doTest(); }
 
   public void testTypeVariableInstanceOf() throws Throwable {
     configureByTestName();
@@ -1106,7 +1108,7 @@ public class SmartTypeCompletionTest extends LightFixtureCompletionTestCase {
     complete();
   }
 
-  private void doTest() throws Exception {
+  private void doTest() {
     doTest(Lookup.NORMAL_SELECT_CHAR);
   }