MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 22:51:17 +07:00
Code Issues Packages Projects Releases Wiki Activity

ComparatorResultComparisonInspection: support >/>=/</<= checks

Browse Source 
Additional fix for IDEA-173177. Now conditions like "a.compareTo(b) > 1" are warned as well.
This commit is contained in:
Tagir Valeev
2017-06-08 10:10:36 +07:00
parent 6643c4a636
commit a5dcf8841f
5 changed files with 77 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/ComparatorResultComparison.java Normal file
View File

@@ -0,0 +1,19 @@
import java.util.*;
class Test {
void test(Comparator<String> cmp) {
if(cmp.compare("a", "b") <warning descr="Comparison of compare method result with specific constant">!=</warning> -1) {
System.out.println("Oops");
}
if(cmp.compare("a", "b") <warning descr="Comparison of compare method result with specific constant">></warning> 1) {
System.out.println("Bad");
}
if(cmp.compare("a", "b") >= 1) {
System.out.println("Ok");
}
if(cmp.compare("a", "b") < 1) {
System.out.println("Ok");
}
}
}

10
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/afterComparator.java
View File

@@ -1,10 +0,0 @@
// "Replace with '>= 0'" "true"
import java.util.*;
class Test {
void test(Comparator<String> cmp) {
if(cmp.compare("a", "b") >= 0) {
System.out.println("Oops");
}
}
}

10
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/beforeComparator.java
View File

@@ -1,10 +0,0 @@
// "Replace with '>= 0'" "true"
import java.util.*;
class Test {
void test(Comparator<String> cmp) {
if(cmp.compare("a", "b") !<caret>= -1) {
System.out.println("Oops");
}
}
}

41
java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/quickFix/ComparatorResultComparisonInspectionTest.java
View File

@@ -15,25 +15,46 @@
*/
package com.intellij.java.codeInsight.daemon.quickFix;
import com.intellij.JavaTestUtil;
import com.intellij.codeInsight.daemon.quickFix.LightQuickFixParameterizedTestCase;
import com.intellij.codeInspection.ComparatorResultComparisonInspection;
import com.intellij.codeInspection.InspectionProfileEntry;
import com.intellij.codeInspection.LocalInspectionTool;
import com.siyeh.ig.LightInspectionTestCase;
import org.jetbrains.annotations.NotNull;
public class ComparatorResultComparisonInspectionTest extends LightQuickFixParameterizedTestCase {
@NotNull
@Override
protected LocalInspectionTool[] configureLocalInspectionTools() {
return new LocalInspectionTool[]{
new ComparatorResultComparisonInspection()
};
public class ComparatorResultComparisonInspectionTest extends LightInspectionTestCase {
public static final String TEST_DATA_DIR = "/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/";
public void testComparatorResultComparison() {
doTest();
}
public void test() throws Exception { doAllTests(); }
@Override
protected InspectionProfileEntry getInspection() {
return new ComparatorResultComparisonInspection();
}
@Override
protected String getBasePath() {
return "/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison";
return JavaTestUtil.getRelativeJavaTestDataPath() + TEST_DATA_DIR;
}
}
public static class ComparatorResultComparisonInspectionFixTest extends LightQuickFixParameterizedTestCase {
@NotNull
@Override
protected LocalInspectionTool[] configureLocalInspectionTools() {
return new LocalInspectionTool[]{new ComparatorResultComparisonInspection()};
}
public void test() throws Exception {
doAllTests();
}
@Override
protected String getBasePath() {
return TEST_DATA_DIR;
}
}
}