Cleanup (minor optimization; typos; formatting)

GitOrigin-RevId: 7022f336b562f965bf63a628e7679e0c6fc7dcff
This commit is contained in:
Roman Shevchenko
2025-10-06 22:08:21 +00:00
committed by intellij-monorepo-bot
parent 88f432bdc4
commit a59527ec0e
6 changed files with 63 additions and 104 deletions
@@ -1,4 +1,4 @@
// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.jetbrains.intellij.build.pycharm
import kotlinx.collections.immutable.persistentListOf
@@ -43,7 +43,7 @@ open class PyCharmCommunityProperties(protected val communityHome: Path) : PyCha
mavenArtifacts.forIdeModules = true
additionalVmOptions = persistentListOf("-Dllm.show.ai.promotion.window.on.start=false")
qodanaProductProperties = QodanaProductProperties("QDPYC", "Qodana Community for Python")
qodanaProductProperties = QodanaProductProperties(@Suppress("SpellCheckingInspection") "QDPYC", "Qodana Community for Python")
}
override suspend fun copyAdditionalFiles(context: BuildContext, targetDir: Path) {
@@ -54,52 +54,45 @@ open class PyCharmCommunityProperties(protected val communityHome: Path) : PyCha
copyFileToDir(context.paths.communityHomeDir.resolve("NOTICE.txt"), licenseTargetDir)
}
override fun getSystemSelector(appInfo: ApplicationInfoProperties, buildNumber: String): String {
return "PyCharmCE${appInfo.majorVersion}.${appInfo.minorVersionMainPart}"
}
override fun getSystemSelector(appInfo: ApplicationInfoProperties, buildNumber: String): String =
"PyCharmCE${appInfo.majorVersion}.${appInfo.minorVersionMainPart}"
override fun getBaseArtifactName(appInfo: ApplicationInfoProperties, buildNumber: String): String = "pycharmPC-$buildNumber"
override fun createWindowsCustomizer(projectHome: String): WindowsDistributionCustomizer {
return PyCharmCommunityWindowsDistributionCustomizer(communityHome)
}
override fun createLinuxCustomizer(projectHome: String): LinuxDistributionCustomizer {
return object : PyCharmCommunityLinuxDistributionCustomizer(communityHome) {
init {
snapName = "pycharm-community"
snapDescription = "Python IDE for professional developers. Save time while PyCharm takes care of the routine. " +
"Focus on bigger things and embrace the keyboard-centric approach to get the most of PyCharm’s many productivity features."
}
override fun createWindowsCustomizer(projectHome: String): WindowsDistributionCustomizer = object : WindowsDistributionCustomizer() {
init {
icoPath = "${communityHome}/python/build/resources/PyCharmCore.ico"
icoPathForEAP = "${communityHome}/python/build/resources/PyCharmCore_EAP.ico"
installerImagesPath = "${communityHome}/python/build/resources"
fileAssociations = listOf("py")
}
override fun getFullNameIncludingEdition(appInfo: ApplicationInfoProperties) = "PyCharm Community Edition"
override suspend fun copyAdditionalFiles(context: BuildContext, targetDir: Path, arch: JvmArchitecture) {
super.copyAdditionalFiles(context, targetDir, arch)
PyCharmBuildUtils.copySkeletons(context, targetDir, "skeletons-win*.zip")
}
override fun getUninstallFeedbackPageUrl(appInfo: ApplicationInfoProperties): String =
"https://www.jetbrains.com/pycharm/uninstall/?version=${appInfo.productCode}-${appInfo.majorVersion}.${appInfo.minorVersion}"
}
override fun createMacCustomizer(projectHome: String): MacDistributionCustomizer {
return PyCharmMacDistributionCustomizer(communityHome)
override fun createMacCustomizer(projectHome: String): MacDistributionCustomizer = PyCharmMacDistributionCustomizer(communityHome)
override fun createLinuxCustomizer(projectHome: String): LinuxDistributionCustomizer = object : LinuxDistributionCustomizer() {
init {
iconPngPath = "${communityHome}/python/build/resources/PyCharmCore128.png"
iconPngPathForEAP = "${communityHome}/python/build/resources/PyCharmCore128_EAP.png"
snapName = "pycharm-community"
snapDescription =
"Python IDE for professional developers. Save time while PyCharm takes care of the routine. " +
"Focus on bigger things and embrace the keyboard-centric approach to get the most of PyCharm’s many productivity features."
}
override fun getRootDirectoryName(appInfo: ApplicationInfoProperties, buildNumber: String): String =
"pycharm-community-${if (appInfo.isEAP) buildNumber else appInfo.fullVersion}"
}
override fun getOutputDirectoryName(appInfo: ApplicationInfoProperties): String = "pycharm-ce"
}
private class PyCharmCommunityWindowsDistributionCustomizer(projectHome: Path) : PyCharmWindowsDistributionCustomizer() {
init {
icoPath = "$projectHome/python/build/resources/PyCharmCore.ico"
icoPathForEAP = "$projectHome/python/build/resources/PyCharmCore_EAP.ico"
installerImagesPath = "$projectHome/python/build/resources"
fileAssociations = listOf("py")
}
override fun getFullNameIncludingEdition(appInfo: ApplicationInfoProperties) = "PyCharm Community Edition"
}
private open class PyCharmCommunityLinuxDistributionCustomizer(projectHome: Path) : LinuxDistributionCustomizer() {
init {
iconPngPath = "$projectHome/python/build/resources/PyCharmCore128.png"
iconPngPathForEAP = "$projectHome/python/build/resources/PyCharmCore128_EAP.png"
}
override fun getRootDirectoryName(appInfo: ApplicationInfoProperties, buildNumber: String): String {
return "pycharm-community-${if (appInfo.isEAP) buildNumber else appInfo.fullVersion}"
}
}
@@ -1,4 +1,4 @@
// Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.jetbrains.intellij.build.pycharm
import org.jetbrains.intellij.build.ApplicationInfoProperties
@@ -25,7 +25,6 @@ open class PyCharmMacDistributionCustomizer(projectHome: Path) : MacDistribution
PyCharmBuildUtils.copySkeletons(context, targetDir, "skeletons-mac*.zip")
}
override fun getCustomIdeaProperties(appInfo: ApplicationInfoProperties): Map<String, String> {
return mapOf("ide.mac.useNativeClipboard" to "false")
}
override fun getCustomIdeaProperties(appInfo: ApplicationInfoProperties): Map<String, String> =
mapOf("ide.mac.useNativeClipboard" to "false")
}
@@ -1,19 +0,0 @@
// Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.jetbrains.intellij.build.pycharm
import org.jetbrains.intellij.build.ApplicationInfoProperties
import org.jetbrains.intellij.build.BuildContext
import org.jetbrains.intellij.build.JvmArchitecture
import org.jetbrains.intellij.build.WindowsDistributionCustomizer
import java.nio.file.Path
open class PyCharmWindowsDistributionCustomizer : WindowsDistributionCustomizer() {
override suspend fun copyAdditionalFiles(context: BuildContext, targetDir: Path, arch: JvmArchitecture) {
super.copyAdditionalFiles(context, targetDir, arch)
PyCharmBuildUtils.copySkeletons(context, targetDir, "skeletons-win*.zip")
}
override fun getUninstallFeedbackPageUrl(appInfo: ApplicationInfoProperties): String? {
return "https://www.jetbrains.com/pycharm/uninstall/?version=${appInfo.productCode}-${appInfo.majorVersion}.${appInfo.minorVersion}"
}
}