OptionalAssignedToNull: added optional (sic!) warning on optional == null comparison

Fixes IDEA-187578 Inspection to detect when Optional is compared with null
This commit is contained in:
Tagir Valeev
2018-03-07 16:20:10 +07:00
parent 68716c68fb
commit a24ad7b268
6 changed files with 94 additions and 8 deletions
@@ -0,0 +1,20 @@
// "Fix all 'Null value for Optional type' problems in file" "true"
import java.util.List;
import java.util.Optional;
import java.util.OptionalInt;
public class Test {
void test(Optional<String> opt) {
if(!opt.isPresent()) {
System.out.println("null!");
}
}
void test2 (Optional<String> opt) {
/*comment*/
if(opt.isPresent()) {
System.out.println("null!");
}
}
}
@@ -16,7 +16,7 @@ public class Test {
}
OptionalInt opt() {
return OptionalInt.empty();
return (/*comment*/OptionalInt.empty());
}
void m(Optional<String> opt) {}
@@ -0,0 +1,19 @@
// "Fix all 'Null value for Optional type' problems in file" "true"
import java.util.List;
import java.util.Optional;
import java.util.OptionalInt;
public class Test {
void test(Optional<String> opt) {
if(opt =<caret>= null) {
System.out.println("null!");
}
}
void test2 (Optional<String> opt) {
if(opt !=/*comment*/ null) {
System.out.println("null!");
}
}
}
@@ -16,7 +16,7 @@ public class Test {
}
OptionalInt opt() {
return null;
return (/*comment*/null);
}
void m(Optional<String> opt) {}