MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-06 03:21:12 +07:00
Code Issues Packages Projects Releases Wiki Activity

Java: introduce another visitSwitchBlock() method

Browse Source 
GitOrigin-RevId: 97f3edcab34837c124e1426d97a6d6590e67a053
This commit is contained in:
Bas Leijdekkers
2024-09-06 09:41:22 +02:00
committed by intellij-monorepo-bot
parent 7e0038ce14
commit 9eb3b6bb58
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
java/java-analysis-impl/src/com/siyeh/ig/bugs/EqualsWhichDoesntCheckParameterClassInspection.java
View File

@@ -213,27 +213,26 @@ public class EqualsWhichDoesntCheckParameterClassInspection extends BaseInspecti
@Override
public void visitSwitchExpression(@NotNull PsiSwitchExpression expression) {
super.visitSwitchExpression(expression);
if (isParameterReference(expression.getExpression()) && checksTypeOfExpression(expression)) {
makeChecked();
}
visitSwitchBlock(expression);
}
@Override
public void visitSwitchStatement(@NotNull PsiSwitchStatement statement) {
super.visitSwitchStatement(statement);
if (isParameterReference(statement.getExpression()) && checksTypeOfExpression(statement)) {
makeChecked();
}
visitSwitchBlock(statement);
}
private static boolean checksTypeOfExpression(@NotNull PsiSwitchBlock switchBlock) {
private void visitSwitchBlock(@NotNull PsiSwitchBlock switchBlock) {
if (!isParameterReference(switchBlock.getExpression())) return;
PsiCodeBlock body = switchBlock.getBody();
return body != null && PsiTreeUtil.getChildrenOfTypeAsList(body, PsiSwitchLabelStatementBase.class)
if (body == null) return;
boolean checksType = PsiTreeUtil.getChildrenOfTypeAsList(body, PsiSwitchLabelStatementBase.class)
.stream()
.map(PsiSwitchLabelStatementBase::getCaseLabelElementList)
.filter(Objects::nonNull)
.flatMap(list -> Arrays.stream(list.getElements()))
.anyMatch(element -> element instanceof PsiTypeTestPattern);
if (checksType) makeChecked();
}
@Override