MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Java inspection: Added @NotNull and @Nullable in QuickFixFactory methods. (IDEA-158456, IDEA-157727)

Browse Source
This commit is contained in:
Pavel Dolgov
2016-07-20 16:04:27 +03:00
parent d350ba7be2
commit 969585320b
3 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-api/src/com/intellij/codeInsight/intention/QuickFixFactory.java
+3 -2
View File
@@ -272,8 +272,9 @@ public abstract class QuickFixFactory {
@NotNull
public abstract IntentionAction createWrapWithOptionalFix(@Nullable PsiType type, @NotNull PsiExpression expression);
public abstract IntentionAction createNotIterableForEachLoopFix(PsiExpression expression);
@Nullable
public abstract IntentionAction createNotIterableForEachLoopFix(@NotNull PsiExpression expression);
@NotNull
public abstract List<IntentionAction> createAddAnnotationAttributeNameFixes(PsiNameValuePair pair);
public abstract List<IntentionAction> createAddAnnotationAttributeNameFixes(@NotNull PsiNameValuePair pair);
}
java/java-analysis-impl/src/com/intellij/codeInsight/intention/EmptyQuickFixFactory.java
+3 -3
View File
@@ -16,7 +16,6 @@
package com.intellij.codeInsight.intention;
import com.intellij.codeInsight.daemon.QuickFixActionRegistrar;
import com.intellij.codeInspection.IntentionAndQuickFixAction;
import com.intellij.codeInspection.LocalQuickFix;
import com.intellij.codeInspection.LocalQuickFixAndIntentionActionOnPsiElement;
import com.intellij.codeInspection.LocalQuickFixOnPsiElement;
@@ -627,14 +626,15 @@ public class EmptyQuickFixFactory extends QuickFixFactory {
return QuickFixes.EMPTY_FIX;
}
@Nullable
@Override
public IntentionAction createNotIterableForEachLoopFix(PsiExpression expression) {
public IntentionAction createNotIterableForEachLoopFix(@NotNull PsiExpression expression) {
return QuickFixes.EMPTY_FIX;
}
@NotNull
@Override
public List<IntentionAction> createAddAnnotationAttributeNameFixes(PsiNameValuePair pair) {
public List<IntentionAction> createAddAnnotationAttributeNameFixes(@NotNull PsiNameValuePair pair) {
return Collections.emptyList();
}
}
java/java-impl/src/com/intellij/codeInsight/intention/impl/config/QuickFixFactoryImpl.java
+3 -2
View File
@@ -778,8 +778,9 @@ public class QuickFixFactoryImpl extends QuickFixFactory {
return WrapObjectWithOptionalOfNullableFix.createFix(type, expression);
}
@Nullable
@Override
public IntentionAction createNotIterableForEachLoopFix(PsiExpression expression) {
public IntentionAction createNotIterableForEachLoopFix(@NotNull PsiExpression expression) {
final PsiElement parent = expression.getParent();
if (parent instanceof PsiForeachStatement) {
final PsiType type = expression.getType();
@@ -792,7 +793,7 @@ public class QuickFixFactoryImpl extends QuickFixFactory {
@NotNull
@Override
public List<IntentionAction> createAddAnnotationAttributeNameFixes(PsiNameValuePair pair) {
public List<IntentionAction> createAddAnnotationAttributeNameFixes(@NotNull PsiNameValuePair pair) {
return AddAnnotationAttributeNameFix.createFixes(pair);
}