MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 14:23:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

UnstableTypeUsedInSignature: do not emit warning if declaration is containing inside private or package local class.

Browse Source 
GitOrigin-RevId: 3c55d941a582af00a01faf65f14a4d8fc07dc709
This commit is contained in:
Sergey Patrikeev
2019-06-25 20:17:08 +03:00
committed by intellij-monorepo-bot
parent ddc5ccd24c
commit 9329e65e5b
13 changed files with 143 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
jvm/jvm-analysis-impl/src/com/intellij/codeInspection/UnstableTypeUsedInSignatureInspection.kt
View File

@@ -80,14 +80,14 @@ private class UnstableTypeUsedInSignatureVisitor(
}
private fun isAccessibleDeclaration(node: UDeclaration): Boolean {
if (node.visibility == UastVisibility.PRIVATE) {
if (node.visibility == UastVisibility.PRIVATE || node.visibility == UastVisibility.PACKAGE_LOCAL) {
if (node is UField) {
//Kotlin properties are UField with accompanying getters\setters.
//Kotlin properties are private UFields with accompanying getters\setters.
val psiField = node.javaPsi
if (psiField is PsiField) {
val getter = PropertyUtil.findGetterForField(psiField)
val setter = PropertyUtil.findSetterForField(psiField)
return getter != null && !getter.hasModifier(JvmModifier.PRIVATE) || setter != null && !setter.hasModifier(JvmModifier.PRIVATE)
val getter = PropertyUtil.findGetterForField(psiField)?.toUElement(UMethod::class.java)
val setter = PropertyUtil.findSetterForField(psiField)?.toUElement(UMethod::class.java)
return getter != null && isAccessibleDeclaration(getter) || setter != null && isAccessibleDeclaration(setter)
}
}
return false