MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 22:51:17 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-76629: Suppress PyProtectedMemberInspection if a member is defined in .pyi

Browse Source 
Protected member should not be highlighted as a warning if it resolves to .pyi file.
We assume that everything in .pyi file is a public API.

GitOrigin-RevId: c8275f3e48e3cd69b1676de9b78606f28ea224c8
This commit is contained in:
Ilia Zakoulov
2024-08-27 14:51:54 +02:00
committed by intellij-monorepo-bot
parent 214f894da3
commit 91f27d8587
5 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/python-psi-impl/src/com/jetbrains/python/pyi/PyiInspectionExtension.kt
View File

@@ -20,6 +20,7 @@ import com.jetbrains.python.inspections.PyInspectionExtension
import com.jetbrains.python.psi.PyFromImportStatement import com.jetbrains.python.psi.PyFromImportStatement
import com.jetbrains.python.psi.PyImportElement import com.jetbrains.python.psi.PyImportElement
import com.jetbrains.python.psi.PyImportStatement import com.jetbrains.python.psi.PyImportStatement
import com.jetbrains.python.psi.PyReferenceExpression
import com.jetbrains.python.psi.types.TypeEvalContext import com.jetbrains.python.psi.types.TypeEvalContext
class PyiInspectionExtension : PyInspectionExtension() { class PyiInspectionExtension : PyInspectionExtension() {
@@ -35,4 +36,9 @@ class PyiInspectionExtension : PyInspectionExtension() {
} }
return elements.isEmpty() || elements.any { it.asName != null } return elements.isEmpty() || elements.any { it.asName != null }
} }
override fun ignoreProtectedSymbol(expression: PyReferenceExpression, context: TypeEvalContext): Boolean {
val referencedElement = expression.reference.resolve()
return referencedElement?.containingFile is PyiFile
}
} }

4
python/testData/pyi/inspections/accessProtectedProperty/AccessProtectedProperty.py Normal file
View File

@@ -0,0 +1,4 @@
from test import MyClass
public_api = MyClass._public_api
not_public_api = <weak_warning descr="Access to a protected member _not_public_api of a class">MyClass._not_public_api</weak_warning>

4
python/testData/pyi/inspections/accessProtectedProperty/test.py Normal file
View File

@@ -0,0 +1,4 @@
class MyClass:
def __init__(self):
self._public_api = "abacaba"
self._not_public_api = "qwerty"

3
python/testData/pyi/inspections/accessProtectedProperty/test.pyi Normal file
View File

@@ -0,0 +1,3 @@
class MyClass:
def __init__(self) -> None: ...
_public_api: str

4
python/testSrc/com/jetbrains/python/pyi/PyiInspectionsTest.java
View File

@@ -16,6 +16,7 @@
package com.jetbrains.python.pyi; package com.jetbrains.python.pyi;
import com.intellij.codeInspection.LocalInspectionTool; import com.intellij.codeInspection.LocalInspectionTool;
import com.intellij.idea.TestFor;
import com.intellij.openapi.Disposable; import com.intellij.openapi.Disposable;
import com.intellij.openapi.util.Disposer; import com.intellij.openapi.util.Disposer;
import com.intellij.psi.PsiDocumentManager; import com.intellij.psi.PsiDocumentManager;
@@ -149,4 +150,7 @@ public class PyiInspectionsTest extends PyTestCase {
public void testMissedSuperInitCall() { public void testMissedSuperInitCall() {
doPyiTest(PyMissingConstructorInspection.class); doPyiTest(PyMissingConstructorInspection.class);
} }
@TestFor(issues = "PY-16477")
public void testAccessProtectedProperty() { doPyTest(PyProtectedMemberInspection.class); }
} }